Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Sergey Bylokhov-2
On Tue, 9 Mar 2021 00:49:09 GMT, Yasumasa Suenaga <[hidden email]> wrote:

>> Did you check via some a11y tool that the new code actually works?
>
> No, can you help?

I'll check.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Sergey Bylokhov-2
On Mon, 8 Mar 2021 00:56:24 GMT, Yasumasa Suenaga <[hidden email]> wrote:

>> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale):
>>
>> AccessBridgeDebug.cpp
>> メモ: インクルード ファイル: d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h
>>
>>     :
>>
>> c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\ostream(611): error C2220: 次の警
>> 告はエラーとして処理されます
>> c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\ostream(611): warning C4530: C++
>> 例外処理を使っていますが、アンワインド セマンティクスは有効にはなりません。/EHsc を指定してください。
>> メモ: インクルード ファイル: c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\string
>>
>> `/EHsc` has been already passed in other makefiles, and also AccessBridgeDebug.cpp uses some STL classes (e.g. `chrono` namespace). So `/EHsc` is a solution for this problem.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>
>   Refactoring

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Sergey Bylokhov-2
In reply to this post by Sergey Bylokhov-2
On Wed, 10 Mar 2021 01:40:39 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> No, can you help?
>
> I'll check.

This change looks fine, I was able to see the proper logs in the java_access_bridge.log, but I cannot find the logs from the windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal please take a look at why the windows log might be missed if "JAVA_ACCESSBRIDGE_LOGDIR" is set.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Sergey Bylokhov-2
On Sat, 13 Mar 2021 01:56:06 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> I'll check.
>
> This change looks fine, I was able to see the proper logs in the java_access_bridge.log, but I cannot find the logs from the windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal please take a look at why the windows log might be missed if "JAVA_ACCESSBRIDGE_LOGDIR" is set.

For the record: the jaws J2021.2102.34.400 was used for testing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Yasumasa Suenaga-7
On Sat, 13 Mar 2021 01:57:53 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> This change looks fine, I was able to see the proper logs in the java_access_bridge.log, but I cannot find the logs from the windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal please take a look at why the windows log might be missed if "JAVA_ACCESSBRIDGE_LOGDIR" is set.
>
> For the record: the jaws J2021.2102.34.400 was used for testing.

Thanks @mrserb for the test!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Pankaj Bansal-2
In reply to this post by Sergey Bylokhov-2
On Sat, 13 Mar 2021 01:57:53 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> This change looks fine, I was able to see the proper logs in the java_access_bridge.log, but I cannot find the logs from the windows_access_bridge.log. It seems unrelated to this fix. @pankaj-bansal please take a look at why the windows log might be missed if "JAVA_ACCESSBRIDGE_LOGDIR" is set.
>
> For the record: the jaws J2021.2102.34.400 was used for testing.

@mrserb Did you close the JAWS after running the program. I have seen that the logs for windows_access_bridge are flushed only after the JAWS is closed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

Sergey Bylokhov-2
On Sun, 14 Mar 2021 17:27:58 GMT, Pankaj Bansal <[hidden email]> wrote:

>> For the record: the jaws J2021.2102.34.400 was used for testing.
>
> @mrserb Did you close the JAWS after running the program. I have seen that the logs for windows_access_bridge are flushed only after the JAWS is closed.

Nope! thank you for confirmation that win logs it works as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859