These closing tags are optional in html5 standard . On the link to the SO there are three the example which work differently but according standards.
----- [hidden email] wrote:
Why do we omitting closing th tag?
+ * <caption>Metal's system color mapping</caption> + * <thead> + * <tr> + * <th>Key + * <th>Value + * </thead>
I know that HTML parsers are usually forgiving such things. But
sometimes it may make thing worse:
> On 05/06/2017 06:23, Sergey Bylokhov wrote:
If there are no objections I'll change the target ws from dev to client, to minimize the merges between some other javadoc fixes. ----- [hidden email] wrote:Hello. Here is an updated version where most of the caption are visible. Bug: https://bugs.openjdk.java.net/browse/JDK-8180326 Webrev can be found at: http://cr.openjdk.java.net/~serb/8180326/webrev.02/ Specdiff: http://cr.openjdk.java.net/~serb/8180326/specdiff.02/overview-summary.html You can use search to check the changes in some specific class: Old docs: http://cr.openjdk.java.net/~serb/8180326/api_old.02/overview-summary.html New docs: http://cr.openjdk.java.net/~serb/8180326/api.02/overview-summary.html ----- [hidden email] wrote:Phil, I have no evidence one way or the other whether screen readers pay attention to undisplayed or invisible captions. It seemed safest to assumethatthey would read a visible caption, and that we should head in that general direction. -- Jon On 05/17/2017 11:58 AM, Phil Race wrote:And PS I was not saying anything to contradicttables should not have a summary attribute and should have acaption.However that the docs I read on the web did seem to imply that summary was very much intended for ATs but it was not at allclearthisis the point of caption. I'm sure they can read it, but I don'tgethow making it visible matters to them so how it making it visible relates toaccessibility requirements is not an obvious connection to me. So why do wehaveto make it visible for ATs ? -phil. On 05/17/2017 11:54 AM, Phil Race wrote:I will leave the decision on whether to do that now up to Sergeyalthough it seems all he has to do here is remove "invisible". Many of the "summary" ones had wrong or misleading text but they seem to have been all fixed. I'd want to see what the new HTML looks like with a visibletitleofcourse .. -phil. On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:Phil, The bottom line is that in the JDK docs, tables should not haveasummary attribute and should have a caption. This comes down toaccessibility requirements, where we are slowly raising the baronour docs, to be in accordance with Oracle's guidelines. Hiding the caption (style="display:none") is an interim measurewehave been using during the HTML 5 updates, especially in caseswherethe person doing the markup changes did not know enough tocreateanappropriate caption that should be displayed. In time, we shouldlocate and update all table captions (in our standard docsbundle)that are not being displayed such that the text is bothappropriateand visible. If you guys want to do that as part of thisupdate,goahead. FWIW, that is what we did for the java.xml module in thejaxprepo ... pretty much all tables there now have a reasonable,visiblecaption. -- Jon On 05/17/2017 11:19 AM, Phil Race wrote:I am not sure we are using the summary in a way that makes it worthwhile. As you noted in the other mail "The summary attribute was used to give a more descriptivevalueof the contents of the table. A caption is more like atitle"The values I see are more like a title and as you say that isnotthe idea. See the example here https://www.w3.org/TR/WCAG20-TECHS/H73.html Caption sounds like a title so it might actually be more appropriate than summary for the text we have except that its not clear why we'd wantittobe visible when we were fine without. But being there and invisible may be pointless unless screen readers look for it even if invisible. But if its not doing any harm I guess we can leave it asproposedI still need to look at the rest of the changes. -phil. On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:Sergey, FWIW, the invisible caption should be regarded as a temporarysolution, until content authors can review/update the text ofthecaption and make it visible. The general guideline in this conversion work has been toavoidchanging the visible text of the specification, and captionsfallinto a grey area of whether the text is significant/normativeornot. Hence the temporary step to make them not displayed fornow.-- Jon On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:The "summary" is unsupported by the HTML5 and we replace itbyinvisible caption. These new styles are located in the stylesheet.css in therootofthe JavaDoc api folder, so I assume these styles should beusedby others as well. They were added by this fix: https://bugs.openjdk.java.net/browse/JDK-8179479 ----- [hidden email] wrote:Does this in any way match the rest of the docs ? Or iseveryoneleft to style things how they want. I thought (?) maybe there is to be some javadoc toolsupportforCSS styles. Also why are all the table summaries removed ? -phil. On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:This is because I use the same style for most of thetables'class="striped"', which apply the same/unified style for all(most) of our tables.Also this is because I removed 'inlined' styles, likehere:----- [hidden email] wrote:Adding 2d-dev because a number of the files are 2D. What is the general reason for changing the appearance ofthetables?-phil. On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:Hello, Please review the fix for jdk9-dev. This fix is a part of the effort to make all javadoc injdk9 becompatible to HTML5.It covers all errors which are reported by the javadoctoolduringthe build of jdk for java.desktop module.Bug: https://bugs.openjdk.java.net/browse/JDK-8180326 Webrev can be found at:Note that an appearance of some tables were changedafterthefix:Before:After:Before:After :Before:After:
Thanks for clarification, looks good to me.
On 07/06/2017 23:22, Sergey Bylokhov wrote:
|Free forum by Nabble||Edit this page|