URGENT RFR(XXS): 8193225 - [BACKOUT] fix for 8182307 Error during JRMP connection

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

URGENT RFR(XXS): 8193225 - [BACKOUT] fix for 8182307 Error during JRMP connection

Daniel D. Daugherty
Resending with the correct subject line!


Greetings,

My fix for the following bug:

     JDK-8182307: Error during JRMP connection establishment
     https://bugs.openjdk.java.net/browse/JDK-8182307

broke two hs-tier3 tests. I'm backing out the fix via:

     JDK-8193225 [BACKOUT] fix for 8182307 Error during JRMP connection
establishment
     https://bugs.openjdk.java.net/browse/JDK-8193225

Here's the webrev:

     http://cr.openjdk.java.net/~dcubed/8193225-webrev/jdk10-0/

This is a simple "hg backout". I need a single (R)eviewer. Thanks!

Dan



On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:

> Greetings,
>
> I have a small fix for a very intermittent ServerSocket related test
> failure:
>
>     JDK-8182307: Error during JRMP connection establishment
>     https://bugs.openjdk.java.net/browse/JDK-8182307
>
> The fix is copied from Jerry's work on the following bugs:
>
>     JDK-8182757 JDWP: Socket Transport handshake hangs on Solaris
>     https://bugs.openjdk.java.net/browse/JDK-8182757
>
>     JDK-8178676 nsk/jvmti/AttachOnDemand/attach045 fails with Exception
>     https://bugs.openjdk.java.net/browse/JDK-8178676
>
> For the gory details of the reasons for this fix please see
> Jerry's bugs.
>
> Webrev URL: http://cr.openjdk.java.net/~dcubed/8182307-webrev/jdk10-0/
>
>
> I observed this test failure one time in my Thread-SMR work and have
> been including this fix in months of Thread-SMR stress testing. It was
> also included in both JPRT and Mach5 tier[1-5] testing of the Thread-SMR
> changes.
>
> Thanks, in advance, for any comments, suggestions or questions.
>
> Dan
>

Reply | Threaded
Open this post in threaded view
|

Re: URGENT RFR(XXS): 8193225 - [BACKOUT] fix for 8182307 Error during JRMP connection

Igor Ignatyev
Reviewed.

-- Igor

> On Dec 7, 2017, at 4:46 PM, Daniel D. Daugherty <[hidden email]> wrote:
>
> Resending with the correct subject line!
>
>
> Greetings,
>
> My fix for the following bug:
>
>     JDK-8182307: Error during JRMP connection establishment
>     https://bugs.openjdk.java.net/browse/JDK-8182307
>
> broke two hs-tier3 tests. I'm backing out the fix via:
>
>     JDK-8193225 [BACKOUT] fix for 8182307 Error during JRMP connection establishment
>     https://bugs.openjdk.java.net/browse/JDK-8193225
>
> Here's the webrev:
>
>     http://cr.openjdk.java.net/~dcubed/8193225-webrev/jdk10-0/
>
> This is a simple "hg backout". I need a single (R)eviewer. Thanks!
>
> Dan
>
>
>
> On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> I have a small fix for a very intermittent ServerSocket related test
>> failure:
>>
>>     JDK-8182307: Error during JRMP connection establishment
>>     https://bugs.openjdk.java.net/browse/JDK-8182307
>>
>> The fix is copied from Jerry's work on the following bugs:
>>
>>     JDK-8182757 JDWP: Socket Transport handshake hangs on Solaris
>>     https://bugs.openjdk.java.net/browse/JDK-8182757
>>
>>     JDK-8178676 nsk/jvmti/AttachOnDemand/attach045 fails with Exception
>>     https://bugs.openjdk.java.net/browse/JDK-8178676
>>
>> For the gory details of the reasons for this fix please see
>> Jerry's bugs.
>>
>> Webrev URL: http://cr.openjdk.java.net/~dcubed/8182307-webrev/jdk10-0/
>>
>>
>> I observed this test failure one time in my Thread-SMR work and have
>> been including this fix in months of Thread-SMR stress testing. It was
>> also included in both JPRT and Mach5 tier[1-5] testing of the Thread-SMR
>> changes.
>>
>> Thanks, in advance, for any comments, suggestions or questions.
>>
>> Dan
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: URGENT RFR(XXS): 8193225 - [BACKOUT] fix for 8182307 Error during JRMP connection

Daniel D. Daugherty
Thanks Igor!

Dan


On 12/7/17 7:57 PM, Igor Ignatyev wrote:

> Reviewed.
>
> -- Igor
>
>> On Dec 7, 2017, at 4:46 PM, Daniel D. Daugherty <[hidden email]> wrote:
>>
>> Resending with the correct subject line!
>>
>>
>> Greetings,
>>
>> My fix for the following bug:
>>
>>      JDK-8182307: Error during JRMP connection establishment
>>      https://bugs.openjdk.java.net/browse/JDK-8182307
>>
>> broke two hs-tier3 tests. I'm backing out the fix via:
>>
>>      JDK-8193225 [BACKOUT] fix for 8182307 Error during JRMP connection establishment
>>      https://bugs.openjdk.java.net/browse/JDK-8193225
>>
>> Here's the webrev:
>>
>>      http://cr.openjdk.java.net/~dcubed/8193225-webrev/jdk10-0/
>>
>> This is a simple "hg backout". I need a single (R)eviewer. Thanks!
>>
>> Dan
>>
>>
>>
>> On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I have a small fix for a very intermittent ServerSocket related test
>>> failure:
>>>
>>>      JDK-8182307: Error during JRMP connection establishment
>>>      https://bugs.openjdk.java.net/browse/JDK-8182307
>>>
>>> The fix is copied from Jerry's work on the following bugs:
>>>
>>>      JDK-8182757 JDWP: Socket Transport handshake hangs on Solaris
>>>      https://bugs.openjdk.java.net/browse/JDK-8182757
>>>
>>>      JDK-8178676 nsk/jvmti/AttachOnDemand/attach045 fails with Exception
>>>      https://bugs.openjdk.java.net/browse/JDK-8178676
>>>
>>> For the gory details of the reasons for this fix please see
>>> Jerry's bugs.
>>>
>>> Webrev URL: http://cr.openjdk.java.net/~dcubed/8182307-webrev/jdk10-0/
>>>
>>>
>>> I observed this test failure one time in my Thread-SMR work and have
>>> been including this fix in months of Thread-SMR stress testing. It was
>>> also included in both JPRT and Mach5 tier[1-5] testing of the Thread-SMR
>>> changes.
>>>
>>> Thanks, in advance, for any comments, suggestions or questions.
>>>
>>> Dan
>>>

Reply | Threaded
Open this post in threaded view
|

Re: URGENT RFR(XXS): 8193225 - [BACKOUT] fix for 8182307 Error during JRMP connection

serguei.spitsyn@oracle.com
In reply to this post by Igor Ignatyev
+1

Sorry, your fix broke two hs-tier3 tests.
I've decided to always run all hs-tier's before any of my integrations. :(

Thanks,
Serguei


On 12/7/17 16:57, Igor Ignatyev wrote:

> Reviewed.
>
> -- Igor
>
>> On Dec 7, 2017, at 4:46 PM, Daniel D. Daugherty <[hidden email]> wrote:
>>
>> Resending with the correct subject line!
>>
>>
>> Greetings,
>>
>> My fix for the following bug:
>>
>>      JDK-8182307: Error during JRMP connection establishment
>>      https://bugs.openjdk.java.net/browse/JDK-8182307
>>
>> broke two hs-tier3 tests. I'm backing out the fix via:
>>
>>      JDK-8193225 [BACKOUT] fix for 8182307 Error during JRMP connection establishment
>>      https://bugs.openjdk.java.net/browse/JDK-8193225
>>
>> Here's the webrev:
>>
>>      http://cr.openjdk.java.net/~dcubed/8193225-webrev/jdk10-0/
>>
>> This is a simple "hg backout". I need a single (R)eviewer. Thanks!
>>
>> Dan
>>
>>
>>
>> On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I have a small fix for a very intermittent ServerSocket related test
>>> failure:
>>>
>>>      JDK-8182307: Error during JRMP connection establishment
>>>      https://bugs.openjdk.java.net/browse/JDK-8182307
>>>
>>> The fix is copied from Jerry's work on the following bugs:
>>>
>>>      JDK-8182757 JDWP: Socket Transport handshake hangs on Solaris
>>>      https://bugs.openjdk.java.net/browse/JDK-8182757
>>>
>>>      JDK-8178676 nsk/jvmti/AttachOnDemand/attach045 fails with Exception
>>>      https://bugs.openjdk.java.net/browse/JDK-8178676
>>>
>>> For the gory details of the reasons for this fix please see
>>> Jerry's bugs.
>>>
>>> Webrev URL: http://cr.openjdk.java.net/~dcubed/8182307-webrev/jdk10-0/
>>>
>>>
>>> I observed this test failure one time in my Thread-SMR work and have
>>> been including this fix in months of Thread-SMR stress testing. It was
>>> also included in both JPRT and Mach5 tier[1-5] testing of the Thread-SMR
>>> changes.
>>>
>>> Thanks, in advance, for any comments, suggestions or questions.
>>>
>>> Dan
>>>

Reply | Threaded
Open this post in threaded view
|

Re: URGENT RFR(XXS): 8193225 - [BACKOUT] fix for 8182307 Error during JRMP connection

Daniel D. Daugherty
On 12/7/17 8:26 PM, [hidden email] wrote:
> +1
>
> Sorry, your fix broke two hs-tier3 tests.

Me too!


> I've decided to always run all hs-tier's before any of my
> integrations. :(

My last test run with the fix for 8182307 by itself was a Mach5 tier[1-5]
job on 11.22... There were no RMI test failures...

I cannot explain what happened (yet)...

Dan


>
> Thanks,
> Serguei
>
>
> On 12/7/17 16:57, Igor Ignatyev wrote:
>> Reviewed.
>>
>> -- Igor
>>
>>> On Dec 7, 2017, at 4:46 PM, Daniel D. Daugherty
>>> <[hidden email]> wrote:
>>>
>>> Resending with the correct subject line!
>>>
>>>
>>> Greetings,
>>>
>>> My fix for the following bug:
>>>
>>>      JDK-8182307: Error during JRMP connection establishment
>>>      https://bugs.openjdk.java.net/browse/JDK-8182307
>>>
>>> broke two hs-tier3 tests. I'm backing out the fix via:
>>>
>>>      JDK-8193225 [BACKOUT] fix for 8182307 Error during JRMP
>>> connection establishment
>>>      https://bugs.openjdk.java.net/browse/JDK-8193225
>>>
>>> Here's the webrev:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8193225-webrev/jdk10-0/
>>>
>>> This is a simple "hg backout". I need a single (R)eviewer. Thanks!
>>>
>>> Dan
>>>
>>>
>>>
>>> On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:
>>>> Greetings,
>>>>
>>>> I have a small fix for a very intermittent ServerSocket related test
>>>> failure:
>>>>
>>>>      JDK-8182307: Error during JRMP connection establishment
>>>>      https://bugs.openjdk.java.net/browse/JDK-8182307
>>>>
>>>> The fix is copied from Jerry's work on the following bugs:
>>>>
>>>>      JDK-8182757 JDWP: Socket Transport handshake hangs on Solaris
>>>>      https://bugs.openjdk.java.net/browse/JDK-8182757
>>>>
>>>>      JDK-8178676 nsk/jvmti/AttachOnDemand/attach045 fails with
>>>> Exception
>>>>      https://bugs.openjdk.java.net/browse/JDK-8178676
>>>>
>>>> For the gory details of the reasons for this fix please see
>>>> Jerry's bugs.
>>>>
>>>> Webrev URL: http://cr.openjdk.java.net/~dcubed/8182307-webrev/jdk10-0/
>>>>
>>>>
>>>> I observed this test failure one time in my Thread-SMR work and have
>>>> been including this fix in months of Thread-SMR stress testing. It was
>>>> also included in both JPRT and Mach5 tier[1-5] testing of the
>>>> Thread-SMR
>>>> changes.
>>>>
>>>> Thanks, in advance, for any comments, suggestions or questions.
>>>>
>>>> Dan
>>>>
>