Withdrawn: 8263028: Windows build fails due to several treat-warning-as-errors

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Withdrawn: 8263028: Windows build fails due to several treat-warning-as-errors

Yi Yang
On Sun, 21 Mar 2021 04:22:42 GMT, Yi Yang <[hidden email]> wrote:

> cl.exe(19.28.29334) can not build JDK on windows_x64 because it treats many warnings as errors thus prohibiting further compilation. (See detailed failure logs on JBS)
>
> 1. methodMatcher.cpp
>
> cl.exe can not handle advanced usage of sscanf(i.e. regex-like sscanf) correctly. This looks like an msvc compiler bug, it has been there for a long while, so I temporarily disable these warnings in a limited region. Outside of this region, the compiler still treats them as errors. This change does not affect the functionality of MethodMatcher::parse_method_pattern, it can parse class name and method name in a desired manner.
>
> 2. vm_version_x86.cpp
>
> Some comments contain characters(Register Trademark) that cannot be represented in the current code page (936). Replacing them with ASCII-characters makes the compiler happy.
>
> Best Regards,
> Yang

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3107