[XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Baesken, Matthias
Hello, could you please review this small change :

http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/

it fixes a number of places in   jdk.jdwp.agent   where in case of an error it is attempted to write to NULL .

Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent


https://bugs.openjdk.java.net/browse/JDK-8180413


Best regards, Matthias

Reply | Threaded
Open this post in threaded view
|

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Langer, Christoph
Hi Matthias,

this definitely makes sense. If 'data' is NULL, one should not access its fields, except a hard crash is desired... Reviewed. Don't forget to update the copyright year.

Best regards
Christoph

From: Baesken, Matthias
Sent: Dienstag, 16. Mai 2017 11:05
To: [hidden email]
Cc: Simonis, Volker <[hidden email]>; Langer, Christoph <[hidden email]>
Subject: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Hello, could you please review this small change :

http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/

it fixes a number of places in   jdk.jdwp.agent   where in case of an error it is attempted to write to NULL .

Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent


https://bugs.openjdk.java.net/browse/JDK-8180413


Best regards, Matthias

Reply | Threaded
Open this post in threaded view
|

Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Alan Bateman
In reply to this post by Baesken, Matthias


On 16/05/2017 10:04, Baesken, Matthias wrote:

> Hello, could you please review this small change :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
>
> it fixes a number of places in   jdk.jdwp.agent   where in case of an error it is attempted to write to NULL .
>
> Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>
>
> https://bugs.openjdk.java.net/browse/JDK-8180413
>
>
Can you bring this to serviceability-dev as that is the mailing list
where the JDWP agent is maintained?

-Alan
Reply | Threaded
Open this post in threaded view
|

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Baesken, Matthias
 Sure, I forward it to  serviceability-dev .

-----Original Message-----
From: Alan Bateman [mailto:[hidden email]]
Sent: Dienstag, 16. Mai 2017 11:51
To: Baesken, Matthias <[hidden email]>; [hidden email]
Cc: Simonis, Volker <[hidden email]>
Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent



On 16/05/2017 10:04, Baesken, Matthias wrote:

> Hello, could you please review this small change :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
>
> it fixes a number of places in   jdk.jdwp.agent   where in case of an error it is attempted to write to NULL .
>
> Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>
>
> https://bugs.openjdk.java.net/browse/JDK-8180413
>
>
Can you bring this to serviceability-dev as that is the mailing list
where the JDWP agent is maintained?

-Alan
Reply | Threaded
Open this post in threaded view
|

Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Dmitry Samersoff
Matthias,

Looks good to me.

-Dmitry

On 2017-05-16 13:21, Baesken, Matthias wrote:

>  Sure, I forward it to  serviceability-dev .
>
> -----Original Message-----
> From: Alan Bateman [mailto:[hidden email]]
> Sent: Dienstag, 16. Mai 2017 11:51
> To: Baesken, Matthias <[hidden email]>; [hidden email]
> Cc: Simonis, Volker <[hidden email]>
> Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>
>
>
> On 16/05/2017 10:04, Baesken, Matthias wrote:
>> Hello, could you please review this small change :
>>
>> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
>>
>> it fixes a number of places in   jdk.jdwp.agent   where in case of an error it is attempted to write to NULL .
>>
>> Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>>
>>
>> https://bugs.openjdk.java.net/browse/JDK-8180413
>>
>>
> Can you bring this to serviceability-dev as that is the mailing list
> where the JDWP agent is maintained?
>
> -Alan
>


--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
Reply | Threaded
Open this post in threaded view
|

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Langer, Christoph
Hi Matthias,

I have added a jdk9-fix-request label to the bug and added a comment. Let's see if it gets approved for JDK9.

Best regards
Christoph

> -----Original Message-----
> From: core-libs-dev [mailto:[hidden email]] On
> Behalf Of Dmitry Samersoff
> Sent: Dienstag, 16. Mai 2017 13:18
> To: Baesken, Matthias <[hidden email]>; Alan Bateman
> <[hidden email]>; [hidden email]
> Cc: Simonis, Volker <[hidden email]>
> Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>
> Matthias,
>
> Looks good to me.
>
> -Dmitry
>
> On 2017-05-16 13:21, Baesken, Matthias wrote:
> >  Sure, I forward it to  serviceability-dev .
> >
> > -----Original Message-----
> > From: Alan Bateman [mailto:[hidden email]]
> > Sent: Dienstag, 16. Mai 2017 11:51
> > To: Baesken, Matthias <[hidden email]>; core-libs-
> [hidden email]
> > Cc: Simonis, Volker <[hidden email]>
> > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> >
> >
> >
> > On 16/05/2017 10:04, Baesken, Matthias wrote:
> >> Hello, could you please review this small change :
> >>
> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
> >>
> >> it fixes a number of places in   jdk.jdwp.agent   where in case of an error it
> is attempted to write to NULL .
> >>
> >> Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> >>
> >>
> >> https://bugs.openjdk.java.net/browse/JDK-8180413
> >>
> >>
> > Can you bring this to serviceability-dev as that is the mailing list
> > where the JDWP agent is maintained?
> >
> > -Alan
> >
>
>
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
Reply | Threaded
Open this post in threaded view
|

RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Baesken, Matthias
Great, thanks !

-----Original Message-----
From: Langer, Christoph
Sent: Donnerstag, 18. Mai 2017 15:27
To: Baesken, Matthias <[hidden email]>
Cc: Simonis, Volker <[hidden email]>; Dmitry Samersoff <[hidden email]>; [hidden email]; [hidden email]
Subject: RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent

Hi Matthias,

I have added a jdk9-fix-request label to the bug and added a comment. Let's see if it gets approved for JDK9.

Best regards
Christoph

> -----Original Message-----
> From: core-libs-dev [mailto:[hidden email]] On
> Behalf Of Dmitry Samersoff
> Sent: Dienstag, 16. Mai 2017 13:18
> To: Baesken, Matthias <[hidden email]>; Alan Bateman
> <[hidden email]>; [hidden email]
> Cc: Simonis, Volker <[hidden email]>
> Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
>
> Matthias,
>
> Looks good to me.
>
> -Dmitry
>
> On 2017-05-16 13:21, Baesken, Matthias wrote:
> >  Sure, I forward it to  serviceability-dev .
> >
> > -----Original Message-----
> > From: Alan Bateman [mailto:[hidden email]]
> > Sent: Dienstag, 16. Mai 2017 11:51
> > To: Baesken, Matthias <[hidden email]>; core-libs-
> [hidden email]
> > Cc: Simonis, Volker <[hidden email]>
> > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> >
> >
> >
> > On 16/05/2017 10:04, Baesken, Matthias wrote:
> >> Hello, could you please review this small change :
> >>
> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
> >>
> >> it fixes a number of places in   jdk.jdwp.agent   where in case of an error it
> is attempted to write to NULL .
> >>
> >> Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> >>
> >>
> >> https://bugs.openjdk.java.net/browse/JDK-8180413
> >>
> >>
> > Can you bring this to serviceability-dev as that is the mailing list
> > where the JDWP agent is maintained?
> >
> > -Alan
> >
>
>
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.