(XS) RFR: 8192950: Missing -nativepath for svc tests

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

(XS) RFR: 8192950: Missing -nativepath for svc tests

David Holmes
Bug is closed but problem is simply that in jprt.properties we only
utilise the test-image and set the -nativepath for a specific
configuration of tests. Using "-testset svc" we can hit failures because
it is not one of those configurations. This fix simply adds it:

webrev: http://cr.openjdk.java.net/~dholmes/8192950/webrev/

--- old/make/jprt.properties 2017-12-05 01:02:40.606195148 -0500
+++ new/make/jprt.properties 2017-12-05 01:02:38.494074834 -0500
@@ -177,6 +177,7 @@

  # Not all test targets need the test image
  jprt.test.bundle.targets=\
+  ${my.make.rule.test.targets.svc}, \
    ${my.make.rule.test.targets.hotspot.reg}, \
    ${my.make.rule.test.targets.hotspot.gtest} \
    ${my.make.rule.test.targets.nativesanity} \

Thanks,
David
Reply | Threaded
Open this post in threaded view
|

Re: (XS) RFR: 8192950: Missing -nativepath for svc tests

Magnus Ihse Bursie
On 2017-12-05 07:06, David Holmes wrote:

> Bug is closed but problem is simply that in jprt.properties we only
> utilise the test-image and set the -nativepath for a specific
> configuration of tests. Using "-testset svc" we can hit failures
> because it is not one of those configurations. This fix simply adds it:
>
> webrev: http://cr.openjdk.java.net/~dholmes/8192950/webrev/
>
> --- old/make/jprt.properties    2017-12-05 01:02:40.606195148 -0500
> +++ new/make/jprt.properties    2017-12-05 01:02:38.494074834 -0500
> @@ -177,6 +177,7 @@
>
>  # Not all test targets need the test image
>  jprt.test.bundle.targets=\
> +  ${my.make.rule.test.targets.svc}, \
>    ${my.make.rule.test.targets.hotspot.reg}, \
>    ${my.make.rule.test.targets.hotspot.gtest} \
>    ${my.make.rule.test.targets.nativesanity} \

Looks good to me.

/Magnus
>
> Thanks,
> David

Reply | Threaded
Open this post in threaded view
|

Re: (XS) RFR: 8192950: Missing -nativepath for svc tests

David Holmes
Thanks Magnus!

David

On 5/12/2017 5:41 PM, Magnus Ihse Bursie wrote:

> On 2017-12-05 07:06, David Holmes wrote:
>> Bug is closed but problem is simply that in jprt.properties we only
>> utilise the test-image and set the -nativepath for a specific
>> configuration of tests. Using "-testset svc" we can hit failures
>> because it is not one of those configurations. This fix simply adds it:
>>
>> webrev: http://cr.openjdk.java.net/~dholmes/8192950/webrev/
>>
>> --- old/make/jprt.properties    2017-12-05 01:02:40.606195148 -0500
>> +++ new/make/jprt.properties    2017-12-05 01:02:38.494074834 -0500
>> @@ -177,6 +177,7 @@
>>
>>  # Not all test targets need the test image
>>  jprt.test.bundle.targets=\
>> +  ${my.make.rule.test.targets.svc}, \
>>    ${my.make.rule.test.targets.hotspot.reg}, \
>>    ${my.make.rule.test.targets.hotspot.gtest} \
>>    ${my.make.rule.test.targets.nativesanity} \
>
> Looks good to me.
>
> /Magnus
>>
>> Thanks,
>> David
>