[jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10

Leo Jiang
This is the changes for JDK 16 msg drop 10.

-------------

Commit messages:
 - JDK-8259732: JDK 16 L10n resource file update - msg drop 10

Changes: https://git.openjdk.java.net/jdk16/pull/123/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=123&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259732
  Stats: 215 lines in 30 files changed: 118 ins; 16 del; 81 mod
  Patch: https://git.openjdk.java.net/jdk16/pull/123.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/123/head:pull/123

PR: https://git.openjdk.java.net/jdk16/pull/123
Reply | Threaded
Open this post in threaded view
|

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10

Leo Jiang
On Thu, 14 Jan 2021 14:00:00 GMT, Leo Jiang <[hidden email]> wrote:

> This is the changes for JDK 16 msg drop 10.

[webrev.tar.gz](https://github.com/openjdk/jdk16/files/5814846/webrev.tar.gz)

Since they're Unicode escape sequences in the l10n resource files, so I attached a human readable webrev, created by `git webrev` and converted. Pls find this to help your review.

-------------

PR: https://git.openjdk.java.net/jdk16/pull/123
Reply | Threaded
Open this post in threaded view
|

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]

Leo Jiang
In reply to this post by Leo Jiang
> This is the changes for JDK 16 msg drop 10.

Leo Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into msgdrop
 - JDK-8259732: JDK 16 L10n resource file update - msg drop 10

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk16/pull/123/files
  - new: https://git.openjdk.java.net/jdk16/pull/123/files/230117b4..d72f444a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk16&pr=123&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk16&pr=123&range=00-01

  Stats: 718 lines in 32 files changed: 616 ins; 38 del; 64 mod
  Patch: https://git.openjdk.java.net/jdk16/pull/123.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/123/head:pull/123

PR: https://git.openjdk.java.net/jdk16/pull/123
Reply | Threaded
Open this post in threaded view
|

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10

Leo Jiang
In reply to this post by Leo Jiang
On Thu, 14 Jan 2021 14:10:12 GMT, Leo Jiang <[hidden email]> wrote:

>> This is the changes for JDK 16 msg drop 10.
>
> [webrev.tar.gz](https://github.com/openjdk/jdk16/files/5814846/webrev.tar.gz)
>
> Since they're Unicode escape sequences in the l10n resource files, so I attached a human readable webrev, created by `git webrev` and converted. Pls find this to help your review.

@naotoj Would you have time to take a look at this change? Very appreciated!

-------------

PR: https://git.openjdk.java.net/jdk16/pull/123
Reply | Threaded
Open this post in threaded view
|

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]

Naoto Sato-2
In reply to this post by Leo Jiang
On Thu, 14 Jan 2021 14:27:25 GMT, Leo Jiang <[hidden email]> wrote:

>> This is the changes for JDK 16 msg drop 10.
>
> Leo Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
>  - Merge branch 'master' into msgdrop
>  - JDK-8259732: JDK 16 L10n resource file update - msg drop 10

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 518:

> 516: doclet.footer_specified=\
> 517:     The -footer option is no longer supported and will be ignored.\n\
> 518:     It may be removed in a future release.

I believe this is to fix no newline at the end (unrelated to l10n changes). Do we need to change the copyright year for this?

-------------

PR: https://git.openjdk.java.net/jdk16/pull/123
Reply | Threaded
Open this post in threaded view
|

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]

Leo Jiang
On Sat, 16 Jan 2021 00:48:43 GMT, Naoto Sato <[hidden email]> wrote:

>> Actually I was correcting the L217, changed {) -> {}. But 2 days ago, Jonathan Gibbons fixed it in another commit 6bb6093. I found his fix after running the merge. Looks both of us forgot to update the copyright year. Any suggestion?
>> doclet.help.systemProperties.body=\
>>     The {0} page lists references to system properties.
>
> I believe your PR still contains the fix to add the newline at the end of the file (at L518). So I think you can simply change the copyright year in `standard.properties` file.

Thx! Fixed the copyright year for this file.

-------------

PR: https://git.openjdk.java.net/jdk16/pull/123
Reply | Threaded
Open this post in threaded view
|

[jdk16] Integrated: JDK-8259732: JDK 16 L10n resource file update - msg drop 10

Leo Jiang
In reply to this post by Leo Jiang
On Thu, 14 Jan 2021 14:00:00 GMT, Leo Jiang <[hidden email]> wrote:

> This is the changes for JDK 16 msg drop 10.

This pull request has now been integrated.

Changeset: 01205109
Author:    Leo Jiang <[hidden email]>
URL:       https://git.openjdk.java.net/jdk16/commit/01205109
Stats:     215 lines in 30 files changed: 118 ins; 16 del; 81 mod

8259732: JDK 16 L10n resource file update - msg drop 10

Reviewed-by: naoto

-------------

PR: https://git.openjdk.java.net/jdk16/pull/123