[jdk8u-dev] RFR 8187629: NMT: Memory miscounting in compiler (C2)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jdk8u-dev] RFR 8187629: NMT: Memory miscounting in compiler (C2)

Zhengyu Gu-2
Please review this 8u backport. The only conflict is copyright year in
resourceArea.hpp, after fixing file paths.


Bug: https://bugs.openjdk.java.net/browse/JDK-8187629

Original changeset: http://hg.openjdk.java.net/jdk10/master/rev/5390057a4489

Webrev: http://cr.openjdk.java.net/~zgu/8187629/webrev.8u/

Thanks,

-Zhengyu
Reply | Threaded
Open this post in threaded view
|

Re: [jdk8u-dev] RFR 8187629: NMT: Memory miscounting in compiler (C2)

Andrew Dinn
On 27/11/17 21:18, Zhengyu Gu wrote:

> Please review this 8u backport. The only conflict is copyright year in
> resourceArea.hpp, after fixing file paths.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187629
>
> Original changeset:
> http://hg.openjdk.java.net/jdk10/master/rev/5390057a4489
>
> Webrev: http://cr.openjdk.java.net/~zgu/8187629/webrev.8u/
Yes, looks good.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
Reply | Threaded
Open this post in threaded view
|

Re: [jdk8u-dev] RFR 8187629: NMT: Memory miscounting in compiler (C2)

Thomas Stüfe-2
In reply to this post by Zhengyu Gu-2
On Mon, Nov 27, 2017 at 10:18 PM, Zhengyu Gu <[hidden email]> wrote:

> Please review this 8u backport. The only conflict is copyright year in
> resourceArea.hpp, after fixing file paths.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187629
>
> Original changeset: http://hg.openjdk.java.net/jdk
> 10/master/rev/5390057a4489
>
> Webrev: http://cr.openjdk.java.net/~zgu/8187629/webrev.8u/
>
> Thanks,
>
> -Zhengyu
>

+1

Regards, Thomas
Reply | Threaded
Open this post in threaded view
|

Re: [jdk8u-dev] RFR 8187629: NMT: Memory miscounting in compiler (C2)

Zhengyu Gu-2
Thanks for the review, Thomas.

-Zhengyu

On 11/28/2017 05:16 AM, Thomas Stüfe wrote:

>
>
> On Mon, Nov 27, 2017 at 10:18 PM, Zhengyu Gu <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Please review this 8u backport. The only conflict is copyright year
>     in resourceArea.hpp, after fixing file paths.
>
>
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8187629
>     <https://bugs.openjdk.java.net/browse/JDK-8187629>
>
>     Original changeset:
>     http://hg.openjdk.java.net/jdk10/master/rev/5390057a4489
>     <http://hg.openjdk.java.net/jdk10/master/rev/5390057a4489>
>
>     Webrev: http://cr.openjdk.java.net/~zgu/8187629/webrev.8u/
>     <http://cr.openjdk.java.net/~zgu/8187629/webrev.8u/>
>
>     Thanks,
>
>     -Zhengyu
>
>
> +1
>
> Regards, Thomas
>
Reply | Threaded
Open this post in threaded view
|

Re: [jdk8u-dev] RFR 8187629: NMT: Memory miscounting in compiler (C2)

Zhengyu Gu-2
In reply to this post by Andrew Dinn
Thanks for the review, Andrew.

-Zhengyu

On 11/28/2017 04:53 AM, Andrew Dinn wrote:

> On 27/11/17 21:18, Zhengyu Gu wrote:
>> Please review this 8u backport. The only conflict is copyright year in
>> resourceArea.hpp, after fixing file paths.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8187629
>>
>> Original changeset:
>> http://hg.openjdk.java.net/jdk10/master/rev/5390057a4489
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/8187629/webrev.8u/
> Yes, looks good.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>