jmx-dev RFR (XXS): JDK-8174855 Quarantine failing test jdk/test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

jmx-dev RFR (XXS): JDK-8174855 Quarantine failing test jdk/test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java

George Triantafillou
Please review this very small fix for JDK-8174855:

JBS: https://bugs.openjdk.java.net/browse/JDK-8174855
open webrev: http://cr.openjdk.java.net/~gtriantafill/8174855/webrev/ 
<http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev/>

The test was added to ProblemList.txt.  Thanks.

-George

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: jmx-dev RFR (XXS): JDK-8174855 Quarantine failing test jdk/test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java

David Holmes
Hi George,

On 15/02/2017 5:12 AM, George Triantafillou wrote:
> Please review this very small fix for JDK-8174855:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8174855
> open webrev: http://cr.openjdk.java.net/~gtriantafill/8174855/webrev/
> <http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev/>
>
> The test was added to ProblemList.txt.  Thanks.

The bug id in the ProblemList.txt is the bug that needs to be fixed to
allow the test to be removed from the ProblemList - not the bug id used
to add it to the list.

David
-----

> -George
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: jmx-dev RFR (XXS): JDK-8174855 Quarantine failing test jdk/test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java

George Triantafillou
Hi David,

Thanks for the review.  Updated webrev:

http://cr.openjdk.java.net/~gtriantafill/8174855/webrev.01/ 
<http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev.01/>

-George

On 2/14/2017 5:29 PM, David Holmes wrote:

> Hi George,
>
> On 15/02/2017 5:12 AM, George Triantafillou wrote:
>> Please review this very small fix for JDK-8174855:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8174855
>> open webrev: http://cr.openjdk.java.net/~gtriantafill/8174855/webrev/
>> <http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev/>
>>
>> The test was added to ProblemList.txt.  Thanks.
>
> The bug id in the ProblemList.txt is the bug that needs to be fixed to
> allow the test to be removed from the ProblemList - not the bug id
> used to add it to the list.
>
> David
> -----
>
>> -George
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: jmx-dev RFR (XXS): JDK-8174855 Quarantine failing test jdk/test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java

David Holmes
On 15/02/2017 11:40 AM, George Triantafillou wrote:
> Hi David,
>
> Thanks for the review.  Updated webrev:
>
> http://cr.openjdk.java.net/~gtriantafill/8174855/webrev.01/
> <http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev.01/>

Looks good! :)

Thanks,
David

> -George
>
> On 2/14/2017 5:29 PM, David Holmes wrote:
>> Hi George,
>>
>> On 15/02/2017 5:12 AM, George Triantafillou wrote:
>>> Please review this very small fix for JDK-8174855:
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8174855
>>> open webrev: http://cr.openjdk.java.net/~gtriantafill/8174855/webrev/
>>> <http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev/>
>>>
>>> The test was added to ProblemList.txt.  Thanks.
>>
>> The bug id in the ProblemList.txt is the bug that needs to be fixed to
>> allow the test to be removed from the ProblemList - not the bug id
>> used to add it to the list.
>>
>> David
>> -----
>>
>>> -George
>>>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: jmx-dev RFR (XXS): JDK-8174855 Quarantine failing test jdk/test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java

George Triantafillou
Thanks David.

-George

On 2/14/2017 9:09 PM, David Holmes wrote:

> On 15/02/2017 11:40 AM, George Triantafillou wrote:
>> Hi David,
>>
>> Thanks for the review.  Updated webrev:
>>
>> http://cr.openjdk.java.net/~gtriantafill/8174855/webrev.01/
>> <http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev.01/>
>
> Looks good! :)
>
> Thanks,
> David
>
>> -George
>>
>> On 2/14/2017 5:29 PM, David Holmes wrote:
>>> Hi George,
>>>
>>> On 15/02/2017 5:12 AM, George Triantafillou wrote:
>>>> Please review this very small fix for JDK-8174855:
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8174855
>>>> open webrev: http://cr.openjdk.java.net/~gtriantafill/8174855/webrev/
>>>> <http://cr.openjdk.java.net/%7Egtriantafill/8174855/webrev/>
>>>>
>>>> The test was added to ProblemList.txt.  Thanks.
>>>
>>> The bug id in the ProblemList.txt is the bug that needs to be fixed to
>>> allow the test to be removed from the ProblemList - not the bug id
>>> used to add it to the list.
>>>
>>> David
>>> -----
>>>
>>>> -George
>>>>
>>

Loading...