jtreg support for --patch-module?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

jtreg support for --patch-module?

roger riggs
Hi,

For a test, I need to patch a class in a module.
I'm stumped on the correct series of @library, @build and @run setup to
see it automatically
pass the --patch-module options to javac and java.

Am I expecting too much and have to revert to explicitly spawning the
compile and run steps?

Thanks, Roger

Reply | Threaded
Open this post in threaded view
|

Re: jtreg support for --patch-module

roger riggs
Never mind, I found

@compile/module=xxx

An @library is not needed

Regards, Roger

[1] http://openjdk.java.net/jtreg/tag-spec.html


On 8/25/2017 3:17 PM, Roger Riggs wrote:

> Hi,
>
> For a test, I need to patch a class in a module.
> I'm stumped on the correct series of @library, @build and @run setup
> to see it automatically
> pass the --patch-module options to javac and java.
>
> Am I expecting too much and have to revert to explicitly spawning the
> compile and run steps?
>
> Thanks, Roger
>

Reply | Threaded
Open this post in threaded view
|

Re: jtreg support for --patch-module

Martin Buchholz-3
(yes, but the jtreg tag spec need updating from -Xmodule => --patch-module)

On Fri, Aug 25, 2017 at 12:40 PM, Roger Riggs <[hidden email]> wrote:
Never mind, I found

@compile/module=xxx

An @library is not needed

Regards, Roger

[1] http://openjdk.java.net/jtreg/tag-spec.html


On 8/25/2017 3:17 PM, Roger Riggs wrote:
Hi,

For a test, I need to patch a class in a module.
I'm stumped on the correct series of @library, @build and @run setup to see it automatically
pass the --patch-module options to javac and java.

Am I expecting too much and have to revert to explicitly spawning the compile and run steps?

Thanks, Roger



Reply | Threaded
Open this post in threaded view
|

Re: jtreg support for --patch-module?

Martin Buchholz-3
In reply to this post by roger riggs
Hej Roger,

I don't know what would be the canonical example, but many tests do this.  Look for such tests by finding partial java.base trees:

 ~/ws/jdk/test $ find -name java | grep java.base/java
./jdk/java/util/stream/boottest/java.base/java
./jdk/java/lang/instrument/java.base/java
./jdk/java/lang/invoke/lookup/java.base/java
./jdk/java/lang/invoke/java.base/java

...


On Fri, Aug 25, 2017 at 12:17 PM, Roger Riggs <[hidden email]> wrote:
Hi,

For a test, I need to patch a class in a module.
I'm stumped on the correct series of @library, @build and @run setup to see it automatically
pass the --patch-module options to javac and java.

Am I expecting too much and have to revert to explicitly spawning the compile and run steps?

Thanks, Roger


Reply | Threaded
Open this post in threaded view
|

Re: jtreg support for --patch-module

Jonathan Gibbons
In reply to this post by Martin Buchholz-3

Ooops, thanks. Will fix.

-- Jon


On 8/25/17 1:46 PM, Martin Buchholz wrote:
(yes, but the jtreg tag spec need updating from -Xmodule => --patch-module)

On Fri, Aug 25, 2017 at 12:40 PM, Roger Riggs <[hidden email]> wrote:
Never mind, I found

@compile/module=xxx

An @library is not needed

Regards, Roger

[1] http://openjdk.java.net/jtreg/tag-spec.html


On 8/25/2017 3:17 PM, Roger Riggs wrote:
Hi,

For a test, I need to patch a class in a module.
I'm stumped on the correct series of @library, @build and @run setup to see it automatically
pass the --patch-module options to javac and java.

Am I expecting too much and have to revert to explicitly spawning the compile and run steps?

Thanks, Roger