<AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

semyon.sadetsky
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8177758

webrev: http://cr.openjdk.java.net/~ssadetsky/8177758/webrev.00/

In 8075516 it was not taken into account that yet another global
reference to the file dialog peer is created  inside the called
AwtFileDialog::Show(), so there one more global reference that prevents
file dialog to be collected by GC. In the fix the second reference is
eliminated.

--Semyon

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

Shashidhara H V
Hi Semyon,

The changes looks fine to me.

Thanks and regards,
Shashi

-----Original Message-----
From: Semyon Sadetsky
Sent: Saturday, December 2, 2017 3:55 AM
To: [hidden email]
Subject: <AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8177758

webrev: http://cr.openjdk.java.net/~ssadetsky/8177758/webrev.00/

In 8075516 it was not taken into account that yet another global reference to the file dialog peer is created  inside the called AwtFileDialog::Show(), so there one more global reference that prevents file dialog to be collected by GC. In the fix the second reference is eliminated.

--Semyon

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

Sergey Bylokhov
Looks fine.
I assume that the use-case described in JDK-4906972 was checked.

On 07/12/2017 02:12, Shashidhara Veerabhadraiah wrote:

> Hi Semyon,
>
> The changes looks fine to me.
>
> Thanks and regards,
> Shashi
>
> -----Original Message-----
> From: Semyon Sadetsky
> Sent: Saturday, December 2, 2017 3:55 AM
> To: [hidden email]
> Subject: <AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog
>
> Hello,
>
> Please review fix for JDK10:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8177758
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8177758/webrev.00/
>
> In 8075516 it was not taken into account that yet another global reference to the file dialog peer is created  inside the called AwtFileDialog::Show(), so there one more global reference that prevents file dialog to be collected by GC. In the fix the second reference is eliminated.
>
> --Semyon
>


--
Best regards, Sergey.