<AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Sergey Bylokhov
Hello,
Please review the fix for jdk10.

Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
Webrev can be found at: http://cr.openjdk.java.net/~serb/8186617/webrev.00


The client code has a "com.sun.awt.AWTUtilities" class which at some point(jdk6u10) in the past was used as a kind of "public" API.

In jdk9 this class is inaccessible and all its functionality was already provided by the public API, so this class can be removed.

AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
    -> GraphicsDevice.isWindowTranslucencySupported()

AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
    -> Window.setOpacity/getOpacity

AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
    -> Window.setShape()/getShape()

AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
    -> setBackground()/isOpaque()

AWTUtilities.isTranslucencyCapable
    -> GraphicsConfiguration.isTranslucencyCapable()

AWTUtilities.setComponentMixingCutoutShape
    -> Component.setMixingCutoutShape()

CSR will be created after technical review.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Alexander Zvegintsev
Looks fine.

Thanks,
Alexander.

On 23/08/2017 03:09, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8186617/webrev.00
>
>
> The client code has a "com.sun.awt.AWTUtilities" class which at some point(jdk6u10) in the past was used as a kind of "public" API.
>
> In jdk9 this class is inaccessible and all its functionality was already provided by the public API, so this class can be removed.
>
> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>      -> GraphicsDevice.isWindowTranslucencySupported()
>
> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>      -> Window.setOpacity/getOpacity
>
> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>      -> Window.setShape()/getShape()
>
> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>      -> setBackground()/isOpaque()
>
> AWTUtilities.isTranslucencyCapable
>      -> GraphicsConfiguration.isTranslucencyCapable()
>
> AWTUtilities.setComponentMixingCutoutShape
>      -> Component.setMixingCutoutShape()
>
> CSR will be created after technical review.

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Sergey Bylokhov
Thank you.
The CSR was created:
https://bugs.openjdk.java.net/browse/JDK-8187253

On 9/3/17 21:50, Alexander Zvegintsev wrote:

> Looks fine.
>
> Thanks,
> Alexander.
>
> On 23/08/2017 03:09, Sergey Bylokhov wrote:
>> Hello,
>> Please review the fix for jdk10.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8186617/webrev.00
>>
>>
>> The client code has a "com.sun.awt.AWTUtilities" class which at some
>> point(jdk6u10) in the past was used as a kind of "public" API.
>>
>> In jdk9 this class is inaccessible and all its functionality was
>> already provided by the public API, so this class can be removed.
>>
>> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>>
>>      -> GraphicsDevice.isWindowTranslucencySupported()
>>
>> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>>      -> Window.setOpacity/getOpacity
>>
>> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>>      -> Window.setShape()/getShape()
>>
>> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>>      -> setBackground()/isOpaque()
>>
>> AWTUtilities.isTranslucencyCapable
>>      -> GraphicsConfiguration.isTranslucencyCapable()
>>
>> AWTUtilities.setComponentMixingCutoutShape
>>      -> Component.setMixingCutoutShape()
>>
>> CSR will be created after technical review.
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Sergey Bylokhov
FYI
During CSR review it was suggested to deprecate this API first and
remove it later in some next release.
http://cr.openjdk.java.net/~serb/8186617/webrev.01

On 05/09/2017 15:08, Sergey Bylokhov wrote:

> Thank you.
> The CSR was created:
> https://bugs.openjdk.java.net/browse/JDK-8187253
>
> On 9/3/17 21:50, Alexander Zvegintsev wrote:
>> Looks fine.
>>
>> Thanks,
>> Alexander.
>>
>> On 23/08/2017 03:09, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk10.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8186617/webrev.00
>>>
>>>
>>> The client code has a "com.sun.awt.AWTUtilities" class which at some
>>> point(jdk6u10) in the past was used as a kind of "public" API.
>>>
>>> In jdk9 this class is inaccessible and all its functionality was
>>> already provided by the public API, so this class can be removed.
>>>
>>> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>>>
>>>      -> GraphicsDevice.isWindowTranslucencySupported()
>>>
>>> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>>>      -> Window.setOpacity/getOpacity
>>>
>>> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>>>      -> Window.setShape()/getShape()
>>>
>>> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>>>      -> setBackground()/isOpaque()
>>>
>>> AWTUtilities.isTranslucencyCapable
>>>      -> GraphicsConfiguration.isTranslucencyCapable()
>>>
>>> AWTUtilities.setComponentMixingCutoutShape
>>>      -> Component.setMixingCutoutShape()
>>>
>>> CSR will be created after technical review.
>>
>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

semyon.sadetsky
Hi Sergey,

the last patch breaks the build because of:

AWTUtilities in com.sun.awt has been deprecated and marked for removal

error: warnings found and -Werror specified
1 error
2 warnings

--Semyon


On 10/26/2017 06:30 PM, Sergey Bylokhov wrote:

> FYI
> During CSR review it was suggested to deprecate this API first and
> remove it later in some next release.
> http://cr.openjdk.java.net/~serb/8186617/webrev.01
>
> On 05/09/2017 15:08, Sergey Bylokhov wrote:
>> Thank you.
>> The CSR was created:
>> https://bugs.openjdk.java.net/browse/JDK-8187253
>>
>> On 9/3/17 21:50, Alexander Zvegintsev wrote:
>>> Looks fine.
>>>
>>> Thanks,
>>> Alexander.
>>>
>>> On 23/08/2017 03:09, Sergey Bylokhov wrote:
>>>> Hello,
>>>> Please review the fix for jdk10.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
>>>> Webrev can be found at:
>>>> http://cr.openjdk.java.net/~serb/8186617/webrev.00
>>>>
>>>>
>>>> The client code has a "com.sun.awt.AWTUtilities" class which at
>>>> some point(jdk6u10) in the past was used as a kind of "public" API.
>>>>
>>>> In jdk9 this class is inaccessible and all its functionality was
>>>> already provided by the public API, so this class can be removed.
>>>>
>>>> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>>>>
>>>>      -> GraphicsDevice.isWindowTranslucencySupported()
>>>>
>>>> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>>>>      -> Window.setOpacity/getOpacity
>>>>
>>>> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>>>>      -> Window.setShape()/getShape()
>>>>
>>>> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>>>>      -> setBackground()/isOpaque()
>>>>
>>>> AWTUtilities.isTranslucencyCapable
>>>>      -> GraphicsConfiguration.isTranslucencyCapable()
>>>>
>>>> AWTUtilities.setComponentMixingCutoutShape
>>>>      -> Component.setMixingCutoutShape()
>>>>
>>>> CSR will be created after technical review.
>>>
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Sergey Bylokhov
This is not a last patch, since it was not a request for review.
v01 is a change in AWTUtilities only, which will not be removed as it
was proposed and reviewed in v00.

On 26/10/2017 22:03, Semyon Sadetsky wrote:

> Hi Sergey,
>
> the last patch breaks the build because of:
>
> AWTUtilities in com.sun.awt has been deprecated and marked for removal
>
> error: warnings found and -Werror specified
> 1 error
> 2 warnings
>
> --Semyon
>
>
> On 10/26/2017 06:30 PM, Sergey Bylokhov wrote:
>> FYI
>> During CSR review it was suggested to deprecate this API first and
>> remove it later in some next release.
>> http://cr.openjdk.java.net/~serb/8186617/webrev.01
>>
>> On 05/09/2017 15:08, Sergey Bylokhov wrote:
>>> Thank you.
>>> The CSR was created:
>>> https://bugs.openjdk.java.net/browse/JDK-8187253
>>>
>>> On 9/3/17 21:50, Alexander Zvegintsev wrote:
>>>> Looks fine.
>>>>
>>>> Thanks,
>>>> Alexander.
>>>>
>>>> On 23/08/2017 03:09, Sergey Bylokhov wrote:
>>>>> Hello,
>>>>> Please review the fix for jdk10.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
>>>>> Webrev can be found at:
>>>>> http://cr.openjdk.java.net/~serb/8186617/webrev.00
>>>>>
>>>>>
>>>>> The client code has a "com.sun.awt.AWTUtilities" class which at
>>>>> some point(jdk6u10) in the past was used as a kind of "public" API.
>>>>>
>>>>> In jdk9 this class is inaccessible and all its functionality was
>>>>> already provided by the public API, so this class can be removed.
>>>>>
>>>>> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>>>>>
>>>>>      -> GraphicsDevice.isWindowTranslucencySupported()
>>>>>
>>>>> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>>>>>      -> Window.setOpacity/getOpacity
>>>>>
>>>>> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>>>>>      -> Window.setShape()/getShape()
>>>>>
>>>>> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>>>>>      -> setBackground()/isOpaque()
>>>>>
>>>>> AWTUtilities.isTranslucencyCapable
>>>>>      -> GraphicsConfiguration.isTranslucencyCapable()
>>>>>
>>>>> AWTUtilities.setComponentMixingCutoutShape
>>>>>      -> Component.setMixingCutoutShape()
>>>>>
>>>>> CSR will be created after technical review.
>>>>
>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Philip Race
In reply to this post by Sergey Bylokhov
+1

-phil.

On 10/26/2017 06:30 PM, Sergey Bylokhov wrote:

> FYI
> During CSR review it was suggested to deprecate this API first and
> remove it later in some next release.
> http://cr.openjdk.java.net/~serb/8186617/webrev.01
>
> On 05/09/2017 15:08, Sergey Bylokhov wrote:
>> Thank you.
>> The CSR was created:
>> https://bugs.openjdk.java.net/browse/JDK-8187253
>>
>> On 9/3/17 21:50, Alexander Zvegintsev wrote:
>>> Looks fine.
>>>
>>> Thanks,
>>> Alexander.
>>>
>>> On 23/08/2017 03:09, Sergey Bylokhov wrote:
>>>> Hello,
>>>> Please review the fix for jdk10.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
>>>> Webrev can be found at:
>>>> http://cr.openjdk.java.net/~serb/8186617/webrev.00
>>>>
>>>>
>>>> The client code has a "com.sun.awt.AWTUtilities" class which at
>>>> some point(jdk6u10) in the past was used as a kind of "public" API.
>>>>
>>>> In jdk9 this class is inaccessible and all its functionality was
>>>> already provided by the public API, so this class can be removed.
>>>>
>>>> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>>>>
>>>>      -> GraphicsDevice.isWindowTranslucencySupported()
>>>>
>>>> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>>>>      -> Window.setOpacity/getOpacity
>>>>
>>>> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>>>>      -> Window.setShape()/getShape()
>>>>
>>>> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>>>>      -> setBackground()/isOpaque()
>>>>
>>>> AWTUtilities.isTranslucencyCapable
>>>>      -> GraphicsConfiguration.isTranslucencyCapable()
>>>>
>>>> AWTUtilities.setComponentMixingCutoutShape
>>>>      -> Component.setMixingCutoutShape()
>>>>
>>>> CSR will be created after technical review.
>>>
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

semyon.sadetsky
In reply to this post by Sergey Bylokhov
On 10/26/2017 10:51 PM, Sergey Bylokhov wrote:
> This is not a last patch, since it was not a request for review.
> v01 is a change in AWTUtilities only, which will not be removed as it
> was proposed and reviewed in v00.
Then please provide the final webrev.

> On 26/10/2017 22:03, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> the last patch breaks the build because of:
>>
>> AWTUtilities in com.sun.awt has been deprecated and marked for removal
>>
>> error: warnings found and -Werror specified
>> 1 error
>> 2 warnings
>>
>> --Semyon
>>
>>
>> On 10/26/2017 06:30 PM, Sergey Bylokhov wrote:
>>> FYI
>>> During CSR review it was suggested to deprecate this API first and
>>> remove it later in some next release.
>>> http://cr.openjdk.java.net/~serb/8186617/webrev.01
>>>
>>> On 05/09/2017 15:08, Sergey Bylokhov wrote:
>>>> Thank you.
>>>> The CSR was created:
>>>> https://bugs.openjdk.java.net/browse/JDK-8187253
>>>>
>>>> On 9/3/17 21:50, Alexander Zvegintsev wrote:
>>>>> Looks fine.
>>>>>
>>>>> Thanks,
>>>>> Alexander.
>>>>>
>>>>> On 23/08/2017 03:09, Sergey Bylokhov wrote:
>>>>>> Hello,
>>>>>> Please review the fix for jdk10.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186617
>>>>>> Webrev can be found at:
>>>>>> http://cr.openjdk.java.net/~serb/8186617/webrev.00
>>>>>>
>>>>>>
>>>>>> The client code has a "com.sun.awt.AWTUtilities" class which at
>>>>>> some point(jdk6u10) in the past was used as a kind of "public" API.
>>>>>>
>>>>>> In jdk9 this class is inaccessible and all its functionality was
>>>>>> already provided by the public API, so this class can be removed.
>>>>>>
>>>>>> AWTUtilities.isTranslucencySupported()/AWTUtilities.isWindowShapingSupported()
>>>>>>
>>>>>>      -> GraphicsDevice.isWindowTranslucencySupported()
>>>>>>
>>>>>> AWTUtilities.setWindowOpacity()/AWTUtilities.getWindowOpacity()
>>>>>>      -> Window.setOpacity/getOpacity
>>>>>>
>>>>>> AWTUtilities.getWindowShape()/AWTUtilities.setWindowShape()
>>>>>>      -> Window.setShape()/getShape()
>>>>>>
>>>>>> AWTUtilities.setWindowOpaque/AWTUtilities.isWindowOpaque
>>>>>>      -> setBackground()/isOpaque()
>>>>>>
>>>>>> AWTUtilities.isTranslucencyCapable
>>>>>>      -> GraphicsConfiguration.isTranslucencyCapable()
>>>>>>
>>>>>> AWTUtilities.setComponentMixingCutoutShape
>>>>>>      -> Component.setMixingCutoutShape()
>>>>>>
>>>>>> CSR will be created after technical review.
>>>>>
>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

Sergey Bylokhov
On 30/10/2017 08:17, Semyon Sadetsky wrote:
> On 10/26/2017 10:51 PM, Sergey Bylokhov wrote:
>> This is not a last patch, since it was not a request for review.
>> v01 is a change in AWTUtilities only, which will not be removed as it
>> was proposed and reviewed in v00.
> Then please provide the final webrev.

It is here:
http://cr.openjdk.java.net/~serb/8186617/CSR/


--
Best regards, Sergey.