<AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

semyon.sadetsky
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

prasanta sadhukhan

Hi Semyon,

In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret.

However  in windows 7, even without your fix, I find the sogou input appearing below text component caret.

Regards
Prasanta
On 10/2/2017 8:48 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin


Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

semyon.sadetsky

Hi Prasanta,

Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.01/

On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret.

However  in windows 7, even without your fix, I find the sogou input appearing below text component caret.
Yes, but 9 has infinite recursion when IME composition window appears.

--Semyon

Regards
Prasanta
On 10/2/2017 8:48 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin



Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

prasanta sadhukhan

Hi Semyon,

It now works for windows10 but regress in windows 7 for me, where no Sogou input window appears below text component.

Regards
Prasanta
On 10/26/2017 4:52 AM, Semyon Sadetsky wrote:

Hi Prasanta,

Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.01/

On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret.

However  in windows 7, even without your fix, I find the sogou input appearing below text component caret.
Yes, but 9 has infinite recursion when IME composition window appears.

--Semyon

Regards
Prasanta
On 10/2/2017 8:48 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin




Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

prasanta sadhukhan

Hi All,

A related issue, as per https://docs.oracle.com/javase/8/docs/technotes/guides/imf/spec.html#InputStyles

we support 3 styles, On-the-spot, Below-the-spot and Root-window.
The framework chooses between on-the-spot and below-the-spot input for active clients based on a system property or an AWT property "java.awt.im.style". The system property can be defined from the command line (by the end user), the AWT property in a localized awt.properties file (by the localizer or a system administrator). If both are defined, the system property takes precedence.

But specifying -Djava.awt.im.style=root-window, does not create a separate composition window for say, Japanese. Similarly, specifying -Djava.awt.im.style=On-the-spot for Chinese still creates separate sogou composition window. Is that a bug or is this command line has a different meaning?

Regards
Prasanta
On 10/26/2017 11:10 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

It now works for windows10 but regress in windows 7 for me, where no Sogou input window appears below text component.

Regards
Prasanta
On 10/26/2017 4:52 AM, Semyon Sadetsky wrote:

Hi Prasanta,

Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.01/

On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret.
<img moz-do-not-send="true" src="imap://prasanta%2Esadhukhan%40oracle%2Ecom@stbeehive.oracle.com:993/fetch%3EUID%3E/Trash%3E35056?header=quotebody/;section=2.2?part=1.2.2&amp;filename=sogou.png" alt="" class="" height="540" width="1302">
However  in windows 7, even without your fix, I find the sogou input appearing below text component caret.
Yes, but 9 has infinite recursion when IME composition window appears.

--Semyon

Regards
Prasanta
On 10/2/2017 8:48 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin





Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

semyon.sadetsky

Hi Prasanta,

This guide is about java IME not the native one. It is impossible to change native IME style from java especially a 3rd-party IME which Sogou IME is.

The updated fix: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.02/

--Semyon

On 10/26/2017 12:52 AM, Prasanta Sadhukhan wrote:

Hi All,

A related issue, as per https://docs.oracle.com/javase/8/docs/technotes/guides/imf/spec.html#InputStyles

we support 3 styles, On-the-spot, Below-the-spot and Root-window.
The framework chooses between on-the-spot and below-the-spot input for active clients based on a system property or an AWT property "java.awt.im.style". The system property can be defined from the command line (by the end user), the AWT property in a localized awt.properties file (by the localizer or a system administrator). If both are defined, the system property takes precedence.

But specifying -Djava.awt.im.style=root-window, does not create a separate composition window for say, Japanese. Similarly, specifying -Djava.awt.im.style=On-the-spot for Chinese still creates separate sogou composition window. Is that a bug or is this command line has a different meaning?

Regards
Prasanta
On 10/26/2017 11:10 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

It now works for windows10 but regress in windows 7 for me, where no Sogou input window appears below text component.

Regards
Prasanta
On 10/26/2017 4:52 AM, Semyon Sadetsky wrote:

Hi Prasanta,

Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.01/

On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret.
<img moz-do-not-send="true" src="imap://prasanta%2Esadhukhan%40oracle%2Ecom@stbeehive.oracle.com:993/fetch%3EUID%3E/Trash%3E35056?header=quotebody/;section=2.2?part=1.2.2&amp;filename=sogou.png" alt="" class="" width="1302" height="540">
However  in windows 7, even without your fix, I find the sogou input appearing below text component caret.
Yes, but 9 has infinite recursion when IME composition window appears.

--Semyon

Regards
Prasanta
On 10/2/2017 8:48 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin






Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

prasanta sadhukhan

Hi Semyon,

looks good to me.

Regards
Prasanta
On 10/26/2017 10:42 PM, Semyon Sadetsky wrote:

Hi Prasanta,

This guide is about java IME not the native one. It is impossible to change native IME style from java especially a 3rd-party IME which Sogou IME is.

The updated fix: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.02/

--Semyon

On 10/26/2017 12:52 AM, Prasanta Sadhukhan wrote:

Hi All,

A related issue, as per https://docs.oracle.com/javase/8/docs/technotes/guides/imf/spec.html#InputStyles

we support 3 styles, On-the-spot, Below-the-spot and Root-window.
The framework chooses between on-the-spot and below-the-spot input for active clients based on a system property or an AWT property "java.awt.im.style". The system property can be defined from the command line (by the end user), the AWT property in a localized awt.properties file (by the localizer or a system administrator). If both are defined, the system property takes precedence.

But specifying -Djava.awt.im.style=root-window, does not create a separate composition window for say, Japanese. Similarly, specifying -Djava.awt.im.style=On-the-spot for Chinese still creates separate sogou composition window. Is that a bug or is this command line has a different meaning?

Regards
Prasanta
On 10/26/2017 11:10 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

It now works for windows10 but regress in windows 7 for me, where no Sogou input window appears below text component.

Regards
Prasanta
On 10/26/2017 4:52 AM, Semyon Sadetsky wrote:

Hi Prasanta,

Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.01/

On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote:

Hi Semyon,

In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret.
<img moz-do-not-send="true" src="imap://prasanta%2Esadhukhan%40oracle%2Ecom@stbeehive.oracle.com:993/fetch%3EUID%3E/Trash%3E35056?header=quotebody/;section=2.2?part=1.2.2&amp;filename=sogou.png" alt="" class="" height="540" width="1302">
However  in windows 7, even without your fix, I find the sogou input appearing below text component caret.
Yes, but 9 has infinite recursion when IME composition window appears.

--Semyon

Regards
Prasanta
On 10/2/2017 8:48 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8183504
webrev: http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.00

Sogou Pinyin is an 3rd party app [1],  but it looks like that it is the most popular input method in China [2].
Sogou Pinyin acts in different way than the standard Microsoft IME. The events sent to the application are different and there is a lot of extra functionality in this IME. In the fix I tried to make java windows IME bridge compatible with both Sogou Pinyin IME and Microfoft IME. The fix covers standard IME usage scenarios. Unfortunately, since Sogou Pinyin has extended functionality preventing its candidates window to follow the location set in CANDIDATEFORM and the source code is not open there are still may be scenarios when the candidates window location is not aligned to java text input position.

--Semyon

[1] http://pinyin.sogou.com/ (Chinese site)
[2] https://en.wikipedia.org/wiki/Sogou_Pinyin