<AWT Dev> [10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

semyon.sadetsky
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8189204

webrev: http://cr.openjdk.java.net/~ssadetsky/8189204/webrev.00/

The fix eliminates possibility of NPEs in Component
::getLocationOnScreen().  Method Component
::getLocationOnScreen_NoTreeLock() does not consistently scan the
component hierarchy because Component::getParent() may be overridden.
Also there are may be issues caused by peer field concurrent updates.

--Semyon



Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

Sergey Bylokhov
Looks fine.

On 25/10/2017 17:37, Semyon Sadetsky wrote:

> Hello,
>
> Please review fix for JDK10:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8189204
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8189204/webrev.00/
>
> The fix eliminates possibility of NPEs in Component
> ::getLocationOnScreen().  Method Component
> ::getLocationOnScreen_NoTreeLock() does not consistently scan the
> component hierarchy because Component::getParent() may be overridden.
> Also there are may be issues caused by peer field concurrent updates.
>
> --Semyon
>
>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

Philip Race
+1

-phil

On 10/25/2017 05:52 PM, Sergey Bylokhov wrote:

> Looks fine.
>
> On 25/10/2017 17:37, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK10:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8189204
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8189204/webrev.00/
>>
>> The fix eliminates possibility of NPEs in Component
>> ::getLocationOnScreen().  Method Component
>> ::getLocationOnScreen_NoTreeLock() does not consistently scan the
>> component hierarchy because Component::getParent() may be overridden.
>> Also there are may be issues caused by peer field concurrent updates.
>>
>> --Semyon
>>
>>
>>
>
>