<AWT Dev> [12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

Krishna Addepalli

Hi All,

 

Please review a fix for JDK-8197811: https://bugs.openjdk.java.net/browse/JDK-8197811

Webrev: http://cr.openjdk.java.net/~kaddepalli/8197811/webrev00/

 

The problem is that, the mouse click happens in the item display area (and not on the arrow button in the right side of the choice). Because of this, the choice comes up and closes immediately, and hence the next mouse move doesnot result in another item being selected, because of which the test fails.

Fix is to click on the arrow button, so that the choice popup stays on, and the subsequent mouse move selects a different item.

 

Along with the fix, I have removed the applet based code, and also the test now passes on Mac (which was earlier excluded).

 

Thanks,

Krishna

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

Sergey Bylokhov
Hi, Krishna.

This test was integrated 14 years ago, and this bug was filed 1 year ago. Can you please confirm that this is not regression and the test did not work all this time?

On 24/10/2018 21:04, Krishna Addepalli wrote:

> Hi All,
>
> Please review a fix for JDK-8197811: https://bugs.openjdk.java.net/browse/JDK-8197811
>
> Webrev: http://cr.openjdk.java.net/~kaddepalli/8197811/webrev00/
>
> The problem is that, the mouse click happens in the item display area (and not on the arrow button in the right side of the choice). Because of this, the choice comes up and closes immediately, and hence the next mouse move doesnot result in another item being selected, because of which the test fails.
>
> Fix is to click on the arrow button, so that the choice popup stays on, and the subsequent mouse move selects a different item.
>
> Along with the fix, I have removed the applet based code, and also the test now passes on Mac (which was earlier excluded).
>
> Thanks,
>
> Krishna
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

Krishna Addepalli

Hi Sergey,

 

I checked the test and it passed in 6, whereas in 8u191, the behavior is as observed in the current jdk. I think the behavior change happened somewhere in that timeframe, to have the selected item appear in the popup. In jdk6, it was showing some list of items which was not containing the currently selected item, which is why the test was passing.

 

Thanks,

Krishna



On 25-Oct-2018, at 9:57 AM, Sergey Bylokhov <[hidden email]> wrote:

 

Hi, Krishna.

This test was integrated 14 years ago, and this bug was filed 1 year ago. Can you please confirm that this is not regression and the test did not work all this time?

On 24/10/2018 21:04, Krishna Addepalli wrote:

Hi All,
Please review a fix for JDK-8197811: https://bugs.openjdk.java.net/browse/JDK-8197811
Webrev: http://cr.openjdk.java.net/~kaddepalli/8197811/webrev00/
The problem is that, the mouse click happens in the item display area (and not on the arrow button in the right side of the choice). Because of this, the choice comes up and closes immediately, and hence the next mouse move doesnot result in another item being selected, because of which the test fails.
Fix is to click on the arrow button, so that the choice popup stays on, and the subsequent mouse move selects a different item.
Along with the fix, I have removed the applet based code, and also the test now passes on Mac (which was earlier excluded).
Thanks,
Krishna



--
Best regards, Sergey.