<AWT Dev> [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

Sergey Bylokhov
Hello.
Please review the fix for jdk 12.

Bug: https://bugs.openjdk.java.net/browse/JDK-8211992
Webrev: http://cr.openjdk.java.net/~serb/8211992/webrev.00

This change updates the fix for JDK-8210705[1] and adds one more JNIEXPORT which is requires for splashscreen logic.

[1] http://hg.openjdk.java.net/jdk/jdk/rev/8bbb5cbac92c

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

Phil Race
Everything in here - except the subject line - points to a completely
unrelated bug + fix.

I believe you meant :
https://bugs.openjdk.java.net/browse/JDK-8212213
http://cr.openjdk.java.net/~serb/8212213/webrev.00/

-phil.

On 10/17/2018 01:52 PM, Sergey Bylokhov wrote:

> Hello.
> Please review the fix for jdk 12.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211992
> Webrev: http://cr.openjdk.java.net/~serb/8211992/webrev.00
>
> This change updates the fix for JDK-8210705[1] and adds one more
> JNIEXPORT which is requires for splashscreen logic.
>
> [1] http://hg.openjdk.java.net/jdk/jdk/rev/8bbb5cbac92c
>

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

Sergey Bylokhov
On 17/10/2018 13:59, Phil Race wrote:
> Everything in here - except the subject line - points to a completely unrelated bug + fix.
>
> I believe you meant :
> https://bugs.openjdk.java.net/browse/JDK-8212213
> http://cr.openjdk.java.net/~serb/8212213/webrev.00/

O_o....

Right, Thank you for correction!



--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

Phil Race
And +1 from me too.

-phil.

On 10/18/2018 01:30 PM, Magnus Ihse Bursie wrote:

>> 18 okt. 2018 kl. 01:02 skrev Sergey Bylokhov <[hidden email]>:
>>
>>> On 17/10/2018 13:59, Phil Race wrote:
>>> Everything in here - except the subject line - points to a completely unrelated bug + fix.
>>> I believe you meant :
>>> https://bugs.openjdk.java.net/browse/JDK-8212213
>>> http://cr.openjdk.java.net/~serb/8212213/webrev.00/
> LGTM.
>
> /Magnus
>
>> O_o....
>>
>> Right, Thank you for correction!
>>
>>
>>
>> --
>> Best regards, Sergey.