<AWT Dev> [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

Sreeprakash Sreedharan

Hi,

 

Please review this webrev for JDK-8u backport.

Webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.00/

 

Main Bug: https://bugs.openjdk.java.net/browse/JDK-8183504

JDK10 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-October/013155.html

JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/fd3c961a89ec

 

The patch from JDK10 was not applied cleanly.

 

Changed,

 

cf.ptCurrentPos = {x, y};

cf.rcArea = {0, 0, 0, 0};

 

to

 

cf.ptCurrentPos.x = x;

cf.ptCurrentPos.y = y;

cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;

 

in two places.

 

CANDIDATEFORM ptCurrentPos and rcArea were assigned through copy-list-initialization which is a C++ 11 feature.

This was giving compiler error for JDK8.

 

Regards,

Sreeprakash

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

prasanta sadhukhan

You need to set "cfr" here

3877             cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;
Regards
Prasanta
On 11/27/2017 2:56 PM, Sreeprakash Sreedharan wrote:

Hi,

 

Please review this webrev for JDK-8u backport.

Webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.00/

 

Main Bug: https://bugs.openjdk.java.net/browse/JDK-8183504

JDK10 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-October/013155.html

JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/fd3c961a89ec

 

The patch from JDK10 was not applied cleanly.

 

Changed,

 

cf.ptCurrentPos = {x, y};

cf.rcArea = {0, 0, 0, 0};

 

to

 

cf.ptCurrentPos.x = x;

cf.ptCurrentPos.y = y;

cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;

 

in two places.

 

CANDIDATEFORM ptCurrentPos and rcArea were assigned through copy-list-initialization which is a C++ 11 feature.

This was giving compiler error for JDK8.

 

Regards,

Sreeprakash


Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

Sreeprakash Sreedharan

Thanks for your review Prasanta. I have updated the webrev with the change.

 

Updated Webrev : http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.01/

 

Regards,

Sreeprakash

 

From: Prasanta Sadhukhan
Sent: Monday, November 27, 2017 4:09 PM
To: Sreeprakash Sreedharan <[hidden email]>; Semyon Sadetsky <[hidden email]>
Cc: [hidden email]
Subject: Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

 

You need to set "cfr" here

3877             cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;

Regards
Prasanta

On 11/27/2017 2:56 PM, Sreeprakash Sreedharan wrote:

Hi,

 

Please review this webrev for JDK-8u backport.

Webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.00/

 

Main Bug: https://bugs.openjdk.java.net/browse/JDK-8183504

JDK10 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-October/013155.html

JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/fd3c961a89ec

 

The patch from JDK10 was not applied cleanly.

 

Changed,

 

cf.ptCurrentPos = {x, y};

cf.rcArea = {0, 0, 0, 0};

 

to

 

cf.ptCurrentPos.x = x;

cf.ptCurrentPos.y = y;

cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;

 

in two places.

 

CANDIDATEFORM ptCurrentPos and rcArea were assigned through copy-list-initialization which is a C++ 11 feature.

This was giving compiler error for JDK8.

 

Regards,

Sreeprakash

 

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

prasanta sadhukhan

+1

Regards
Prasanta
On 11/27/2017 5:13 PM, Sreeprakash Sreedharan wrote:

Thanks for your review Prasanta. I have updated the webrev with the change.

 

Updated Webrev : http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.01/

 

Regards,

Sreeprakash

 

From: Prasanta Sadhukhan
Sent: Monday, November 27, 2017 4:09 PM
To: Sreeprakash Sreedharan [hidden email]; Semyon Sadetsky [hidden email]
Cc: [hidden email]
Subject: Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

 

You need to set "cfr" here

3877             cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;

Regards
Prasanta

On 11/27/2017 2:56 PM, Sreeprakash Sreedharan wrote:

Hi,

 

Please review this webrev for JDK-8u backport.

Webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.00/

 

Main Bug: https://bugs.openjdk.java.net/browse/JDK-8183504

JDK10 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-October/013155.html

JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/fd3c961a89ec

 

The patch from JDK10 was not applied cleanly.

 

Changed,

 

cf.ptCurrentPos = {x, y};

cf.rcArea = {0, 0, 0, 0};

 

to

 

cf.ptCurrentPos.x = x;

cf.ptCurrentPos.y = y;

cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0;

 

in two places.

 

CANDIDATEFORM ptCurrentPos and rcArea were assigned through copy-list-initialization which is a C++ 11 feature.

This was giving compiler error for JDK8.

 

Regards,

Sreeprakash