<AWT Dev> [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

Alexey Ivanov
Hello,

Could you please approve the following backport of the fix to 8u-dev?

The patch from JDK9 applies cleanly except for copyright year updates;
all code hunks apply cleanly.

Semyon,

Could you please review the changes?

Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/
JBS: https://bugs.openjdk.java.net/browse/JDK-8179665

Code review:
http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html

JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792


Thanks,
Alexey

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

Rob McKenna
Approved

    -Rob

On 04/12/17 19:17, Alexey Ivanov wrote:

> Hello,
>
> Could you please approve the following backport of the fix to 8u-dev?
>
> The patch from JDK9 applies cleanly except for copyright year updates;
> all code hunks apply cleanly.
>
> Semyon,
>
> Could you please review the changes?
>
> Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8179665
>
> Code review:
> http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html
>
> JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792
>
>
> Thanks,
> Alexey
>
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

Rob McKenna
..pending review!

    -Rob

On 04/12/17 21:33, Rob McKenna wrote:

> Approved
>
>     -Rob
>
> On 04/12/17 19:17, Alexey Ivanov wrote:
> > Hello,
> >
> > Could you please approve the following backport of the fix to 8u-dev?
> >
> > The patch from JDK9 applies cleanly except for copyright year updates;
> > all code hunks apply cleanly.
> >
> > Semyon,
> >
> > Could you please review the changes?
> >
> > Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8179665
> >
> > Code review:
> > http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html
> >
> > JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792
> >
> >
> > Thanks,
> > Alexey
> >
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

semyon.sadetsky
In reply to this post by Alexey Ivanov
+1

--Semyon


On 12/04/2017 11:17 AM, Alexey Ivanov wrote:

> Hello,
>
> Could you please approve the following backport of the fix to 8u-dev?
>
> The patch from JDK9 applies cleanly except for copyright year updates;
> all code hunks apply cleanly.
>
> Semyon,
>
> Could you please review the changes?
>
> Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8179665
>
> Code review:
> http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html
>
> JDK9 changeset:
> http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792
>
>
> Thanks,
> Alexey
>

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location

Alexey Ivanov
Semyon, Rob,

Thank you very much for your quick replies!

Regards,
Alexey

On 05/12/2017 20:19, Semyon Sadetsky wrote:

> +1
>
> --Semyon
>
>
> On 12/04/2017 11:17 AM, Alexey Ivanov wrote:
>> Hello,
>>
>> Could you please approve the following backport of the fix to 8u-dev?
>>
>> The patch from JDK9 applies cleanly except for copyright year updates;
>> all code hunks apply cleanly.
>>
>> Semyon,
>>
>> Could you please review the changes?
>>
>> Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179665
>>
>> Code review:
>> http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html
>>
>> JDK9 changeset:
>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792
>>
>>
>> Thanks,
>> Alexey
>>
>