<AWT Dev> [9] Review Request: 8033128 Javadoc change is required for java.awt.Robot(GraphicsDevice screen) constructor

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> [9] Review Request: 8033128 Javadoc change is required for java.awt.Robot(GraphicsDevice screen) constructor

Sergey Bylokhov
Hello,
Please review the fix for jdk9.

In the fix the «getPixelColor» is added to the list of methods which affected by this constructor.

Also the notion «This constructor is meant for the latter case» is removed,
because irrespective of platform configuration the coordinates passed to Robot
methods will be interpreted "as being in the same coordinate system as the specified screen".
And there is no difference the screens share the same coordinate system or not.


Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> [9] Review Request: 8033128 Javadoc change is required for java.awt.Robot(GraphicsDevice screen) constructor

Alexander Zvegintsev
+1

Thanks,
Alexander.

On 14/02/2017 15:24, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk9.
>
> In the fix the «getPixelColor» is added to the list of methods which
> affected by this constructor.
>
> Also the notion «This constructor is meant for the latter case» is
> removed,
> because irrespective of platform configuration the coordinates passed
> to Robot
> methods will be interpreted "as being in the same coordinate system as
> the specified screen".
> And there is no difference the screens share the same coordinate
> system or not.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8033128
> Webrev can be found at:
> http://cr.openjdk.java.net/~serb/8033128/webrev.00 
> <http://cr.openjdk.java.net/%7Eserb/8033128/webrev.00>
>