<AWT Dev> [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<AWT Dev> [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

Semyon Sadetsky
Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8081454

webrev: http://cr.openjdk.java.net/~ssadetsky/8081454/webrev.00/

A number test of issues specific for OEL 7 is fixed. Some of them are
synchronization issues, some are related to different size of frame
decoration on Gnome3 (mouse click occasionally falls to the minimize
button). The rest test failures are addressed by JDK-8178905.

--Semyon

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

Yuri Nesterenko
Hi Semyon,

in JComboBoxOverlapping.java, wouldn't it be better
to have some synchronization or a dumb delay after invokeAndWait?
loc2 and loc may be not ready on the main thread.
Perhaps making them volatile could help here?


Thanks,
-yan

On 04/18/2017 10:07 PM, Semyon Sadetsky wrote:

> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8081454
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8081454/webrev.00/
>
> A number test of issues specific for OEL 7 is fixed. Some of them are
> synchronization issues, some are related to different size of frame
> decoration on Gnome3 (mouse click occasionally falls to the minimize
> button). The rest test failures are addressed by JDK-8178905.
>
> --Semyon
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

Semyon Sadetsky
Hi Yuri,

The getLocationOnScreen() method is executed synchronously on all
platforms. Since the invokeAndWait() version is used to query location
there is no need in any extra waiting for the location value.

I inserted delay before the location request because the window may not
be shown yet or its final dimensions may not be established. Window
showing is asynchronous and can takes significant time on some platforms.

--Semyon


On 04/19/2017 02:15 AM, Yuri Nesterenko wrote:

> Hi Semyon,
>
> in JComboBoxOverlapping.java, wouldn't it be better
> to have some synchronization or a dumb delay after invokeAndWait?
> loc2 and loc may be not ready on the main thread.
> Perhaps making them volatile could help here?
>
>
> Thanks,
> -yan
>
> On 04/18/2017 10:07 PM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8081454
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8081454/webrev.00/
>>
>> A number test of issues specific for OEL 7 is fixed. Some of them are
>> synchronization issues, some are related to different size of frame
>> decoration on Gnome3 (mouse click occasionally falls to the minimize
>> button). The rest test failures are addressed by JDK-8178905.
>>
>> --Semyon
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

Yuri Nesterenko
+1, then.

-yan

On 04/19/2017 06:08 PM, Semyon Sadetsky wrote:

> Hi Yuri,
>
> The getLocationOnScreen() method is executed synchronously on all
> platforms. Since the invokeAndWait() version is used to query location
> there is no need in any extra waiting for the location value.
>
> I inserted delay before the location request because the window may not
> be shown yet or its final dimensions may not be established. Window
> showing is asynchronous and can takes significant time on some platforms.
>
> --Semyon
>
>
> On 04/19/2017 02:15 AM, Yuri Nesterenko wrote:
>> Hi Semyon,
>>
>> in JComboBoxOverlapping.java, wouldn't it be better
>> to have some synchronization or a dumb delay after invokeAndWait?
>> loc2 and loc may be not ready on the main thread.
>> Perhaps making them volatile could help here?
>>
>>
>> Thanks,
>> -yan
>>
>> On 04/18/2017 10:07 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8081454
>>>
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8081454/webrev.00/
>>>
>>> A number test of issues specific for OEL 7 is fixed. Some of them are
>>> synchronization issues, some are related to different size of frame
>>> decoration on Gnome3 (mouse click occasionally falls to the minimize
>>> button). The rest test failures are addressed by JDK-8178905.
>>>
>>> --Semyon
>>>
>>
>

Loading...