<AWT Dev> [9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<AWT Dev> [9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

Alexandr Scherbatiy

Hello,

Could you review the fix:
   bug: https://bugs.openjdk.java.net/browse/JDK-8175301
   webrev: http://cr.openjdk.java.net/~alexsch/8175301/webrev.00

   D3DSurfaceData.swapBuffers() is updated to scale passed bounds on
HiDPI display.

Thanks,
Alexandr.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> [9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

Alexandr Scherbatiy

   Hello,

Could you review the updated fix:
   http://cr.openjdk.java.net/~alexsch/8175301/webrev.01

There are two places where D3DSurfaceData.swapBuffers() is called
D3DScreenUpdateManager.run() and D3DGraphicsConfig.flip(...).
D3DScreenUpdateManager.run()  uses the surface bounds which are already
scaled.
D3DGraphicsConfig.flip(...) uses coordinates in the user space.

The fix converts the coordinates in the D3DGraphicsConfig.flip(...) to
the device space and converts the coordinates to the user space in the
D3DSurfaceData.swapBuffers() method to pass them to the repaint() method.

Thanks,
Alexandr.

On 3/7/2017 4:58 PM, Alexandr Scherbatiy wrote:

>
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8175301
>   webrev: http://cr.openjdk.java.net/~alexsch/8175301/webrev.00
>
>   D3DSurfaceData.swapBuffers() is updated to scale passed bounds on
> HiDPI display.
>
> Thanks,
> Alexandr.
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> [9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

Sergey Bylokhov
Looks fine.

>
>  Hello,
>
> Could you review the updated fix:
>  http://cr.openjdk.java.net/~alexsch/8175301/webrev.01
>
> There are two places where D3DSurfaceData.swapBuffers() is called D3DScreenUpdateManager.run() and D3DGraphicsConfig.flip(...).
> D3DScreenUpdateManager.run()  uses the surface bounds which are already scaled.
> D3DGraphicsConfig.flip(...) uses coordinates in the user space.
>
> The fix converts the coordinates in the D3DGraphicsConfig.flip(...) to the device space and converts the coordinates to the user space in the D3DSurfaceData.swapBuffers() method to pass them to the repaint() method.
>
> Thanks,
> Alexandr.
>
> On 3/7/2017 4:58 PM, Alexandr Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>  bug: https://bugs.openjdk.java.net/browse/JDK-8175301
>>  webrev: http://cr.openjdk.java.net/~alexsch/8175301/webrev.00
>>
>>  D3DSurfaceData.swapBuffers() is updated to scale passed bounds on HiDPI display.
>>
>> Thanks,
>> Alexandr.
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> [9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

Alexander Zvegintsev
+1

Thanks,
Alexander.

On 09/03/2017 13:48, Sergey Bylokhov wrote:

> Looks fine.
>
>>   Hello,
>>
>> Could you review the updated fix:
>>   http://cr.openjdk.java.net/~alexsch/8175301/webrev.01
>>
>> There are two places where D3DSurfaceData.swapBuffers() is called D3DScreenUpdateManager.run() and D3DGraphicsConfig.flip(...).
>> D3DScreenUpdateManager.run()  uses the surface bounds which are already scaled.
>> D3DGraphicsConfig.flip(...) uses coordinates in the user space.
>>
>> The fix converts the coordinates in the D3DGraphicsConfig.flip(...) to the device space and converts the coordinates to the user space in the D3DSurfaceData.swapBuffers() method to pass them to the repaint() method.
>>
>> Thanks,
>> Alexandr.
>>
>> On 3/7/2017 4:58 PM, Alexandr Scherbatiy wrote:
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8175301
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8175301/webrev.00
>>>
>>>   D3DSurfaceData.swapBuffers() is updated to scale passed bounds on HiDPI display.
>>>
>>> Thanks,
>>> Alexandr.
>>>

Loading...