<AWT Dev> RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Alexander Zuev-3
Initial implementation
Moved the CAccessibility ignore list initialization to the new code
Some cleanup
Expose a new API - isAccessibilityElement instead of deprecated accessibilityIsIgnored

-------------

Commit messages:
 - 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Changes: https://git.openjdk.java.net/jdk/pull/3015/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3015&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261352
  Stats: 140 lines in 5 files changed: 101 ins; 36 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3015.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3015/head:pull/3015

PR: https://git.openjdk.java.net/jdk/pull/3015
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Sergey Bylokhov-2
On Mon, 15 Mar 2021 17:21:01 GMT, Alexander Zuev <[hidden email]> wrote:

> Initial implementation
> Moved the CAccessibility ignore list initialization to the new code
> Some cleanup
> Expose a new API - isAccessibilityElement instead of deprecated accessibilityIsIgnored

src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m line 284:

> 282:
> 283:     if (sRoles == nil) {
> 284:         initializeRoles();

Do we need to delete the JavaAccessibilityIgnore roles from the "sRoles"?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3015
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Alexander Zuev-3
On Wed, 17 Mar 2021 01:39:10 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> Initial implementation
>> Moved the CAccessibility ignore list initialization to the new code
>> Some cleanup
>> Expose a new API - isAccessibilityElement instead of deprecated accessibilityIsIgnored
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m line 284:
>
>> 282:
>> 283:     if (sRoles == nil) {
>> 284:         initializeRoles();
>
> Do we need to delete the JavaAccessibilityIgnore roles from the "sRoles"?

Not right now, there is a legacy code that still uses it and until i am ready to remove all of it i want to keep everything functioning - if anything for the comparison stakes. In the end the entire sRoles map will be eliminated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3015
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Sergey Bylokhov-2
In reply to this post by Alexander Zuev-3
On Mon, 15 Mar 2021 17:21:01 GMT, Alexander Zuev <[hidden email]> wrote:

> Initial implementation
> Moved the CAccessibility ignore list initialization to the new code
> Some cleanup
> Expose a new API - isAccessibilityElement instead of deprecated accessibilityIsIgnored

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3015
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> Integrated: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Alexander Zuev-3
In reply to this post by Alexander Zuev-3
On Mon, 15 Mar 2021 17:21:01 GMT, Alexander Zuev <[hidden email]> wrote:

> Initial implementation
> Moved the CAccessibility ignore list initialization to the new code
> Some cleanup
> Expose a new API - isAccessibilityElement instead of deprecated accessibilityIsIgnored

This pull request has now been integrated.

Changeset: e543a500
Author:    Alexander Zuev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/e543a500
Stats:     140 lines in 5 files changed: 101 ins; 36 del; 3 mod

8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3015