<AWT Dev> RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

Pankaj Bansal-2
The implementation of NSAccessibilityStaticText protocol (https://developer.apple.com/documentation/appkit/nsaccessibilitystatictext) has an incorrect function name which results in the function not being called by Voice Over. The Voice Over output is not getting affected by this bug as the accessibilityValue function returns the correct label value and Voice Over output is correct in all the Label test cases which were tested while implementing the NSAccessibilityStaticText, like few cases in this in following demo. This is the reason that this issue was not caught in testing. (https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java).

Though it does not seem to cause any issue as of now and I still could not find a testcase where it is causing any difference in Voice Over output, this may create problem in future. The functions is getting called by Voice Over after this fix, so this should be fixed.

-------------

Commit messages:
 - 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

Changes: https://git.openjdk.java.net/jdk/pull/2933/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2933&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263420
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2933.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2933/head:pull/2933

PR: https://git.openjdk.java.net/jdk/pull/2933
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

Alexander Zuev-3
On Thu, 11 Mar 2021 07:57:23 GMT, Pankaj Bansal <[hidden email]> wrote:

> The implementation of NSAccessibilityStaticText protocol (https://developer.apple.com/documentation/appkit/nsaccessibilitystatictext) has an incorrect function name which results in the function not being called by Voice Over. The Voice Over output is not getting affected by this bug as the accessibilityValue function returns the correct label value and Voice Over output is correct in all the Label test cases which were tested while implementing the NSAccessibilityStaticText, like few cases in this in following demo. This is the reason that this issue was not caught in testing. (https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java).
>
> Though it does not seem to cause any issue as of now and I still could not find a testcase where it is causing any difference in Voice Over output, this may create problem in future. The functions is getting called by Voice Over after this fix, so this should be fixed.

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2933
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> Integrated: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

Pankaj Bansal-2
In reply to this post by Pankaj Bansal-2
On Thu, 11 Mar 2021 07:57:23 GMT, Pankaj Bansal <[hidden email]> wrote:

> The implementation of NSAccessibilityStaticText protocol (https://developer.apple.com/documentation/appkit/nsaccessibilitystatictext) has an incorrect function name which results in the function not being called by Voice Over. The Voice Over output is not getting affected by this bug as the accessibilityValue function returns the correct label value and Voice Over output is correct in all the Label test cases which were tested while implementing the NSAccessibilityStaticText, like few cases in this in following demo. This is the reason that this issue was not caught in testing. (https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java).
>
> Though it does not seem to cause any issue as of now and I still could not find a testcase where it is causing any difference in Voice Over output, this may create problem in future. The functions is getting called by Voice Over after this fix, so this should be fixed.

This pull request has now been integrated.

Changeset: d896246a
Author:    Pankaj Bansal <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/d896246a
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation

Reviewed-by: kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/2933