<AWT Dev> RFR: 8264680: Use the blessed modifier order in java.desktop

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> RFR: 8264680: Use the blessed modifier order in java.desktop

Alex Blewitt-2
8264680: Use the blessed modifier order in java.desktop

-------------

Commit messages:
 - 8264680: Use the blessed modifier order in java.desktop

Changes: https://git.openjdk.java.net/jdk/pull/3337/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3337&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264680
  Stats: 14 lines in 11 files changed: 0 ins; 1 del; 13 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3337.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3337/head:pull/3337

PR: https://git.openjdk.java.net/jdk/pull/3337
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8264680: Use the blessed modifier order in java.desktop [v2]

Alex Blewitt-2
> 8264680: Use the blessed modifier order in java.desktop

Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:

  Additionally remove detritus from PNGImageDecoder.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3337/files
  - new: https://git.openjdk.java.net/jdk/pull/3337/files/1fb0fe1b..7bb8d9dd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3337&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3337&range=00-01

  Stats: 120 lines in 1 file changed: 0 ins; 113 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3337.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3337/head:pull/3337

PR: https://git.openjdk.java.net/jdk/pull/3337
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8264680: Use the blessed modifier order in java.desktop [v2]

Sergey Bylokhov-2
On Sat, 3 Apr 2021 22:28:54 GMT, Alex Blewitt <[hidden email]> wrote:

>> 8264680: Use the blessed modifier order in java.desktop
>
> Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:
>
>   Additionally remove detritus from PNGImageDecoder.java

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3337
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8264680: Use the blessed modifier order in java.desktop [v2]

Alexander Zuev-3
In reply to this post by Alex Blewitt-2
On Sat, 3 Apr 2021 22:28:54 GMT, Alex Blewitt <[hidden email]> wrote:

>> 8264680: Use the blessed modifier order in java.desktop
>
> Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:
>
>   Additionally remove detritus from PNGImageDecoder.java

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3337
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR: 8264680: Use the blessed modifier order in java.desktop [v2]

Alexander Zvegintsev-2
In reply to this post by Alex Blewitt-2
On Sat, 3 Apr 2021 22:28:54 GMT, Alex Blewitt <[hidden email]> wrote:

>> 8264680: Use the blessed modifier order in java.desktop
>
> Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision:
>
>   Additionally remove detritus from PNGImageDecoder.java

Marked as reviewed by azvegint (Reviewer).

src/java.desktop/share/classes/sun/awt/image/PNGImageDecoder.java line 2:

> 1: /*
> 2:  * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved.

Copyright year in other files might be updated as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3337
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> Integrated: 8264680: Use the blessed modifier order in java.desktop

Alex Blewitt-2
In reply to this post by Alex Blewitt-2
On Sat, 3 Apr 2021 22:03:44 GMT, Alex Blewitt <[hidden email]> wrote:

> 8264680: Use the blessed modifier order in java.desktop

This pull request has now been integrated.

Changeset: 92fad1b4
Author:    Alex Blewitt <[hidden email]>
Committer: Sergey Bylokhov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/92fad1b4
Stats:     132 lines in 11 files changed: 0 ins; 114 del; 18 mod

8264680: Use the blessed modifier order in java.desktop

Reviewed-by: serb, kizune, azvegint

-------------

PR: https://git.openjdk.java.net/jdk/pull/3337