<AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

Lindenmaier, Goetz
Hi,

I added @key headful to some more tests where it was missing.
Also, I fixed some NPEs I get when running the tests headless.
Please review.
http://cr.openjdk.java.net/~goetz/wr17/8191678-headfulKey/webrev.01/

Best regards,
  Goetz.

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

Sergey Bylokhov
Looks fine.

On 29/11/2017 00:01, Lindenmaier, Goetz wrote:

> Hi,
>
> I added @key headful to some more tests where it was missing.
> Also, I fixed some NPEs I get when running the tests headless.
> Please review.
> http://cr.openjdk.java.net/~goetz/wr17/8191678-headfulKey/webrev.01/
>
> Best regards,
>    Goetz.
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

Lindenmaier, Goetz
Hi Sergey,

thanks for looking at the change.

Unfortunately there popped up four more test requiring a 'head'
in the repo tonight.
I added them, too:
http://cr.openjdk.java.net/~goetz/wr17/8191678-headfulKey/webrev.02/

Is it still fine?

Thanks,
  Goetz.

> -----Original Message-----
> From: Sergey Bylokhov [mailto:[hidden email]]
> Sent: Mittwoch, 29. November 2017 14:49
> To: Lindenmaier, Goetz <[hidden email]>; awt-
> [hidden email]
> Subject: Re: <AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in
> java/awt and javax tests.
>
> Looks fine.
>
> On 29/11/2017 00:01, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > I added @key headful to some more tests where it was missing.
> > Also, I fixed some NPEs I get when running the tests headless.
> > Please review.
> > http://cr.openjdk.java.net/~goetz/wr17/8191678-headfulKey/webrev.01/
> >
> > Best regards,
> >    Goetz.
> >
>
>
> --
> Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

Sergey Bylokhov
On 30/11/2017 02:55, Lindenmaier, Goetz wrote:
> Is it still fine?

Yes, looks fine.

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

Lindenmaier, Goetz
Thanks a lot!

Best regards,
  Goetz.

> -----Original Message-----
> From: Sergey Bylokhov [mailto:[hidden email]]
> Sent: Donnerstag, 30. November 2017 21:36
> To: Lindenmaier, Goetz <[hidden email]>; awt-
> [hidden email]
> Subject: Re: <AWT Dev> RFR(S): 8191678: [TESTBUG] Add keyword headful in
> java/awt and javax tests.
>
> On 30/11/2017 02:55, Lindenmaier, Goetz wrote:
> > Is it still fine?
>
> Yes, looks fine.
>
> --
> Best regards, Sergey.