Quantcast

<AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

Rahul Singh
Hi All,

Kindly review the fix for the bug: JDK-8137087 [TEST BUG]
The test java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh needed few changes to be run in the Cygwin Environment.

Bug Link: https://bugs.openjdk.java.net/browse/JDK-8137087

The webrev is : http://cr.openjdk.java.net/~srastogi/rahul/8137087/webrev.00/

Regards,
Rahul Singh
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

Yuri Nesterenko
OK with me.

TMP variable would be still in POSIX notation but
it seems not necessary here.

-yan

On 01/24/2017 09:44 AM, Rahul Singh wrote:

> Hi All,
>
> Kindly review the fix for the bug: JDK-8137087 <https://bugs.openjdk.java.net/browse/JDK-8137087> [TEST BUG]
> The test java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh needed few changes to be run in the Cygwin Environment.
>
> Bug Link: https://bugs.openjdk.java.net/browse/JDK-8137087
>
> The webrev is : http://cr.openjdk.java.net/~srastogi/rahul/8137087/webrev.00/
>
> Regards,
> Rahul Singh
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

Ambarish Rapte
Hi Rahul,
        I think the line number 139 can be removed.
        Similarly please remove the 2 new empty lines. No: 158 & 247.

Regards,
Ambarish

-----Original Message-----
From: Yuri Nesterenko
Sent: Tuesday, January 31, 2017 2:52 PM
To: Rahul Singh; [hidden email]
Subject: Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

OK with me.

TMP variable would be still in POSIX notation but it seems not necessary here.

-yan

On 01/24/2017 09:44 AM, Rahul Singh wrote:

> Hi All,
>
> Kindly review the fix for the bug: JDK-8137087
> <https://bugs.openjdk.java.net/browse/JDK-8137087> [TEST BUG] The test java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh needed few changes to be run in the Cygwin Environment.
>
> Bug Link: https://bugs.openjdk.java.net/browse/JDK-8137087
>
> The webrev is :
> http://cr.openjdk.java.net/~srastogi/rahul/8137087/webrev.00/
>
> Regards,
> Rahul Singh
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

Rahul Singh
Hi Ambarish,

I've made the suggested changes

  http://cr.openjdk.java.net/~srastogi/rahul/8137087/8137087/webrev.01/

-Regards,
Rahul Singh

On 2017-02-07 2:17 PM, Ambarish Rapte wrote:

> Hi Rahul,
> I think the line number 139 can be removed.
> Similarly please remove the 2 new empty lines. No: 158 & 247.
>
> Regards,
> Ambarish
>
> -----Original Message-----
> From: Yuri Nesterenko
> Sent: Tuesday, January 31, 2017 2:52 PM
> To: Rahul Singh; [hidden email]
> Subject: Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh
>
> OK with me.
>
> TMP variable would be still in POSIX notation but it seems not necessary here.
>
> -yan
>
> On 01/24/2017 09:44 AM, Rahul Singh wrote:
>> Hi All,
>>
>> Kindly review the fix for the bug: JDK-8137087
>> <https://bugs.openjdk.java.net/browse/JDK-8137087> [TEST BUG] The test java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh needed few changes to be run in the Cygwin Environment.
>>
>> Bug Link: https://bugs.openjdk.java.net/browse/JDK-8137087
>>
>> The webrev is :
>> http://cr.openjdk.java.net/~srastogi/rahul/8137087/webrev.00/
>>
>> Regards,
>> Rahul Singh
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

Ambarish Rapte
Thanks Rahul,
        Looks good to me.

Regards,
Ambarish

-----Original Message-----
From: Rahul Singh
Sent: Tuesday, February 07, 2017 3:48 PM
To: Ambarish Rapte; Yuri Nesterenko; [hidden email]
Subject: Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

Hi Ambarish,

I've made the suggested changes

  http://cr.openjdk.java.net/~srastogi/rahul/8137087/8137087/webrev.01/

-Regards,
Rahul Singh

On 2017-02-07 2:17 PM, Ambarish Rapte wrote:

> Hi Rahul,
> I think the line number 139 can be removed.
> Similarly please remove the 2 new empty lines. No: 158 & 247.
>
> Regards,
> Ambarish
>
> -----Original Message-----
> From: Yuri Nesterenko
> Sent: Tuesday, January 31, 2017 2:52 PM
> To: Rahul Singh; [hidden email]
> Subject: Re: <AWT Dev> Review request for : JDK-8137087 [TEST BUG]
> java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncoded
> URLTest.sh
>
> OK with me.
>
> TMP variable would be still in POSIX notation but it seems not necessary here.
>
> -yan
>
> On 01/24/2017 09:44 AM, Rahul Singh wrote:
>> Hi All,
>>
>> Kindly review the fix for the bug: JDK-8137087
>> <https://bugs.openjdk.java.net/browse/JDK-8137087> [TEST BUG] The test java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh needed few changes to be run in the Cygwin Environment.
>>
>> Bug Link: https://bugs.openjdk.java.net/browse/JDK-8137087
>>
>> The webrev is :
>> http://cr.openjdk.java.net/~srastogi/rahul/8137087/webrev.00/
>>
>> Regards,
>> Rahul Singh
>>

Loading...