<AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Manajit Halder
Hi All,

Kindly review the fix for JDK10.

Bug: 

Webrev: 

Issue: 
Test closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails with timeout.

Cause: 
Test was failing due to robot keyPress without proper synchronization. 

Fix: 
Fix involves adding waitForIdle after keyPresses.

Note: 
Crucible review (https://java.se.oracle.com/code/cru/CR-JDK10CLIENT-137) for the closed test case
Added the same case to the open codebase and generated this review.

Regards,
Manajit
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Sergey Bylokhov
Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8158366
> Webrev:
> http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/



--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Prem Balakrishnan
+1

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, November 24, 2017 1:16 PM
To: Manajit Halder <[hidden email]>; Prem Balakrishnan <[hidden email]>
Cc: [hidden email]
Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8158366
> Webrev:
> http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/



--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Ajit Ghaisas
1) This test lacks copyright banner at the top
2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception.

Regards,
Ajit

-----Original Message-----
From: Prem Balakrishnan
Sent: Monday, November 27, 2017 12:02 PM
To: Sergey Bylokhov; Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

+1

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, November 24, 2017 1:16 PM
To: Manajit Halder <[hidden email]>; Prem Balakrishnan <[hidden email]>
Cc: [hidden email]
Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8158366
> Webrev:
> http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/



--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Manajit Halder
Hi Ajit,

Modified the code as per your review comments.
Please review the changes.


Thanks,
Manajit

On 27-Nov-2017, at 1:50 PM, Ajit Ghaisas <[hidden email]> wrote:

1) This test lacks copyright banner at the top
2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception.

Regards,
Ajit

-----Original Message-----
From: Prem Balakrishnan
Sent: Monday, November 27, 2017 12:02 PM
To: Sergey Bylokhov; Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

+1

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, November 24, 2017 1:16 PM
To: Manajit Halder <[hidden email]>; Prem Balakrishnan <[hidden email]>
Cc: [hidden email]
Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:
Bug:
https://bugs.openjdk.java.net/browse/JDK-8158366
Webrev:
http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/



--
Best regards, Sergey.

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Ajit Ghaisas

Hi Manajit,

 

   The changes look good.

 

    As this is a new test in open, can you please confirm whether it passes on Windows and Linux as well?

 

Regards,

Ajit

 

From: Manajit Halder
Sent: Monday, November 27, 2017 4:35 PM
To: Ajit Ghaisas
Cc: Prem Balakrishnan; Sergey Bylokhov; [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

 

Hi Ajit,

 

Modified the code as per your review comments.

Please review the changes.

 

 

Thanks,

Manajit

 

On 27-Nov-2017, at 1:50 PM, Ajit Ghaisas <[hidden email]> wrote:

 

1) This test lacks copyright banner at the top
2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception.

Regards,
Ajit

-----Original Message-----
From: Prem Balakrishnan
Sent: Monday, November 27, 2017 12:02 PM
To: Sergey Bylokhov; Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

+1

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, November 24, 2017 1:16 PM
To: Manajit Halder <[hidden email]>; Prem Balakrishnan <[hidden email]>
Cc: [hidden email]
Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:

Bug:
https://bugs.openjdk.java.net/browse/JDK-8158366
Webrev:
http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/




--
Best regards, Sergey.

 

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Manajit Halder
Hi Ajit,

Yes, test passes in Windows and Linux.

Thanks,
Manajit

On 28-Nov-2017, at 10:22 AM, Ajit Ghaisas <[hidden email]> wrote:

Hi Manajit,
 
   The changes look good.
 
    As this is a new test in open, can you please confirm whether it passes on Windows and Linux as well?
 
Regards,
Ajit
 
From: Manajit Halder 
Sent: Monday, November 27, 2017 4:35 PM
To: Ajit Ghaisas
Cc: Prem Balakrishnan; Sergey Bylokhov; [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails
 
Hi Ajit,
 
Modified the code as per your review comments.
Please review the changes.
 
 
Thanks,
Manajit
 
On 27-Nov-2017, at 1:50 PM, Ajit Ghaisas <[hidden email]> wrote:
 
1) This test lacks copyright banner at the top
2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception.

Regards,
Ajit

-----Original Message-----
From: Prem Balakrishnan 
Sent: Monday, November 27, 2017 12:02 PM
To: Sergey Bylokhov; Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

+1

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov 
Sent: Friday, November 24, 2017 1:16 PM
To: Manajit Halder <[hidden email]>; Prem Balakrishnan <[hidden email]>
Cc: [hidden email]
Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:




-- 
Best regards, Sergey.

Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Ajit Ghaisas

Good. +1.

 

Regards,

Ajit

 

From: Manajit Halder
Sent: Tuesday, November 28, 2017 5:28 PM
To: Ajit Ghaisas
Cc: Prem Balakrishnan; Sergey Bylokhov; [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

 

Hi Ajit,

 

Yes, test passes in Windows and Linux.

 

Thanks,

Manajit

 

On 28-Nov-2017, at 10:22 AM, Ajit Ghaisas <[hidden email]> wrote:

 

Hi Manajit,

 

   The changes look good.

 

    As this is a new test in open, can you please confirm whether it passes on Windows and Linux as well?

 

Regards,

Ajit

 

From: Manajit Halder 
Sent: Monday, November 27, 2017 4:35 PM
To: Ajit Ghaisas
Cc: Prem Balakrishnan; Sergey Bylokhov; [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

 

Hi Ajit,

 

Modified the code as per your review comments.

Please review the changes.

 

 

Thanks,

Manajit

 

On 27-Nov-2017, at 1:50 PM, Ajit Ghaisas <[hidden email]> wrote:

 

1) This test lacks copyright banner at the top
2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception.

Regards,
Ajit

-----Original Message-----
From: Prem Balakrishnan 
Sent: Monday, November 27, 2017 12:02 PM
To: Sergey Bylokhov; Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

+1

Regards,
Prem

-----Original Message-----
From: Sergey Bylokhov 
Sent: Friday, November 24, 2017 1:16 PM
To: Manajit Halder <[hidden email]>; Prem Balakrishnan <[hidden email]>
Cc: [hidden email]
Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Looks fine.

On 23/11/2017 02:05, Manajit Halder wrote:





-- 
Best regards, Sergey.