<AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Manajit Halder
Hi All,

Kindly review the fix for JDK9.

Bug: 

Webrev: 

Issue: 
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

Fix: 
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
The test was cleaned up and moved from closed to open
Removed applet code
Manual test to automatic test

Regards,
Manajit
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Prem Balakrishnan

Looks  good to me.

 

Regards,

Prem

 

From: Manajit Halder
Sent: Friday, February 10, 2017 2:56 PM
To: Sergey Bylokhov; Prem Balakrishnan
Cc: [hidden email]
Subject: <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

 

Hi All,

 

Kindly review the fix for JDK9.

 

Bug: 

 

Webrev: 

 

Issue: 

Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

 

Fix: 

Fixed the issue by adding a waitForIdle() call after the mouseMove.

Along with the fix the following changes were done:

                The test was cleaned up and moved from closed to open

                Removed applet code

                Manual test to automatic test

 

Regards,

Manajit

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Sergey Bylokhov
In reply to this post by Manajit Halder
Hi, Manajit.
Just one comment, the frame should be disposed if the test fails.


Hi All,

Kindly review the fix for JDK9.

Bug: 

Webrev: 

Issue: 
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

Fix: 
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
The test was cleaned up and moved from closed to open
Removed applet code
Manual test to automatic test

Regards,
Manajit

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Manajit Halder
Hi Sergey,

Thank you for the review comment. Please review the modified code.

Regards,
Manajit

On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <[hidden email]> wrote:

Hi, Manajit.
Just one comment, the frame should be disposed if the test fails.


Hi All,

Kindly review the fix for JDK9.

Bug: 

Webrev: 

Issue: 
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

Fix: 
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
The test was cleaned up and moved from closed to open
Removed applet code
Manual test to automatic test

Regards,
Manajit


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Sergey Bylokhov
It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.


Hi Sergey,

Thank you for the review comment. Please review the modified code.

Regards,
Manajit

On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <[hidden email]> wrote:

Hi, Manajit.
Just one comment, the frame should be disposed if the test fails.


Hi All,

Kindly review the fix for JDK9.

Bug: 

Webrev: 

Issue: 
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

Fix: 
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
The test was cleaned up and moved from closed to open
Removed applet code
Manual test to automatic test

Regards,
Manajit



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Ambarish Rapte

Hi Manajit,

Please include the jtreg tag: @key headful  

& also include the bug id: 4009555 from the original test.

Regards,

Ambarish

 

From: Sergey Bylokhov
Sent: Monday, February 13, 2017 11:02 PM
To: Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

 

It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.

 

 

Hi Sergey,

 

Thank you for the review comment. Please review the modified code.

 

Regards,

Manajit

 

On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <[hidden email]> wrote:

 

Hi, Manajit.

Just one comment, the frame should be disposed if the test fails.

 

 

Hi All,

 

Kindly review the fix for JDK9.

 

Bug: 

 

Webrev: 

 

Issue: 

Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

 

Fix: 

Fixed the issue by adding a waitForIdle() call after the mouseMove.

Along with the fix the following changes were done:

                The test was cleaned up and moved from closed to open

                Removed applet code

                Manual test to automatic test

 

Regards,

Manajit

 

 

 

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Manajit Halder
Hi All,

Thanks for your review comments. Please review the modified code.

Thanks,
Manajit

On 14-Feb-2017, at 2:14 pm, Ambarish Rapte <[hidden email]> wrote:

Hi Manajit,
Please include the jtreg tag: @key headful  
& also include the bug id: 4009555 from the original test.

Regards,
Ambarish
 
From: Sergey Bylokhov 
Sent: Monday, February 13, 2017 11:02 PM
To: Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac
 
It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.
 
 
Hi Sergey,
 
Thank you for the review comment. Please review the modified code.
 
Regards,
Manajit
 
On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <[hidden email]> wrote:
 
Hi, Manajit.
Just one comment, the frame should be disposed if the test fails.
 
 
Hi All,
 
Kindly review the fix for JDK9.
 
Bug: 
 
Webrev: 
 
Issue: 
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 
 
Fix: 
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
                The test was cleaned up and moved from closed to open
                Removed applet code
                Manual test to automatic test
 
Regards,
Manajit

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Ambarish Rapte

Thanks Manajit,

                Looks good to me.          

Regards,

Ambarish

 

From: Manajit Halder
Sent: Tuesday, February 14, 2017 6:21 PM
To: Ambarish Rapte; Sergey Bylokhov
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

 

Hi All,

 

Thanks for your review comments. Please review the modified code.

 

Thanks,

Manajit

 

On 14-Feb-2017, at 2:14 pm, Ambarish Rapte <[hidden email]> wrote:

 

Hi Manajit,

Please include the jtreg tag: @key headful  

& also include the bug id: 4009555 from the original test.

Regards,

Ambarish

 

From: Sergey Bylokhov 
Sent: Monday, February 13, 2017 11:02 PM
To: Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

 

It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.

 

 

Hi Sergey,

 

Thank you for the review comment. Please review the modified code.

 

Regards,

Manajit

 

On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <[hidden email]> wrote:

 

Hi, Manajit.

Just one comment, the frame should be disposed if the test fails.

 

 

Hi All,

 

Kindly review the fix for JDK9.

 

Bug: 

 

Webrev: 

 

Issue: 

Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

 

Fix: 

Fixed the issue by adding a waitForIdle() call after the mouseMove.

Along with the fix the following changes were done:

                The test was cleaned up and moved from closed to open

                Removed applet code

                Manual test to automatic test

 

Regards,

Manajit

 

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

Sergey Bylokhov

Thanks Manajit,
                Looks good to me.           

+1


Regards,
Ambarish
 
From: Manajit Halder 
Sent: Tuesday, February 14, 2017 6:21 PM
To: Ambarish Rapte; Sergey Bylokhov
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac
 
Hi All,
 
Thanks for your review comments. Please review the modified code.
 
Thanks,
Manajit
 
On 14-Feb-2017, at 2:14 pm, Ambarish Rapte <[hidden email]> wrote:
 
Hi Manajit,
Please include the jtreg tag: @key headful  
& also include the bug id: 4009555 from the original test.

Regards,
Ambarish
 
From: Sergey Bylokhov 
Sent: Monday, February 13, 2017 11:02 PM
To: Manajit Halder
Cc: [hidden email]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac
 
It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.
 
 
Hi Sergey,
 
Thank you for the review comment. Please review the modified code.
 
Regards,
Manajit
 
On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <[hidden email]> wrote:
 
Hi, Manajit.
Just one comment, the frame should be disposed if the test fails.
 
 
Hi All,
 
Kindly review the fix for JDK9.
 
Bug: 
 
Webrev: 
 
Issue: 
Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 
 
Fix: 
Fixed the issue by adding a waitForIdle() call after the mouseMove.
Along with the fix the following changes were done:
                The test was cleaned up and moved from closed to open
                Removed applet code
                Manual test to automatic test
 
Regards,
Manajit

Loading...