<AWT Dev> <Swing Dev> [10] Review request for 8190228: Remove redundant modifiers in java.desktop module.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

<AWT Dev> <Swing Dev> [10] Review request for 8190228: Remove redundant modifiers in java.desktop module.

Semyon Sadetsky
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8190228

webrev: http://cr.openjdk.java.net/~ssadetsky/8190228/webrev.00/

The fix cleanups Swing and AWT code to remove the redundant code like:

SomeClass *extends Object*

private *final* ...someMethod()

--Semyon


Reply | Threaded
Open this post in threaded view
|

Re: <AWT Dev> <Swing Dev> [10] Review request for 8190228: Remove redundant modifiers in java.desktop module.

Sergey Bylokhov
Looks fine.

On 07/11/2017 08:27, Semyon Sadetsky wrote:

> Hello,
>
> Please review fix for JDK10:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8190228
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8190228/webrev.00/
>
> The fix cleanups Swing and AWT code to remove the redundant code like:
>
> SomeClass *extends Object*
>
> private *final* ...someMethod()
>
> --Semyon
>
>


--
Best regards, Sergey.