<Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Muneer Kolarkunnu

Hi,

 

Please review the fix for JDK-8191803.

Bug: https://bugs.openjdk.java.net/browse/JDK-8191803

Webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.00/

 

Issue: In usual ways itself, it is taking 30-40 seconds to complete the progress bar. So in slow machines it may take more time. Default timeout is 1 minute. Also in the screen shots, it is visible that demo is not blocked anywhere, it is still continuing, but failed due to timeout.

Fix: Increase the progress bar timeout from 1 min to 3 min.

 

Regards,

Muneer

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Sergey Bylokhov
Hello.
On 03/12/2017 22:54, Muneer Kolarkunnu wrote:
> Issue: In usual ways itself, it is taking 30-40 seconds to complete the
> progress bar. So in slow machines it may take more time. Default timeout
> is 1 minute. Also in the screen shots, it is visible that demo is not
> blocked anywhere, it is still continuing, but failed due to timeout.

As far as I know that jtreg by default has 2 minute timeout, should it
also be changed to 3 minutes?

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Phil Race
 From memory, I think Sergey is right that the jtreg default time out is
2 minutes (120 seconds).
As to changing that to 3 minutes .. that is something that needs to be
decided at a jtreg ownership level.

A little off topic, but I've sometimes pondered if jtreg ought to have
an option to avoid running lengthy tests,
when time is of the essence. e.g., any test that specifies a timeout
greater than the default.
But if only a few percent of tests do that it probably does not make
enough difference to matter.

-phil.

On 12/04/2017 10:29 AM, Sergey Bylokhov wrote:

> Hello.
> On 03/12/2017 22:54, Muneer Kolarkunnu wrote:
>> Issue: In usual ways itself, it is taking 30-40 seconds to complete
>> the progress bar. So in slow machines it may take more time. Default
>> timeout is 1 minute. Also in the screen shots, it is visible that
>> demo is not blocked anywhere, it is still continuing, but failed due
>> to timeout.
>
> As far as I know that jtreg by default has 2 minute timeout, should it
> also be changed to 3 minutes?
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Alexandre (Shura) Iline


> On Dec 4, 2017, at 10:54 AM, Phil Race <[hidden email]> wrote:
>
> From memory, I think Sergey is right that the jtreg default time out is 2 minutes (120 seconds).
> As to changing that to 3 minutes .. that is something that needs to be decided at a jtreg ownership level.

I though that Sergey suggested to change the timeout for this specific test. Per JTreg doc: /timeout=<seconds> could be used. This is a very valid suggestion, IMO.


>
> A little off topic, but I've sometimes pondered if jtreg ought to have an option to avoid running lengthy tests,
> when time is of the essence. e.g., any test that specifies a timeout greater than the default.

One way would be to mark the slow tests with a keyword, but I did not find any keyword used right now for that.

Client tests - at least those involving simulating user actions - should not be selected at all during such runs, I would expect. Simply because the user input simulation is (usually) accompanied with some waiting. Practically speaking, we should not expect those in rush to run headful tests anyway, and the test in question is marked with @key headful.

Shura

> But if only a few percent of tests do that it probably does not make enough difference to matter.
>
> -phil.
>
> On 12/04/2017 10:29 AM, Sergey Bylokhov wrote:
>> Hello.
>> On 03/12/2017 22:54, Muneer Kolarkunnu wrote:
>>> Issue: In usual ways itself, it is taking 30-40 seconds to complete the progress bar. So in slow machines it may take more time. Default timeout is 1 minute. Also in the screen shots, it is visible that demo is not blocked anywhere, it is still continuing, but failed due to timeout.
>>
>> As far as I know that jtreg by default has 2 minute timeout, should it also be changed to 3 minutes?
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Muneer Kolarkunnu
In reply to this post by Sergey Bylokhov
Hi Sergey,

I updated the webrev to incorporate your comment.
New webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/
I kept jtreg timeout as 4 minute by considering all other operations of the test case.

Regards,
Muneer

-----Original Message-----
From: Sergey Bylokhov
Sent: Monday, December 04, 2017 11:59 PM
To: Muneer Kolarkunnu <[hidden email]>; [hidden email]
Cc: Aleksandre Iline <[hidden email]>
Subject: Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Hello.
On 03/12/2017 22:54, Muneer Kolarkunnu wrote:
> Issue: In usual ways itself, it is taking 30-40 seconds to complete
> the progress bar. So in slow machines it may take more time. Default
> timeout is 1 minute. Also in the screen shots, it is visible that demo
> is not blocked anywhere, it is still continuing, but failed due to timeout.

As far as I know that jtreg by default has 2 minute timeout, should it also be changed to 3 minutes?

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

Sergey Bylokhov
Looks fine.

On 06/12/2017 05:20, Muneer Kolarkunnu wrote:

> Hi Sergey,
>
> I updated the webrev to incorporate your comment.
> New webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/
> I kept jtreg timeout as 4 minute by considering all other operations of the test case.
>
> Regards,
> Muneer
>
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Monday, December 04, 2017 11:59 PM
> To: Muneer Kolarkunnu <[hidden email]>; [hidden email]
> Cc: Aleksandre Iline <[hidden email]>
> Subject: Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached
>
> Hello.
> On 03/12/2017 22:54, Muneer Kolarkunnu wrote:
>> Issue: In usual ways itself, it is taking 30-40 seconds to complete
>> the progress bar. So in slow machines it may take more time. Default
>> timeout is 1 minute. Also in the screen shots, it is visible that demo
>> is not blocked anywhere, it is still continuing, but failed due to timeout.
>
> As far as I know that jtreg by default has 2 minute timeout, should it also be changed to 3 minutes?
>
> --
> Best regards, Sergey.
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

prasanta sadhukhan
+1

Regards
Prasanta
On 12/6/2017 8:29 PM, Sergey Bylokhov wrote:

> Looks fine.
>
> On 06/12/2017 05:20, Muneer Kolarkunnu wrote:
>> Hi Sergey,
>>
>> I updated the webrev to incorporate your comment.
>> New webrev:
>> http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/
>> I kept jtreg timeout as 4 minute by considering all other operations
>> of the test case.
>>
>> Regards,
>> Muneer
>>
>> -----Original Message-----
>> From: Sergey Bylokhov
>> Sent: Monday, December 04, 2017 11:59 PM
>> To: Muneer Kolarkunnu <[hidden email]>;
>> [hidden email]
>> Cc: Aleksandre Iline <[hidden email]>
>> Subject: Re: <Swing Dev> [10] RFR JDK-8191803 : [TEST_BUG] :
>> sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait
>> "greater then 1349" state to be reached
>>
>> Hello.
>> On 03/12/2017 22:54, Muneer Kolarkunnu wrote:
>>> Issue: In usual ways itself, it is taking 30-40 seconds to complete
>>> the progress bar. So in slow machines it may take more time. Default
>>> timeout is 1 minute. Also in the screen shots, it is visible that demo
>>> is not blocked anywhere, it is still continuing, but failed due to
>>> timeout.
>>
>> As far as I know that jtreg by default has 2 minute timeout, should
>> it also be changed to 3 minutes?
>>
>> --
>> Best regards, Sergey.
>>
>
>