<Swing Dev> [10] Review Request: 8075255 Metal L&F has dependency on the Windows L&F

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> [10] Review Request: 8075255 Metal L&F has dependency on the Windows L&F

Sergey Bylokhov
Hello,
Please review the fix for jdk10.

Bug: https://bugs.openjdk.java.net/browse/JDK-8075255
Webrev can be found at: http://cr.openjdk.java.net/~serb/8075255/webrev.01

In the fix the dependency of MetalLookAndFeel from WindowsLookAndFeel is
broken.

The old DesktopProperty which contains the general functionality was
moved to sun/swing/plaf/DesktopProperty.java. This class can be reused
later by other platforms/l&f if needed.

The Windows/Metal specific functionality was placed in
WindowsDesktopProperty(used in win L&F) and in
MetalFontDesktopProperty(used in metal l&f). The new test was added to
check that this functionality actually works.

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review Request: 8075255 Metal L&F has dependency on the Windows L&F

prasanta sadhukhan
looks good to me.

bugid needs to be added to Test6824600.java

Regards
Prasanta
On 10/13/2017 7:24 AM, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8075255
> Webrev can be found at:
> http://cr.openjdk.java.net/~serb/8075255/webrev.01
>
> In the fix the dependency of MetalLookAndFeel from WindowsLookAndFeel
> is broken.
>
> The old DesktopProperty which contains the general functionality was
> moved to sun/swing/plaf/DesktopProperty.java. This class can be reused
> later by other platforms/l&f if needed.
>
> The Windows/Metal specific functionality was placed in
> WindowsDesktopProperty(used in win L&F) and in
> MetalFontDesktopProperty(used in metal l&f). The new test was added to
> check that this functionality actually works.
>