<Swing Dev> [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

Semyon Sadetsky
Hello,

Please review fix for JDK10 (the changes involve AWT and Swing):

bug: https://bugs.openjdk.java.net/browse/JDK-8182041

webrev: http://cr.openjdk.java.net/~ssadetsky/8182041/webrev.00/

New API method was added letting to query shortcut panel entries for
JFileChooser.

--Semyon

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

Alexander Zvegintsev

Hi Semyon,

the fix looks good to me, but I found a minor typo in the test:

testShortcatPanelFiles -> testShortcutPanelFiles

no need for a new webrev

Thanks,
Alexander.
On 04/10/2017 00:41, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10 (the changes involve AWT and Swing):

bug: https://bugs.openjdk.java.net/browse/JDK-8182041

webrev: http://cr.openjdk.java.net/~ssadetsky/8182041/webrev.00/

New API method was added letting to query shortcut panel entries for JFileChooser.

--Semyon