<Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Semyon Sadetsky
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8187599

webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.00/

External JAXB was replaced by StAX parser in Nimbus L&F classes generation.

--Semyon


Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Sergey Bylokhov
Hi, Semyon.
It seems that this change breaks the build, because it added a new
non-default constructor to SynthModel.

open/make/jdk/src/classes/build/tools/generatenimbus/ObjectFactory.java:60:
error: constructor SynthModel in class SynthModel cannot be applied to
given types;
         return new SynthModel();
                ^
   required: XMLStreamReader
   found: no arguments

On 9/20/17 20:11, Semyon Sadetsky wrote:

> Hello,
>
> Please review fix for JDK10:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8187599
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.00/
>
> External JAXB was replaced by StAX parser in Nimbus L&F classes generation.
>
> --Semyon
>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Phil Race
This change is also huge. How did you do this ? Manually ?
There should be diffs of the files generated this way and the files
generated by JAXB
so we can compare. Ideally they'd be byte-for-byte identical but failing
that it should
be trivial to see that any diffs are insignificant.

-phil.

On 09/25/2017 10:14 AM, Sergey Bylokhov wrote:

> Hi, Semyon.
> It seems that this change breaks the build, because it added a new
> non-default constructor to SynthModel.
>
> open/make/jdk/src/classes/build/tools/generatenimbus/ObjectFactory.java:60:
> error: constructor SynthModel in class SynthModel cannot be applied to
> given types;
>         return new SynthModel();
>                ^
>   required: XMLStreamReader
>   found: no arguments
>
> On 9/20/17 20:11, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK10:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8187599
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.00/
>>
>> External JAXB was replaced by StAX parser in Nimbus L&F classes
>> generation.
>>
>> --Semyon
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Semyon Sadetsky
In reply to this post by Sergey Bylokhov
On 09/25/2017 10:14 AM, Sergey Bylokhov wrote:

> Hi, Semyon.
> It seems that this change breaks the build, because it added a new
> non-default constructor to SynthModel.
>
> open/make/jdk/src/classes/build/tools/generatenimbus/ObjectFactory.java:60:
> error: constructor SynthModel in class SynthModel cannot be applied to
> given types;
>         return new SynthModel();
>                ^
>   required: XMLStreamReader
>   found: no arguments
ObjectFactory.java was missed from the webrev. It should be deleted
actually.
The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.01/

>
> On 9/20/17 20:11, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK10:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8187599
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.00/
>>
>> External JAXB was replaced by StAX parser in Nimbus L&F classes
>> generation.
>>
>> --Semyon
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Semyon Sadetsky
In reply to this post by Phil Race
On 09/25/2017 10:26 AM, Phil Race wrote:

> This change is also huge. How did you do this ? Manually ?
Yes, manually.
> There should be diffs of the files generated this way and the files
> generated by JAXB
> so we can compare. Ideally they'd be byte-for-byte identical but
> failing that it should
> be trivial to see that any diffs are insignificant.
I did the diff. All files files are byte-for-byte identical.

--Semyon

>
> -phil.
>
> On 09/25/2017 10:14 AM, Sergey Bylokhov wrote:
>> Hi, Semyon.
>> It seems that this change breaks the build, because it added a new
>> non-default constructor to SynthModel.
>>
>> open/make/jdk/src/classes/build/tools/generatenimbus/ObjectFactory.java:60:
>> error: constructor SynthModel in class SynthModel cannot be applied
>> to given types;
>>         return new SynthModel();
>>                ^
>>   required: XMLStreamReader
>>   found: no arguments
>>
>> On 9/20/17 20:11, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK10:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8187599
>>>
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.00/
>>>
>>> External JAXB was replaced by StAX parser in Nimbus L&F classes
>>> generation.
>>>
>>> --Semyon
>>>
>>>
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Sergey Bylokhov
In reply to this post by Semyon Sadetsky
On 9/25/17 10:34, Semyon Sadetsky wrote:
> ObjectFactory.java was missed from the webrev. It should be deleted
> actually.
> The updated webrev:
> http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.01/

Looks fine.


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8187599: Remove dependency of Building Nimbus L&F on JAXB

Phil Race
+1

-phil.

On 9/27/2017 11:21 AM, Sergey Bylokhov wrote:
> On 9/25/17 10:34, Semyon Sadetsky wrote:
>> ObjectFactory.java was missed from the webrev. It should be deleted
>> actually.
>> The updated webrev:
>> http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.01/
>
> Looks fine.
>
>