<Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Semyon Sadetsky
Hello,

Please review fix for JDK10 (the changes involve AWT and Swing):

bug: https://bugs.openjdk.java.net/browse/JDK-8188081

webrev: http://cr.openjdk.java.net/~ssadetsky/8188081/webrev.00

The 8025082 fix is reverted. Swing text selection visibility behavior is
changed according to the next rules:

- There may be only one visible selection per window.

- If the input focus moved to another window selection remains visible
or may change its color (depends on L&F).

- Selection may not be shown in the same color in several windows
simultaneously.

- Activating a popup menu does not hide the current selection.

The fix should make Swing selection visibility behaving in standard way
as in native systems UIs.

--Semyon


Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Alan Snyder-3
I’m confused about this part. Couldn’t a selection be in more than one inactive window at the same time and thus all use the inactive selection color?

  Alan

On Oct 19, 2017, at 11:36 AM, Semyon Sadetsky <[hidden email]> wrote:

- Selection may not be shown in the same color in several windows simultaneously.

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Semyon Sadetsky

Yes, an inactive selection (if it is supported by L&F) may be shown in several windows at the same time. I meant the global (active) selection which can be only one.

Also, I missed that selection may be shown only for the focused component in the window. This is reflected in the bug title also.

--Semyon

On 10/19/2017 12:10 PM, Alan Snyder wrote:
I’m confused about this part. Couldn’t a selection be in more than one inactive window at the same time and thus all use the inactive selection color?

  Alan

On Oct 19, 2017, at 11:36 AM, Semyon Sadetsky <[hidden email]> wrote:

- Selection may not be shown in the same color in several windows simultaneously.


Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Sergey Bylokhov
In reply to this post by Semyon Sadetsky
Hi, Semyon.
On 19/10/2017 11:36, Semyon Sadetsky wrote:
> The 8025082 fix is reverted. Swing text selection visibility behavior is
> changed according to the next rules:

Please recheck that the bug 8025082 is not reproducible. It was a jck
bug which should fix in one way or another.


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Semyon Sadetsky
Hi Sergey,

Actually the 8025082 was a JCK issue. It doesn't need to be fixed in JDK.

--Semyon


On 10/19/2017 05:23 PM, Sergey Bylokhov wrote:
> Hi, Semyon.
> On 19/10/2017 11:36, Semyon Sadetsky wrote:
>> The 8025082 fix is reverted. Swing text selection visibility behavior
>> is changed according to the next rules:
>
> Please recheck that the bug 8025082 is not reproducible. It was a jck
> bug which should fix in one way or another.
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Sergey Bylokhov
On 19/10/2017 21:01, Semyon Sadetsky wrote:
> Actually the 8025082 was a JCK issue. It doesn't need to be fixed in JDK.

Ok, Looks fine.

>
> --Semyon
>
>
> On 10/19/2017 05:23 PM, Sergey Bylokhov wrote:
>> Hi, Semyon.
>> On 19/10/2017 11:36, Semyon Sadetsky wrote:
>>> The 8025082 fix is reverted. Swing text selection visibility behavior
>>> is changed according to the next rules:
>>
>> Please recheck that the bug 8025082 is not reproducible. It was a jck
>> bug which should fix in one way or another.
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

prasanta sadhukhan
In reply to this post by Semyon Sadetsky
Hi Semyon,

looks good to me. BTW, Test copyright should update the year.
Since, we are reverting 8025082, shouldn't we re(clone/open) the bug and
move it to JCK project so that it does not get raised again?

Regards
Prasanta
On 10/20/2017 12:06 AM, Semyon Sadetsky wrote:

> Hello,
>
> Please review fix for JDK10 (the changes involve AWT and Swing):
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8188081
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8188081/webrev.00
>
> The 8025082 fix is reverted. Swing text selection visibility behavior
> is changed according to the next rules:
>
> - There may be only one visible selection per window.
>
> - If the input focus moved to another window selection remains visible
> or may change its color (depends on L&F).
>
> - Selection may not be shown in the same color in several windows
> simultaneously.
>
> - Activating a popup menu does not hide the current selection.
>
> The fix should make Swing selection visibility behaving in standard
> way as in native systems UIs.
>
> --Semyon
>
>

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [10] Review request for 8188081: Text selection does not clear after focus is lost

Semyon Sadetsky
Hi Prasanta,

I have created JCK-7308916. The year I will change inline, if you don't
mind.

--Semyon


On 10/23/2017 12:03 AM, Prasanta Sadhukhan wrote:

> Hi Semyon,
>
> looks good to me. BTW, Test copyright should update the year.
> Since, we are reverting 8025082, shouldn't we re(clone/open) the bug
> and move it to JCK project so that it does not get raised again?
>
> Regards
> Prasanta
> On 10/20/2017 12:06 AM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK10 (the changes involve AWT and Swing):
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8188081
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8188081/webrev.00
>>
>> The 8025082 fix is reverted. Swing text selection visibility behavior
>> is changed according to the next rules:
>>
>> - There may be only one visible selection per window.
>>
>> - If the input focus moved to another window selection remains
>> visible or may change its color (depends on L&F).
>>
>> - Selection may not be shown in the same color in several windows
>> simultaneously.
>>
>> - Activating a popup menu does not hide the current selection.
>>
>> The fix should make Swing selection visibility behaving in standard
>> way as in native systems UIs.
>>
>> --Semyon
>>
>>
>