Quantcast

<Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Avik Niyogi
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

prasanta sadhukhan

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Avik Niyogi
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Alexandr Scherbatiy
On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Avik Niyogi
In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy <[hidden email]> wrote:

On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi




Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Avik Niyogi
A gentle reminder, please review the code changes made.

With Regards,
Avik Niyogi

On 12-Jan-2017, at 10:02 am, Avik Niyogi <[hidden email]> wrote:

In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy <[hidden email]> wrote:

On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi





Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Sergey Bylokhov
In reply to this post by Avik Niyogi
Hi, Avik.

In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it.

Can you please clarify what bug was fixed in nimbus which was confirmed by you.


With Regards,
Avik Niyogi
On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy <[hidden email]> wrote:

On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi





Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Avik Niyogi

On 17-Jan-2017, at 9:23 pm, Sergey Bylokhov <[hidden email]> wrote:

Hi, Avik.

In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it.

Can you please clarify what bug was fixed in nimbus which was confirmed by you.
HI Sergey,
It was not a bug fixed in Nimbus, it was a test case fixed to include Nimbus behaviour along with Aqua LAF as mentioned by you in the review for bug ID: 8167160
 Please find the copied content of the mail chain for that bug ID below:


+1


On 11/23/2016 7:52 PM, Sergey Bylokhov wrote:
On 22.11.16 8:49, Avik Niyogi wrote:
Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below:
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/
Change note: Instead of rethrow of a RuntimeException, used
printStackTrace()

+1


With Regards,
Avik Niyogi

On 22-Nov-2016, at 4:01 am, Sergey Bylokhov
<[hidden email] <[hidden email]>> wrote:

Hi, Avik.
Is it necessary to use logging in the test?
I guess that this code
Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, ex);
can be replaced by rethrow a RuntimeException exception?

On 17.11.16 13:45, Avik Niyogi wrote:
Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/
With Regards,
Avik Niyogi


On 14-Nov-2016, at 9:03 pm, Avik Niyogi <[hidden email]
<[hidden email]>
<[hidden email]>> wrote:

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
but for default settings on mac it is not working.

On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 14.11.16 17:18, Avik Niyogi wrote:
I checked with MetalLAF as well. does not seem to work. also, tried
with a native Mac app. Does not have any option for radio button
focus traversal.

Can you please clarify how you set the L&F for this test? I also
checked it and the test passed on the current jdk9-client in case of
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"


On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 14.11.16 6:43, Avik Niyogi wrote:
This is OS X Specific.

Are you sure? I guess the test will pass if will be run using
MetalLookAndFeel.

On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 10.11.16 9:53, Avik Niyogi wrote:
Arrow buttons for traversing a radio button group is not the
expected OS X behaviour.

This behavior is OSX specific or it is related to the Aqua L&F
which is default on OSX?

In OS X in default OS X apps, for radio button focus traversing
to work, custom actions must be set using System Preferences.
On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov
<[hidden email] <[hidden email]>
<[hidden email]>> wrote:

On 09.11.16 11:06, Avik Niyogi wrote:
*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should
work for
windows and Linux

What is the reason why the test does not work on OSX?


-- 
Best regards, Sergey.



-- 
Best regards, Sergey.



-- 
Best regards, Sergey.



-- 
Best regards, Sergey.




-- 
Best regards, Sergey.




With Regards,
Avik Niyogi
On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy <[hidden email]> wrote:

On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi






Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Sergey Bylokhov

17 янв. 2017 г., в 23:44, Avik Niyogi <[hidden email]> написал(а):


On 17-Jan-2017, at 9:23 pm, Sergey Bylokhov <[hidden email]> wrote:

Hi, Avik.

In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it.

Can you please clarify what bug was fixed in nimbus which was confirmed by you.
HI Sergey,
It was not a bug fixed in Nimbus, it was a test case fixed to include Nimbus behaviour along with Aqua LAF as mentioned by you in the review for bug ID: 8167160
 Please find the copied content of the mail chain for that bug ID below:

Thanks. looks fine.



+1


On 11/23/2016 7:52 PM, Sergey Bylokhov wrote:
On 22.11.16 8:49, Avik Niyogi wrote:
Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below:
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/
Change note: Instead of rethrow of a RuntimeException, used
printStackTrace()

+1


With Regards,
Avik Niyogi

On 22-Nov-2016, at 4:01 am, Sergey Bylokhov
<[hidden email] <[hidden email]>> wrote:

Hi, Avik.
Is it necessary to use logging in the test?
I guess that this code
Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, ex);
can be replaced by rethrow a RuntimeException exception?

On 17.11.16 13:45, Avik Niyogi wrote:
Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/
With Regards,
Avik Niyogi


On 14-Nov-2016, at 9:03 pm, Avik Niyogi <[hidden email]
<[hidden email]>
<[hidden email]>> wrote:

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
but for default settings on mac it is not working.

On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 14.11.16 17:18, Avik Niyogi wrote:
I checked with MetalLAF as well. does not seem to work. also, tried
with a native Mac app. Does not have any option for radio button
focus traversal.

Can you please clarify how you set the L&F for this test? I also
checked it and the test passed on the current jdk9-client in case of
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"


On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 14.11.16 6:43, Avik Niyogi wrote:
This is OS X Specific.

Are you sure? I guess the test will pass if will be run using
MetalLookAndFeel.

On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 10.11.16 9:53, Avik Niyogi wrote:
Arrow buttons for traversing a radio button group is not the
expected OS X behaviour.

This behavior is OSX specific or it is related to the Aqua L&F
which is default on OSX?

In OS X in default OS X apps, for radio button focus traversing
to work, custom actions must be set using System Preferences.
On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov
<[hidden email] <[hidden email]>
<[hidden email]>> wrote:

On 09.11.16 11:06, Avik Niyogi wrote:
*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should
work for
windows and Linux

What is the reason why the test does not work on OSX?


-- 
Best regards, Sergey.



-- 
Best regards, Sergey.



-- 
Best regards, Sergey.



-- 
Best regards, Sergey.




-- 
Best regards, Sergey.




With Regards,
Avik Niyogi
On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy <[hidden email]> wrote:

On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi







Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Alexandr Scherbatiy
The fix looks good to me.

Thanks,
Alexandr.

On 1/18/2017 8:39 PM, Sergey Bylokhov wrote:

17 янв. 2017 г., в 23:44, Avik Niyogi <[hidden email]> написал(а):


On 17-Jan-2017, at 9:23 pm, Sergey Bylokhov <[hidden email]> wrote:

Hi, Avik.

In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it.

Can you please clarify what bug was fixed in nimbus which was confirmed by you.
HI Sergey,
It was not a bug fixed in Nimbus, it was a test case fixed to include Nimbus behaviour along with Aqua LAF as mentioned by you in the review for bug ID: 8167160
 Please find the copied content of the mail chain for that bug ID below:

Thanks. looks fine.



+1


On 11/23/2016 7:52 PM, Sergey Bylokhov wrote:
On 22.11.16 8:49, Avik Niyogi wrote:
Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below:
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/
Change note: Instead of rethrow of a RuntimeException, used
printStackTrace()

+1


With Regards,
Avik Niyogi

On 22-Nov-2016, at 4:01 am, Sergey Bylokhov
<[hidden email] <[hidden email]>> wrote:

Hi, Avik.
Is it necessary to use logging in the test?
I guess that this code
Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, ex);
can be replaced by rethrow a RuntimeException exception?

On 17.11.16 13:45, Avik Niyogi wrote:
Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/
With Regards,
Avik Niyogi


On 14-Nov-2016, at 9:03 pm, Avik Niyogi <[hidden email]
<[hidden email]>
<[hidden email]>> wrote:

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
but for default settings on mac it is not working.

On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 14.11.16 17:18, Avik Niyogi wrote:
I checked with MetalLAF as well. does not seem to work. also, tried
with a native Mac app. Does not have any option for radio button
focus traversal.

Can you please clarify how you set the L&F for this test? I also
checked it and the test passed on the current jdk9-client in case of
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"


On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 14.11.16 6:43, Avik Niyogi wrote:
This is OS X Specific.

Are you sure? I guess the test will pass if will be run using
MetalLookAndFeel.

On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
<[hidden email]
<[hidden email]> <[hidden email]>>
wrote:

On 10.11.16 9:53, Avik Niyogi wrote:
Arrow buttons for traversing a radio button group is not the
expected OS X behaviour.

This behavior is OSX specific or it is related to the Aqua L&F
which is default on OSX?

In OS X in default OS X apps, for radio button focus traversing
to work, custom actions must be set using System Preferences.
On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov
<[hidden email] <[hidden email]>
<[hidden email]>> wrote:

On 09.11.16 11:06, Avik Niyogi wrote:
*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should
work for
windows and Linux

What is the reason why the test does not work on OSX?


-- 
Best regards, Sergey.



-- 
Best regards, Sergey.



-- 
Best regards, Sergey.



-- 
Best regards, Sergey.




-- 
Best regards, Sergey.




With Regards,
Avik Niyogi
On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy <[hidden email]> wrote:

On 1/11/2017 2:01 PM, Avik Niyogi wrote:
Hi All,
I have addressed the inputs received in the following update. Please review the same for JDK 9.

With Regards,
Avik Niyogi
On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan <[hidden email]> wrote:

I guess we need to throw the exception if changing LaF fails instead of silently consuming it!!

Regards
Prasanta
On 1/11/2017 2:16 PM, Avik Niyogi wrote:
Hi All,

Kindly review the proposed fix for JDK9.



Issue: The focus traversal policy being tested was incorrect

Cause: For Aqua and Nimbus, the focus traversal policy used is different and as this is tested on default LAF, it fails on Mac OS X
  Could you give more details what are the differences between using the focus traversal policy in Metal, Nimbus and Aqua L&F?

  Thanks,
  Alexandr.

Fix: Cross-platform (Metal) LAF is used in case the default LAF is either Aqua or Nimbus and the focus traversal works in those cases.

With Regards,
Avik Niyogi








Loading...