Quantcast

<Swing Dev> [9] RFR JDK-8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] RFR JDK-8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java

prasanta sadhukhan
Hi All,

Please review a testbug fix where although the test description mention
about keyboard garbage, but I was getting NPE in windows7.
Bug: https://bugs.openjdk.java.net/browse/JDK-8039888
webrev: http://cr.openjdk.java.net/~psadhukhan/8039888/webrev.00/

NPE was caused by the  fact that onject was used before instantiation.
Fixed the NPE.

Regards
Prasanta
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] RFR JDK-8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java

Sergey Bylokhov
Looks fine.

>
> Hi All,
>
> Please review a testbug fix where although the test description mention about keyboard garbage, but I was getting NPE in windows7.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8039888
> webrev: http://cr.openjdk.java.net/~psadhukhan/8039888/webrev.00/
>
> NPE was caused by the  fact that onject was used before instantiation. Fixed the NPE.
>
> Regards
> Prasanta

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] RFR JDK-8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java

Alexandr Scherbatiy

   The fix looks good to me.

   Thanks,
   Alexandr.

On 2/24/2017 6:02 PM, Sergey Bylokhov wrote:

> Looks fine.
>
>> Hi All,
>>
>> Please review a testbug fix where although the test description mention about keyboard garbage, but I was getting NPE in windows7.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8039888
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8039888/webrev.00/
>>
>> NPE was caused by the  fact that onject was used before instantiation. Fixed the NPE.
>>
>> Regards
>> Prasanta

Loading...