Quantcast

<Swing Dev> [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

prasanta sadhukhan
Hi All,

Please review the name change for this regression test which was causing
jtreg to fail as it was not finding the test.

Bug: https://bugs.openjdk.java.net/browse/JDK-8172558

Filename was javax/swing/JTable/8133919/DrawGridLInesTest.java [whith
capital I]

but test has jtreg tag @run main DrawGridLinesTest

Fix is to rename the test to correct name.

webrev: http://cr.openjdk.java.net/~psadhukhan/8172558/webrev.00/

Regards
Prasanta
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

Yuri Nesterenko
It's fine and necessary fix but it should be done in the integration
repository, not in client. Otherwise, the bug would stay in master for
2 next builds and prevent jtreg starting at all.

+1

-yan

On 01/12/2017 10:04 AM, Prasanta Sadhukhan wrote:

> Hi All,
>
> Please review the name change for this regression test which was causing
> jtreg to fail as it was not finding the test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8172558
>
> Filename was javax/swing/JTable/8133919/DrawGridLInesTest.java [whith
> capital I]
>
> but test has jtreg tag @run main DrawGridLinesTest
>
> Fix is to rename the test to correct name.
>
> webrev: http://cr.openjdk.java.net/~psadhukhan/8172558/webrev.00/
>
> Regards
> Prasanta

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

Alexandr Scherbatiy
In reply to this post by prasanta sadhukhan
The fix looks good to me.

Thanks,
Alexandr.

On 1/12/2017 10:04 AM, Prasanta Sadhukhan wrote:

> Hi All,
>
> Please review the name change for this regression test which was
> causing jtreg to fail as it was not finding the test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8172558
>
> Filename was javax/swing/JTable/8133919/DrawGridLInesTest.java [whith
> capital I]
>
> but test has jtreg tag @run main DrawGridLinesTest
>
> Fix is to rename the test to correct name.
>
> webrev: http://cr.openjdk.java.net/~psadhukhan/8172558/webrev.00/
>
> Regards
> Prasanta

Loading...