<Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

mikhail cherkasov
Hello,

Could you please review the fix for jdk9?

AccessBridge works in separate thread,so if we modify JList model, 
AccessBridge can request information about removed AccessibleJListChild or element
that changed position, so this can lead to NPE.
Almost all methods of AccessibleJListChild has checks for null, exception 
those three where I added those checks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8076249
Webrev: http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev/

Thanks,
Mikhail. 


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

Philip Race
Looks good to me.

-phil.

On 4/12/17, 10:04 AM, Mikhail Cherkasov wrote:
Hello,

Could you please review the fix for jdk9?

AccessBridge works in separate thread,so if we modify JList model, 
AccessBridge can request information about removed AccessibleJListChild or element
that changed position, so this can lead to NPE.
Almost all methods of AccessibleJListChild has checks for null, exception 
those three where I added those checks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8076249
Webrev: http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev/

Thanks,
Mikhail. 


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

Sergey Bylokhov
In reply to this post by mikhail cherkasov
Hi, Mikhail.
Is it possible to write a test for this issue? I guess it is possible to force NPE even without AccessBridge.
Hello,

Could you please review the fix for jdk9?

AccessBridge works in separate thread,so if we modify JList model, 
AccessBridge can request information about removed AccessibleJListChild or element
that changed position, so this can lead to NPE.
Almost all methods of AccessibleJListChild has checks for null, exception 
those three where I added those checks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8076249
Webrev: http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev/

Thanks,
Mikhail. 



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

mikhail cherkasov
Hi Sergey,

Right, a test case can be written without use of JAWS or other screen readers.
Please find a new webrev with the test there:
http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.01/

Thanks,
Mikhail.

On 4/12/2017 9:19 PM, Sergey Bylokhov wrote:
Hi, Mikhail.
Is it possible to write a test for this issue? I guess it is possible to force NPE even without AccessBridge.
Hello,

Could you please review the fix for jdk9?

AccessBridge works in separate thread,so if we modify JList model, 
AccessBridge can request information about removed AccessibleJListChild or element
that changed position, so this can lead to NPE.
Almost all methods of AccessibleJListChild has checks for null, exception 
those three where I added those checks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8076249
Webrev: http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev/

Thanks,
Mikhail. 




Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

Philip Race

Minor nit, a wildcard import in the test :-
  31 import javax.swing.*;

-phil

On 04/13/2017 06:16 AM, Mikhail Cherkasov wrote:
Hi Sergey,

Right, a test case can be written without use of JAWS or other screen readers.
Please find a new webrev with the test there:
http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.01/

Thanks,
Mikhail.

On 4/12/2017 9:19 PM, Sergey Bylokhov wrote:
Hi, Mikhail.
Is it possible to write a test for this issue? I guess it is possible to force NPE even without AccessBridge.
Hello,

Could you please review the fix for jdk9?

AccessBridge works in separate thread,so if we modify JList model, 
AccessBridge can request information about removed AccessibleJListChild or element
that changed position, so this can lead to NPE.
Almost all methods of AccessibleJListChild has checks for null, exception 
those three where I added those checks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8076249
Webrev: http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev/

Thanks,
Mikhail. 





Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

mikhail cherkasov
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

Alexandr Scherbatiy

The fix looks good to me.

Thanks,
Alexandr.

On 4/13/2017 6:57 PM, Mikhail Cherkasov wrote:
>
>
> On 4/13/2017 6:31 PM, Phil Race wrote:
>>    31 import javax.swing.*;
> Fixed:
> http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.02/test/javax/accessibility/JList/AccessibleJListChildNPETest.java.html

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

Sergey Bylokhov
In reply to this post by mikhail cherkasov
+1

----- [hidden email] wrote:

> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 4/13/2017 6:57 PM, Mikhail Cherkasov wrote:
> >
> >
> > On 4/13/2017 6:31 PM, Phil Race wrote:
> >>    31 import javax.swing.*;
> > Fixed:
> >
> http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.02/test/javax/accessibility/JList/AccessibleJListChildNPETest.java.html
Loading...