<Swing Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
Hello.

Please review the fix for jdk9.

This is request to deprecate the obsolete flags inside InputEvent. This
constants were marked as obsolete in jdk1.4 and were replaced by the new
one. In jdk1.4 the documentation were update with notion that the new
constants should be used. And this bug is about official deprecation of
them.

We can replace old constants by the new one in the whole jdk, but I
updated only the code in InputEvent to make change smaller and safer. So
at least the new code in jdk and the code in applications will start to
use the new constants.

The changes in jconsole are necessary to fix deprecation warning.

jprt build passed, no new issues were found by jck/jtreg tests.


Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
Webrev can be found at: http://cr.openjdk.java.net/~serb/8143077/webrev.00

--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Mandy Chung
The jconsole change looks fine.  I’m including serviceability-dev and bcc core-libs-dev as serviceability-dev is the right mailing list for jconsole change.

Mandy

> On Sep 30, 2016, at 8:45 AM, Sergey Bylokhov <[hidden email]> wrote:
>
> Hello.
>
> Please review the fix for jdk9.
>
> This is request to deprecate the obsolete flags inside InputEvent. This constants were marked as obsolete in jdk1.4 and were replaced by the new one. In jdk1.4 the documentation were update with notion that the new constants should be used. And this bug is about official deprecation of them.
>
> We can replace old constants by the new one in the whole jdk, but I updated only the code in InputEvent to make change smaller and safer. So at least the new code in jdk and the code in applications will start to use the new constants.
>
> The changes in jconsole are necessary to fix deprecation warning.
>
> jprt build passed, no new issues were found by jck/jtreg tests.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8143077/webrev.00
>
> --
> Best regards, Sergey.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Jonathan Bluett-Duncan
In reply to this post by Sergey Bylokhov
Hi Sergey,

I'm not a reviewer, but after reading the deprecation messages in Event.java

* @deprecated It is recommended that {@code AWTEvent} class and its subclasses
*             be used instead.

I get the impression they would read better without the redundant "class" in the middle, like so.

* @deprecated It is recommended that {@code AWTEvent} and its subclasses
*             be used instead.

Kind regards,
Jonathan 


On 30 September 2016 at 16:45, Sergey Bylokhov <[hidden email]> wrote:
Hello.

Please review the fix for jdk9.

This is request to deprecate the obsolete flags inside InputEvent. This constants were marked as obsolete in jdk1.4 and were replaced by the new one. In jdk1.4 the documentation were update with notion that the new constants should be used. And this bug is about official deprecation of them.

We can replace old constants by the new one in the whole jdk, but I updated only the code in InputEvent to make change smaller and safer. So at least the new code in jdk and the code in applications will start to use the new constants.

The changes in jconsole are necessary to fix deprecation warning.

jprt build passed, no new issues were found by jck/jtreg tests.


Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
Webrev can be found at: http://cr.openjdk.java.net/~serb/8143077/webrev.00

--
Best regards, Sergey.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Erik Gahlin
In reply to this post by Mandy Chung
Looks good.

Erik

> On Sep 30, 2016, at 8:45 AM, Sergey Bylokhov <[hidden email]> wrote:
>
> Hello.
>
> Please review the fix for jdk9.
>
> This is request to deprecate the obsolete flags inside InputEvent. This constants were marked as obsolete in jdk1.4 and were replaced by the new one. In jdk1.4 the documentation were update with notion that the new constants should be used. And this bug is about official deprecation of them.
>
> We can replace old constants by the new one in the whole jdk, but I updated only the code in InputEvent to make change smaller and safer. So at least the new code in jdk and the code in applications will start to use the new constants.
>
> The changes in jconsole are necessary to fix deprecation warning.
>
> jprt build passed, no new issues were found by jck/jtreg tests.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8143077/webrev.00
>
> --
> Best regards, Sergey.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
In reply to this post by Jonathan Bluett-Duncan
Thanks for the comments.
The new version:
http://cr.openjdk.java.net/~serb/8143077/webrev.01
The specification of Event class and InputEvent.getModifiers() are updated.

On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:

> Hi Sergey,
>
> I'm not a reviewer, but after reading the deprecation messages in Event.java
>
>     * @deprecated It is recommended that {@code AWTEvent} class and its
>     subclasses
>     *             be used instead.
>
>
> I get the impression they would read better without the redundant
> "class" in the middle, like so.
>
>     * @deprecated It is recommended that {@code AWTEvent} and its subclasses
>     *             be used instead.
>
>
> Kind regards,
> Jonathan
>
>
> On 30 September 2016 at 16:45, Sergey Bylokhov
> <[hidden email] <mailto:[hidden email]>> wrote:
>
>     Hello.
>
>     Please review the fix for jdk9.
>
>     This is request to deprecate the obsolete flags inside InputEvent.
>     This constants were marked as obsolete in jdk1.4 and were replaced
>     by the new one. In jdk1.4 the documentation were update with notion
>     that the new constants should be used. And this bug is about
>     official deprecation of them.
>
>     We can replace old constants by the new one in the whole jdk, but I
>     updated only the code in InputEvent to make change smaller and
>     safer. So at least the new code in jdk and the code in applications
>     will start to use the new constants.
>
>     The changes in jconsole are necessary to fix deprecation warning.
>
>     jprt build passed, no new issues were found by jck/jtreg tests.
>
>
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>     Webrev can be found at:
>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>     <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>
>     --
>     Best regards, Sergey.
>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky
Hi Sergey,

After applying the patch I found 72 usages of the Event class. Why they
are not replaced?

--Semyon


On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:

> Thanks for the comments.
> The new version:
> http://cr.openjdk.java.net/~serb/8143077/webrev.01
> The specification of Event class and InputEvent.getModifiers() are
> updated.
>
> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>> Hi Sergey,
>>
>> I'm not a reviewer, but after reading the deprecation messages in
>> Event.java
>>
>>     * @deprecated It is recommended that {@code AWTEvent} class and its
>>     subclasses
>>     *             be used instead.
>>
>>
>> I get the impression they would read better without the redundant
>> "class" in the middle, like so.
>>
>>     * @deprecated It is recommended that {@code AWTEvent} and its
>> subclasses
>>     *             be used instead.
>>
>>
>> Kind regards,
>> Jonathan
>>
>>
>> On 30 September 2016 at 16:45, Sergey Bylokhov
>> <[hidden email] <mailto:[hidden email]>> wrote:
>>
>>     Hello.
>>
>>     Please review the fix for jdk9.
>>
>>     This is request to deprecate the obsolete flags inside InputEvent.
>>     This constants were marked as obsolete in jdk1.4 and were replaced
>>     by the new one. In jdk1.4 the documentation were update with notion
>>     that the new constants should be used. And this bug is about
>>     official deprecation of them.
>>
>>     We can replace old constants by the new one in the whole jdk, but I
>>     updated only the code in InputEvent to make change smaller and
>>     safer. So at least the new code in jdk and the code in applications
>>     will start to use the new constants.
>>
>>     The changes in jconsole are necessary to fix deprecation warning.
>>
>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>
>>
>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>     Webrev can be found at:
>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>     <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>
>>     --
>>     Best regards, Sergey.
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 07.10.16 10:06, Semyon Sadetsky wrote:
> Hi Sergey,
>
> After applying the patch I found 72 usages of the Event class. Why they
> are not replaced?

By the same reason why InputEvent.getModifiers() was not replaced by
InputEvent.getModifiersEx():

 >>>     We can replace old constants by the new one in the whole jdk, but I
 >>>     updated only the code in InputEvent to make change smaller and
 >>>     safer. So at least the new code in jdk and the code in applications
 >>>     will start to use the new constants.


> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>> Thanks for the comments.
>> The new version:
>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>> The specification of Event class and InputEvent.getModifiers() are
>> updated.
>>
>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>> Hi Sergey,
>>>
>>> I'm not a reviewer, but after reading the deprecation messages in
>>> Event.java
>>>
>>>     * @deprecated It is recommended that {@code AWTEvent} class and its
>>>     subclasses
>>>     *             be used instead.
>>>
>>>
>>> I get the impression they would read better without the redundant
>>> "class" in the middle, like so.
>>>
>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>> subclasses
>>>     *             be used instead.
>>>
>>>
>>> Kind regards,
>>> Jonathan
>>>
>>>
>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>> <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>>     Hello.
>>>
>>>     Please review the fix for jdk9.
>>>
>>>     This is request to deprecate the obsolete flags inside InputEvent.
>>>     This constants were marked as obsolete in jdk1.4 and were replaced
>>>     by the new one. In jdk1.4 the documentation were update with notion
>>>     that the new constants should be used. And this bug is about
>>>     official deprecation of them.
>>>
>>>     We can replace old constants by the new one in the whole jdk, but I
>>>     updated only the code in InputEvent to make change smaller and
>>>     safer. So at least the new code in jdk and the code in applications
>>>     will start to use the new constants.
>>>
>>>     The changes in jconsole are necessary to fix deprecation warning.
>>>
>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>
>>>
>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>     Webrev can be found at:
>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>     <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>
>>>     --
>>>     Best regards, Sergey.
>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Alexander Zvegintsev
Looks good.


On 10/7/16 4:21 PM, Sergey Bylokhov wrote:

> On 07.10.16 10:06, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> After applying the patch I found 72 usages of the Event class. Why they
>> are not replaced?
>
> By the same reason why InputEvent.getModifiers() was not replaced by
> InputEvent.getModifiersEx():
>
> >>>     We can replace old constants by the new one in the whole jdk,
> but I
> >>>     updated only the code in InputEvent to make change smaller and
> >>>     safer. So at least the new code in jdk and the code in
> applications
> >>>     will start to use the new constants.
>
>
>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>> Thanks for the comments.
>>> The new version:
>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>> The specification of Event class and InputEvent.getModifiers() are
>>> updated.
>>>
>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>> Hi Sergey,
>>>>
>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>> Event.java
>>>>
>>>>     * @deprecated It is recommended that {@code AWTEvent} class and
>>>> its
>>>>     subclasses
>>>>     *             be used instead.
>>>>
>>>>
>>>> I get the impression they would read better without the redundant
>>>> "class" in the middle, like so.
>>>>
>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>> subclasses
>>>>     *             be used instead.
>>>>
>>>>
>>>> Kind regards,
>>>> Jonathan
>>>>
>>>>
>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>> <[hidden email] <mailto:[hidden email]>>
>>>> wrote:
>>>>
>>>>     Hello.
>>>>
>>>>     Please review the fix for jdk9.
>>>>
>>>>     This is request to deprecate the obsolete flags inside InputEvent.
>>>>     This constants were marked as obsolete in jdk1.4 and were replaced
>>>>     by the new one. In jdk1.4 the documentation were update with
>>>> notion
>>>>     that the new constants should be used. And this bug is about
>>>>     official deprecation of them.
>>>>
>>>>     We can replace old constants by the new one in the whole jdk,
>>>> but I
>>>>     updated only the code in InputEvent to make change smaller and
>>>>     safer. So at least the new code in jdk and the code in
>>>> applications
>>>>     will start to use the new constants.
>>>>
>>>>     The changes in jconsole are necessary to fix deprecation warning.
>>>>
>>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>>
>>>>
>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>     Webrev can be found at:
>>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>
>>>>     --
>>>>     Best regards, Sergey.
>>>>
>>>>
>>>
>>>
>>
>
>

--
Thanks,
Alexander.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky
In reply to this post by Sergey Bylokhov
On 10/7/2016 4:21 PM, Sergey Bylokhov wrote:

> On 07.10.16 10:06, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> After applying the patch I found 72 usages of the Event class. Why they
>> are not replaced?
>
> By the same reason why InputEvent.getModifiers() was not replaced by
> InputEvent.getModifiersEx():
>
> >>>     We can replace old constants by the new one in the whole jdk,
> but I
> >>>     updated only the code in InputEvent to make change smaller and
> >>>     safer. So at least the new code in jdk and the code in
> applications
> >>>     will start to use the new constants.
But I didn't get why it is risky? Usually find&replace works reliably.

--Semyon

>
>
>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>> Thanks for the comments.
>>> The new version:
>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>> The specification of Event class and InputEvent.getModifiers() are
>>> updated.
>>>
>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>> Hi Sergey,
>>>>
>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>> Event.java
>>>>
>>>>     * @deprecated It is recommended that {@code AWTEvent} class and
>>>> its
>>>>     subclasses
>>>>     *             be used instead.
>>>>
>>>>
>>>> I get the impression they would read better without the redundant
>>>> "class" in the middle, like so.
>>>>
>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>> subclasses
>>>>     *             be used instead.
>>>>
>>>>
>>>> Kind regards,
>>>> Jonathan
>>>>
>>>>
>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>> <[hidden email] <mailto:[hidden email]>>
>>>> wrote:
>>>>
>>>>     Hello.
>>>>
>>>>     Please review the fix for jdk9.
>>>>
>>>>     This is request to deprecate the obsolete flags inside InputEvent.
>>>>     This constants were marked as obsolete in jdk1.4 and were replaced
>>>>     by the new one. In jdk1.4 the documentation were update with
>>>> notion
>>>>     that the new constants should be used. And this bug is about
>>>>     official deprecation of them.
>>>>
>>>>     We can replace old constants by the new one in the whole jdk,
>>>> but I
>>>>     updated only the code in InputEvent to make change smaller and
>>>>     safer. So at least the new code in jdk and the code in
>>>> applications
>>>>     will start to use the new constants.
>>>>
>>>>     The changes in jconsole are necessary to fix deprecation warning.
>>>>
>>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>>
>>>>
>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>     Webrev can be found at:
>>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>
>>>>     --
>>>>     Best regards, Sergey.
>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 17.10.16 15:16, Semyon Sadetsky wrote:
>> >>>     We can replace old constants by the new one in the whole jdk,
>> but I
>> >>>     updated only the code in InputEvent to make change smaller and
>> >>>     safer. So at least the new code in jdk and the code in
>> applications
>> >>>     will start to use the new constants.
> But I didn't get why it is risky? Usually find&replace works reliably.

Because they works differently(this is why the second getModifiersEx was
added) and some code can rely on the behavior of getModifiers().

>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>> Thanks for the comments.
>>>> The new version:
>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>> The specification of Event class and InputEvent.getModifiers() are
>>>> updated.
>>>>
>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>> Hi Sergey,
>>>>>
>>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>>> Event.java
>>>>>
>>>>>     * @deprecated It is recommended that {@code AWTEvent} class and
>>>>> its
>>>>>     subclasses
>>>>>     *             be used instead.
>>>>>
>>>>>
>>>>> I get the impression they would read better without the redundant
>>>>> "class" in the middle, like so.
>>>>>
>>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>>> subclasses
>>>>>     *             be used instead.
>>>>>
>>>>>
>>>>> Kind regards,
>>>>> Jonathan
>>>>>
>>>>>
>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>> wrote:
>>>>>
>>>>>     Hello.
>>>>>
>>>>>     Please review the fix for jdk9.
>>>>>
>>>>>     This is request to deprecate the obsolete flags inside InputEvent.
>>>>>     This constants were marked as obsolete in jdk1.4 and were replaced
>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>> notion
>>>>>     that the new constants should be used. And this bug is about
>>>>>     official deprecation of them.
>>>>>
>>>>>     We can replace old constants by the new one in the whole jdk,
>>>>> but I
>>>>>     updated only the code in InputEvent to make change smaller and
>>>>>     safer. So at least the new code in jdk and the code in
>>>>> applications
>>>>>     will start to use the new constants.
>>>>>
>>>>>     The changes in jconsole are necessary to fix deprecation warning.
>>>>>
>>>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>>>
>>>>>
>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>     Webrev can be found at:
>>>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>
>>>>>     --
>>>>>     Best regards, Sergey.
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky


On 17.10.2016 17:19, Sergey Bylokhov wrote:

> On 17.10.16 15:16, Semyon Sadetsky wrote:
>>> >>>     We can replace old constants by the new one in the whole jdk,
>>> but I
>>> >>>     updated only the code in InputEvent to make change smaller and
>>> >>>     safer. So at least the new code in jdk and the code in
>>> applications
>>> >>>     will start to use the new constants.
>> But I didn't get why it is risky? Usually find&replace works reliably.
>
> Because they works differently(this is why the second getModifiersEx
> was added) and some code can rely on the behavior of getModifiers().
At least usages of Event.*_MASK could be safely replaced with
InputEvent.*_DOWN_MASK.
And, please, limit the length of the changed line in VMPanel.java to 80
chars.

>
>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>> Thanks for the comments.
>>>>> The new version:
>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>> The specification of Event class and InputEvent.getModifiers() are
>>>>> updated.
>>>>>
>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>> Hi Sergey,
>>>>>>
>>>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>>>> Event.java
>>>>>>
>>>>>>     * @deprecated It is recommended that {@code AWTEvent} class and
>>>>>> its
>>>>>>     subclasses
>>>>>>     *             be used instead.
>>>>>>
>>>>>>
>>>>>> I get the impression they would read better without the redundant
>>>>>> "class" in the middle, like so.
>>>>>>
>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>>>> subclasses
>>>>>>     *             be used instead.
>>>>>>
>>>>>>
>>>>>> Kind regards,
>>>>>> Jonathan
>>>>>>
>>>>>>
>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>>> wrote:
>>>>>>
>>>>>>     Hello.
>>>>>>
>>>>>>     Please review the fix for jdk9.
>>>>>>
>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>> InputEvent.
>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>> replaced
>>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>>> notion
>>>>>>     that the new constants should be used. And this bug is about
>>>>>>     official deprecation of them.
>>>>>>
>>>>>>     We can replace old constants by the new one in the whole jdk,
>>>>>> but I
>>>>>>     updated only the code in InputEvent to make change smaller and
>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>> applications
>>>>>>     will start to use the new constants.
>>>>>>
>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>> warning.
>>>>>>
>>>>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>>>>
>>>>>>
>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>     Webrev can be found at:
>>>>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>
>>>>>>     --
>>>>>>     Best regards, Sergey.
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 17.10.16 17:39, Semyon Sadetsky wrote:

>
>
> On 17.10.2016 17:19, Sergey Bylokhov wrote:
>> On 17.10.16 15:16, Semyon Sadetsky wrote:
>>>> >>>     We can replace old constants by the new one in the whole jdk,
>>>> but I
>>>> >>>     updated only the code in InputEvent to make change smaller and
>>>> >>>     safer. So at least the new code in jdk and the code in
>>>> applications
>>>> >>>     will start to use the new constants.
>>> But I didn't get why it is risky? Usually find&replace works reliably.
>>
>> Because they works differently(this is why the second getModifiersEx
>> was added) and some code can rely on the behavior of getModifiers().
> At least usages of Event.*_MASK could be safely replaced with
> InputEvent.*_DOWN_MASK.

How it could be safe? both are a different constants which should be
used in pair with different methods?

> And, please, limit the length of the changed line in VMPanel.java to 80
> chars.
>>
>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>> Thanks for the comments.
>>>>>> The new version:
>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>> The specification of Event class and InputEvent.getModifiers() are
>>>>>> updated.
>>>>>>
>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>> Hi Sergey,
>>>>>>>
>>>>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>>>>> Event.java
>>>>>>>
>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} class and
>>>>>>> its
>>>>>>>     subclasses
>>>>>>>     *             be used instead.
>>>>>>>
>>>>>>>
>>>>>>> I get the impression they would read better without the redundant
>>>>>>> "class" in the middle, like so.
>>>>>>>
>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>>>>> subclasses
>>>>>>>     *             be used instead.
>>>>>>>
>>>>>>>
>>>>>>> Kind regards,
>>>>>>> Jonathan
>>>>>>>
>>>>>>>
>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>     Hello.
>>>>>>>
>>>>>>>     Please review the fix for jdk9.
>>>>>>>
>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>> InputEvent.
>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>> replaced
>>>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>>>> notion
>>>>>>>     that the new constants should be used. And this bug is about
>>>>>>>     official deprecation of them.
>>>>>>>
>>>>>>>     We can replace old constants by the new one in the whole jdk,
>>>>>>> but I
>>>>>>>     updated only the code in InputEvent to make change smaller and
>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>> applications
>>>>>>>     will start to use the new constants.
>>>>>>>
>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>> warning.
>>>>>>>
>>>>>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>>>>>
>>>>>>>
>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>     Webrev can be found at:
>>>>>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>
>>>>>>>     --
>>>>>>>     Best regards, Sergey.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky


On 17.10.2016 18:37, Sergey Bylokhov wrote:

> On 17.10.16 17:39, Semyon Sadetsky wrote:
>>
>>
>> On 17.10.2016 17:19, Sergey Bylokhov wrote:
>>> On 17.10.16 15:16, Semyon Sadetsky wrote:
>>>>> >>>     We can replace old constants by the new one in the whole jdk,
>>>>> but I
>>>>> >>>     updated only the code in InputEvent to make change smaller
>>>>> and
>>>>> >>>     safer. So at least the new code in jdk and the code in
>>>>> applications
>>>>> >>>     will start to use the new constants.
>>>> But I didn't get why it is risky? Usually find&replace works reliably.
>>>
>>> Because they works differently(this is why the second getModifiersEx
>>> was added) and some code can rely on the behavior of getModifiers().
>> At least usages of Event.*_MASK could be safely replaced with
>> InputEvent.*_DOWN_MASK.
>
> How it could be safe? both are a different constants which should be
> used in pair with different methods?
Then why do you add in java doc for those constants:
  @deprecated It is recommended that *_DOWN_MASK be used instead
?

>
>> And, please, limit the length of the changed line in VMPanel.java to 80
>> chars.
>>>
>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>> Thanks for the comments.
>>>>>>> The new version:
>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>> The specification of Event class and InputEvent.getModifiers() are
>>>>>>> updated.
>>>>>>>
>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>> Hi Sergey,
>>>>>>>>
>>>>>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>>>>>> Event.java
>>>>>>>>
>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} class
>>>>>>>> and
>>>>>>>> its
>>>>>>>>     subclasses
>>>>>>>>     *             be used instead.
>>>>>>>>
>>>>>>>>
>>>>>>>> I get the impression they would read better without the redundant
>>>>>>>> "class" in the middle, like so.
>>>>>>>>
>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>>>>>> subclasses
>>>>>>>>     *             be used instead.
>>>>>>>>
>>>>>>>>
>>>>>>>> Kind regards,
>>>>>>>> Jonathan
>>>>>>>>
>>>>>>>>
>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>     Hello.
>>>>>>>>
>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>
>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>> InputEvent.
>>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>>> replaced
>>>>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>>>>> notion
>>>>>>>>     that the new constants should be used. And this bug is about
>>>>>>>>     official deprecation of them.
>>>>>>>>
>>>>>>>>     We can replace old constants by the new one in the whole jdk,
>>>>>>>> but I
>>>>>>>>     updated only the code in InputEvent to make change smaller and
>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>> applications
>>>>>>>>     will start to use the new constants.
>>>>>>>>
>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>> warning.
>>>>>>>>
>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>> tests.
>>>>>>>>
>>>>>>>>
>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>     Webrev can be found at:
>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>
>>>>>>>>     --
>>>>>>>>     Best regards, Sergey.
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 17.10.16 19:01, Semyon Sadetsky wrote:
>> How it could be safe? both are a different constants which should be
>> used in pair with different methods?
> Then why do you add in java doc for those constants:
>  @deprecated It is recommended that *_DOWN_MASK be used instead

This recommendation was there before, since these extended masks and
getModifiersEx() were added and were replaces the old
modifiers/getModifiers().
These are different constants which are responsible for similar, but not
the same behavior.

>>> And, please, limit the length of the changed line in VMPanel.java to 80
>>> chars.
>>>>
>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>> Thanks for the comments.
>>>>>>>> The new version:
>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>> The specification of Event class and InputEvent.getModifiers() are
>>>>>>>> updated.
>>>>>>>>
>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>> Hi Sergey,
>>>>>>>>>
>>>>>>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>>>>>>> Event.java
>>>>>>>>>
>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} class
>>>>>>>>> and
>>>>>>>>> its
>>>>>>>>>     subclasses
>>>>>>>>>     *             be used instead.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I get the impression they would read better without the redundant
>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>
>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>>>>>>> subclasses
>>>>>>>>>     *             be used instead.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Kind regards,
>>>>>>>>> Jonathan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>     Hello.
>>>>>>>>>
>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>
>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>> InputEvent.
>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>>>> replaced
>>>>>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>>>>>> notion
>>>>>>>>>     that the new constants should be used. And this bug is about
>>>>>>>>>     official deprecation of them.
>>>>>>>>>
>>>>>>>>>     We can replace old constants by the new one in the whole jdk,
>>>>>>>>> but I
>>>>>>>>>     updated only the code in InputEvent to make change smaller and
>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>> applications
>>>>>>>>>     will start to use the new constants.
>>>>>>>>>
>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>> warning.
>>>>>>>>>
>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>> tests.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>     Webrev can be found at:
>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>
>>>>>>>>>     --
>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky
On 10/17/2016 7:35 PM, Sergey Bylokhov wrote:

> On 17.10.16 19:01, Semyon Sadetsky wrote:
>>> How it could be safe? both are a different constants which should be
>>> used in pair with different methods?
>> Then why do you add in java doc for those constants:
>>  @deprecated It is recommended that *_DOWN_MASK be used instead
>
> This recommendation was there before, since these extended masks and
> getModifiersEx() were added and were replaces the old
> modifiers/getModifiers().
> These are different constants which are responsible for similar, but
> not the same behavior.
Then this explanation should be added to the javadoc deprecation note
because currently it states that those constants can be replaced with
the new ones. But actually they are related to different APIs and cannot
simply substitute each other.

>
>>>> And, please, limit the length of the changed line in VMPanel.java
>>>> to 80
>>>> chars.
>>>>>
>>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>>> Thanks for the comments.
>>>>>>>>> The new version:
>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>>> The specification of Event class and InputEvent.getModifiers()
>>>>>>>>> are
>>>>>>>>> updated.
>>>>>>>>>
>>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>>> Hi Sergey,
>>>>>>>>>>
>>>>>>>>>> I'm not a reviewer, but after reading the deprecation
>>>>>>>>>> messages in
>>>>>>>>>> Event.java
>>>>>>>>>>
>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} class
>>>>>>>>>> and
>>>>>>>>>> its
>>>>>>>>>>     subclasses
>>>>>>>>>>     *             be used instead.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I get the impression they would read better without the
>>>>>>>>>> redundant
>>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>>
>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and
>>>>>>>>>> its
>>>>>>>>>> subclasses
>>>>>>>>>>     *             be used instead.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Kind regards,
>>>>>>>>>> Jonathan
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>     Hello.
>>>>>>>>>>
>>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>>
>>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>>> InputEvent.
>>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>>>>> replaced
>>>>>>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>>>>>>> notion
>>>>>>>>>>     that the new constants should be used. And this bug is about
>>>>>>>>>>     official deprecation of them.
>>>>>>>>>>
>>>>>>>>>>     We can replace old constants by the new one in the whole
>>>>>>>>>> jdk,
>>>>>>>>>> but I
>>>>>>>>>>     updated only the code in InputEvent to make change
>>>>>>>>>> smaller and
>>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>>> applications
>>>>>>>>>>     will start to use the new constants.
>>>>>>>>>>
>>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>>> warning.
>>>>>>>>>>
>>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>>> tests.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>>     Webrev can be found at:
>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>>
>>>>>>>>>>     --
>>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 17.10.16 21:14, Semyon Sadetsky wrote:
> Then this explanation should be added to the javadoc deprecation note
> because currently it states that those constants can be replaced with
> the new ones. But actually they are related to different APIs and cannot
> simply substitute each other.

It can be replaced if it will be used in pair with getModifiersEx(). The
old getModifiers() is also deprecated. And javadoc for getModifiersEx()
describes what and how constants should be used.

>>
>>>>> And, please, limit the length of the changed line in VMPanel.java
>>>>> to 80
>>>>> chars.
>>>>>>
>>>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>>>> Thanks for the comments.
>>>>>>>>>> The new version:
>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>>>> The specification of Event class and InputEvent.getModifiers()
>>>>>>>>>> are
>>>>>>>>>> updated.
>>>>>>>>>>
>>>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>>
>>>>>>>>>>> I'm not a reviewer, but after reading the deprecation
>>>>>>>>>>> messages in
>>>>>>>>>>> Event.java
>>>>>>>>>>>
>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} class
>>>>>>>>>>> and
>>>>>>>>>>> its
>>>>>>>>>>>     subclasses
>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> I get the impression they would read better without the
>>>>>>>>>>> redundant
>>>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>>>
>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and
>>>>>>>>>>> its
>>>>>>>>>>> subclasses
>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Kind regards,
>>>>>>>>>>> Jonathan
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>>>> <[hidden email] <mailto:[hidden email]>>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>     Hello.
>>>>>>>>>>>
>>>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>>>
>>>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>>>> InputEvent.
>>>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>>>>>> replaced
>>>>>>>>>>>     by the new one. In jdk1.4 the documentation were update with
>>>>>>>>>>> notion
>>>>>>>>>>>     that the new constants should be used. And this bug is about
>>>>>>>>>>>     official deprecation of them.
>>>>>>>>>>>
>>>>>>>>>>>     We can replace old constants by the new one in the whole
>>>>>>>>>>> jdk,
>>>>>>>>>>> but I
>>>>>>>>>>>     updated only the code in InputEvent to make change
>>>>>>>>>>> smaller and
>>>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>>>> applications
>>>>>>>>>>>     will start to use the new constants.
>>>>>>>>>>>
>>>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>>>> warning.
>>>>>>>>>>>
>>>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>>>> tests.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>>>     Webrev can be found at:
>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>>>
>>>>>>>>>>>     --
>>>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky


On 10/17/2016 9:23 PM, Sergey Bylokhov wrote:
> On 17.10.16 21:14, Semyon Sadetsky wrote:
>> Then this explanation should be added to the javadoc deprecation note
>> because currently it states that those constants can be replaced with
>> the new ones. But actually they are related to different APIs and cannot
>> simply substitute each other.
>
> It can be replaced if it will be used in pair with getModifiersEx().
> The old getModifiers() is also deprecated. And javadoc for
> getModifiersEx() describes what and how constants should be used.
Can you add link to getModifiersEx() to all those constants' specs?

>
>>>
>>>>>> And, please, limit the length of the changed line in VMPanel.java
>>>>>> to 80
>>>>>> chars.
>>>>>>>
>>>>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>>>>> Thanks for the comments.
>>>>>>>>>>> The new version:
>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>>>>> The specification of Event class and InputEvent.getModifiers()
>>>>>>>>>>> are
>>>>>>>>>>> updated.
>>>>>>>>>>>
>>>>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>>>
>>>>>>>>>>>> I'm not a reviewer, but after reading the deprecation
>>>>>>>>>>>> messages in
>>>>>>>>>>>> Event.java
>>>>>>>>>>>>
>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent}
>>>>>>>>>>>> class
>>>>>>>>>>>> and
>>>>>>>>>>>> its
>>>>>>>>>>>>     subclasses
>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> I get the impression they would read better without the
>>>>>>>>>>>> redundant
>>>>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>>>>
>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and
>>>>>>>>>>>> its
>>>>>>>>>>>> subclasses
>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Kind regards,
>>>>>>>>>>>> Jonathan
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>>>>> <[hidden email]
>>>>>>>>>>>> <mailto:[hidden email]>>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>     Hello.
>>>>>>>>>>>>
>>>>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>>>>
>>>>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>>>>> InputEvent.
>>>>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>>>>>>> replaced
>>>>>>>>>>>>     by the new one. In jdk1.4 the documentation were update
>>>>>>>>>>>> with
>>>>>>>>>>>> notion
>>>>>>>>>>>>     that the new constants should be used. And this bug is
>>>>>>>>>>>> about
>>>>>>>>>>>>     official deprecation of them.
>>>>>>>>>>>>
>>>>>>>>>>>>     We can replace old constants by the new one in the whole
>>>>>>>>>>>> jdk,
>>>>>>>>>>>> but I
>>>>>>>>>>>>     updated only the code in InputEvent to make change
>>>>>>>>>>>> smaller and
>>>>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>>>>> applications
>>>>>>>>>>>>     will start to use the new constants.
>>>>>>>>>>>>
>>>>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>>>>> warning.
>>>>>>>>>>>>
>>>>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>>>>> tests.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>>>>     Webrev can be found at:
>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>>>>
>>>>>>>>>>>>     --
>>>>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 17.10.16 21:47, Semyon Sadetsky wrote:
>> It can be replaced if it will be used in pair with getModifiersEx().
>> The old getModifiers() is also deprecated. And javadoc for
>> getModifiersEx() describes what and how constants should be used.
> Can you add link to getModifiersEx() to all those constants' specs?

I assume you mean the new _DOWN constants not the old?

>>
>>>>
>>>>>>> And, please, limit the length of the changed line in VMPanel.java
>>>>>>> to 80
>>>>>>> chars.
>>>>>>>>
>>>>>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>>>>>> Thanks for the comments.
>>>>>>>>>>>> The new version:
>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>>>>>> The specification of Event class and InputEvent.getModifiers()
>>>>>>>>>>>> are
>>>>>>>>>>>> updated.
>>>>>>>>>>>>
>>>>>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I'm not a reviewer, but after reading the deprecation
>>>>>>>>>>>>> messages in
>>>>>>>>>>>>> Event.java
>>>>>>>>>>>>>
>>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent}
>>>>>>>>>>>>> class
>>>>>>>>>>>>> and
>>>>>>>>>>>>> its
>>>>>>>>>>>>>     subclasses
>>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> I get the impression they would read better without the
>>>>>>>>>>>>> redundant
>>>>>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>>>>>
>>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent} and
>>>>>>>>>>>>> its
>>>>>>>>>>>>> subclasses
>>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Kind regards,
>>>>>>>>>>>>> Jonathan
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>>>>>> <[hidden email]
>>>>>>>>>>>>> <mailto:[hidden email]>>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>     Hello.
>>>>>>>>>>>>>
>>>>>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>>>>>
>>>>>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>>>>>> InputEvent.
>>>>>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and were
>>>>>>>>>>>>> replaced
>>>>>>>>>>>>>     by the new one. In jdk1.4 the documentation were update
>>>>>>>>>>>>> with
>>>>>>>>>>>>> notion
>>>>>>>>>>>>>     that the new constants should be used. And this bug is
>>>>>>>>>>>>> about
>>>>>>>>>>>>>     official deprecation of them.
>>>>>>>>>>>>>
>>>>>>>>>>>>>     We can replace old constants by the new one in the whole
>>>>>>>>>>>>> jdk,
>>>>>>>>>>>>> but I
>>>>>>>>>>>>>     updated only the code in InputEvent to make change
>>>>>>>>>>>>> smaller and
>>>>>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>>>>>> applications
>>>>>>>>>>>>>     will start to use the new constants.
>>>>>>>>>>>>>
>>>>>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>>>>>> warning.
>>>>>>>>>>>>>
>>>>>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>>>>>> tests.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>>>>>     Webrev can be found at:
>>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>>>>>
>>>>>>>>>>>>>     --
>>>>>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Semyon Sadetsky
On 10/17/2016 9:53 PM, Sergey Bylokhov wrote:

> On 17.10.16 21:47, Semyon Sadetsky wrote:
>>> It can be replaced if it will be used in pair with getModifiersEx().
>>> The old getModifiers() is also deprecated. And javadoc for
>>> getModifiersEx() describes what and how constants should be used.
>> Can you add link to getModifiersEx() to all those constants' specs?
>
> I assume you mean the new _DOWN constants not the old?
I meant that deprecated message should be transparently explaining the
impact of the replacement.
The proposed specs change recommends to use a replacement which is not
equivalent to the deprecated API. And that is the reason why you don't
like to eliminate all old API usages in the JDK code as a part of the
fix, if I correctly understand you previous reply in this thread.
Since you are insisting that migrating to the new API is risky it is
worth let the user know about that risk as well.

>
>>>
>>>>>
>>>>>>>> And, please, limit the length of the changed line in VMPanel.java
>>>>>>>> to 80
>>>>>>>> chars.
>>>>>>>>>
>>>>>>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>>>>>>> Thanks for the comments.
>>>>>>>>>>>>> The new version:
>>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>>>>>>> The specification of Event class and
>>>>>>>>>>>>> InputEvent.getModifiers()
>>>>>>>>>>>>> are
>>>>>>>>>>>>> updated.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'm not a reviewer, but after reading the deprecation
>>>>>>>>>>>>>> messages in
>>>>>>>>>>>>>> Event.java
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent}
>>>>>>>>>>>>>> class
>>>>>>>>>>>>>> and
>>>>>>>>>>>>>> its
>>>>>>>>>>>>>>     subclasses
>>>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I get the impression they would read better without the
>>>>>>>>>>>>>> redundant
>>>>>>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent}
>>>>>>>>>>>>>> and
>>>>>>>>>>>>>> its
>>>>>>>>>>>>>> subclasses
>>>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Kind regards,
>>>>>>>>>>>>>> Jonathan
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>>>>>>> <[hidden email]
>>>>>>>>>>>>>> <mailto:[hidden email]>>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     Hello.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>>>>>>> InputEvent.
>>>>>>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and
>>>>>>>>>>>>>> were
>>>>>>>>>>>>>> replaced
>>>>>>>>>>>>>>     by the new one. In jdk1.4 the documentation were update
>>>>>>>>>>>>>> with
>>>>>>>>>>>>>> notion
>>>>>>>>>>>>>>     that the new constants should be used. And this bug is
>>>>>>>>>>>>>> about
>>>>>>>>>>>>>>     official deprecation of them.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     We can replace old constants by the new one in the whole
>>>>>>>>>>>>>> jdk,
>>>>>>>>>>>>>> but I
>>>>>>>>>>>>>>     updated only the code in InputEvent to make change
>>>>>>>>>>>>>> smaller and
>>>>>>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>>>>>>> applications
>>>>>>>>>>>>>>     will start to use the new constants.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>>>>>>> warning.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>>>>>>> tests.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>>>>>>     Webrev can be found at:
>>>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>     --
>>>>>>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Sergey Bylokhov
On 19.10.16 9:58, Semyon Sadetsky wrote:

>> On 17.10.16 21:47, Semyon Sadetsky wrote:
>>>> It can be replaced if it will be used in pair with getModifiersEx().
>>>> The old getModifiers() is also deprecated. And javadoc for
>>>> getModifiersEx() describes what and how constants should be used.
>>> Can you add link to getModifiersEx() to all those constants' specs?
>>
>> I assume you mean the new _DOWN constants not the old?
> I meant that deprecated message should be transparently explaining the
> impact of the replacement.
> The proposed specs change recommends to use a replacement which is not
> equivalent to the deprecated API. And that is the reason why you don't
> like to eliminate all old API usages in the JDK code as a part of the
> fix, if I correctly understand you previous reply in this thread.
> Since you are insisting that migrating to the new API is risky it is
> worth let the user know about that risk as well.

What does it mean risky? The new API is safe, but it is not safe to just
find+replace the old constants to the new one, because it will be
necessary to check how they are used. We already have a notions that
these "extended modifier constant" should be used in the constructor of
InputEvent and moreover in spec of getModifiersEx() we have an
additional examples how to use this constants. This is why we will have
a reference from old constans to the new, and from getModifiers() to the
getModifiersEx();

>>>>>>>>> And, please, limit the length of the changed line in VMPanel.java
>>>>>>>>> to 80
>>>>>>>>> chars.
>>>>>>>>>>
>>>>>>>>>>>>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>>>>>>>>>>>>> Thanks for the comments.
>>>>>>>>>>>>>> The new version:
>>>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>>>>>>>>>>>>> The specification of Event class and
>>>>>>>>>>>>>> InputEvent.getModifiers()
>>>>>>>>>>>>>> are
>>>>>>>>>>>>>> updated.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>>>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'm not a reviewer, but after reading the deprecation
>>>>>>>>>>>>>>> messages in
>>>>>>>>>>>>>>> Event.java
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent}
>>>>>>>>>>>>>>> class
>>>>>>>>>>>>>>> and
>>>>>>>>>>>>>>> its
>>>>>>>>>>>>>>>     subclasses
>>>>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I get the impression they would read better without the
>>>>>>>>>>>>>>> redundant
>>>>>>>>>>>>>>> "class" in the middle, like so.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     * @deprecated It is recommended that {@code AWTEvent}
>>>>>>>>>>>>>>> and
>>>>>>>>>>>>>>> its
>>>>>>>>>>>>>>> subclasses
>>>>>>>>>>>>>>>     *             be used instead.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Kind regards,
>>>>>>>>>>>>>>> Jonathan
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>>>>>>>>>>>>> <[hidden email]
>>>>>>>>>>>>>>> <mailto:[hidden email]>>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     Hello.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     Please review the fix for jdk9.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     This is request to deprecate the obsolete flags inside
>>>>>>>>>>>>>>> InputEvent.
>>>>>>>>>>>>>>>     This constants were marked as obsolete in jdk1.4 and
>>>>>>>>>>>>>>> were
>>>>>>>>>>>>>>> replaced
>>>>>>>>>>>>>>>     by the new one. In jdk1.4 the documentation were update
>>>>>>>>>>>>>>> with
>>>>>>>>>>>>>>> notion
>>>>>>>>>>>>>>>     that the new constants should be used. And this bug is
>>>>>>>>>>>>>>> about
>>>>>>>>>>>>>>>     official deprecation of them.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     We can replace old constants by the new one in the whole
>>>>>>>>>>>>>>> jdk,
>>>>>>>>>>>>>>> but I
>>>>>>>>>>>>>>>     updated only the code in InputEvent to make change
>>>>>>>>>>>>>>> smaller and
>>>>>>>>>>>>>>>     safer. So at least the new code in jdk and the code in
>>>>>>>>>>>>>>> applications
>>>>>>>>>>>>>>>     will start to use the new constants.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     The changes in jconsole are necessary to fix deprecation
>>>>>>>>>>>>>>> warning.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     jprt build passed, no new issues were found by jck/jtreg
>>>>>>>>>>>>>>> tests.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>>>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>>>>>>>>>>>>     Webrev can be found at:
>>>>>>>>>>>>>>> http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>>>>>>>>>>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>     --
>>>>>>>>>>>>>>>     Best regards, Sergey.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


--
Best regards, Sergey.
12
Loading...