<Swing Dev> [9] Review Request: 8176177 The new SwingContainer annotation can be removed from javax.accessibility.AccessibleContext

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] Review Request: 8176177 The new SwingContainer annotation can be removed from javax.accessibility.AccessibleContext

Sergey Bylokhov
Hello,
Please review the fix for jdk9.
When the new annotation SwingContainer was added to the Swing library, we applied it to all classes where the old compile time bean-info has an isContainer=false attribute.
The goal of this annotation is to point that some class which extends Container in the Swing library is not actually a container. So it is an error to mark the class if is not a container.

In the fix this annotation was removed from javax.accessibility.AccessibleContext.

Bug: https://bugs.openjdk.java.net/browse/JDK-8176177
Webrev can be found at: http://cr.openjdk.java.net/~serb/8176177/webrev.00

CCC will be filed after technical review.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> <Beans Dev> [9] Review Request: 8176177 The new SwingContainer annotation can be removed from javax.accessibility.AccessibleContext

Alexandr Scherbatiy

The fix looks good to me.

Thanks,
Alexandr.

On 3/6/2017 5:00 PM, Sergey Bylokhov wrote:

> Hello,
> Please review the fix for jdk9.
> When the new annotation SwingContainer was added to the Swing library, we applied it to all classes where the old compile time bean-info has an isContainer=false attribute.
> The goal of this annotation is to point that some class which extends Container in the Swing library is not actually a container. So it is an error to mark the class if is not a container.
>
> In the fix this annotation was removed from javax.accessibility.AccessibleContext.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176177
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8176177/webrev.00
>
> CCC will be filed after technical review.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8176177 The new SwingContainer annotation can be removed from javax.accessibility.AccessibleContext

Sergey Malenkov-2
In reply to this post by Sergey Bylokhov
The fix looks good to me

On Mon, Mar 6, 2017 at 5:00 PM, Sergey Bylokhov
<[hidden email]> wrote:

> Hello,
> Please review the fix for jdk9.
> When the new annotation SwingContainer was added to the Swing library, we applied it to all classes where the old compile time bean-info has an isContainer=false attribute.
> The goal of this annotation is to point that some class which extends Container in the Swing library is not actually a container. So it is an error to mark the class if is not a container.
>
> In the fix this annotation was removed from javax.accessibility.AccessibleContext.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176177
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8176177/webrev.00
>
> CCC will be filed after technical review.



--
Best regards,
Sergey A. Malenkov
Loading...