<Swing Dev> [9] Review Request: 8176544 Compilation error in plaf.metal.MetalBumps.Test6657026

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> [9] Review Request: 8176544 Compilation error in plaf.metal.MetalBumps.Test6657026

Sergey Bylokhov
Hello,
Please review the fix for jdk9.
This test uses "ToolBarBorder.MetalBumps" which is not accessible because it is not public.
The code was updated to use ToolBarBorder which contains MetalBumps.
I have rechecked that the updated version of the test fails/pass before/after the initial bug was fixed.

Bug: https://bugs.openjdk.java.net/browse/JDK-8176544
Webrev can be found at: http://cr.openjdk.java.net/~serb/8176544/webrev,00
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> [9] Review Request: 8176544 Compilation error in plaf.metal.MetalBumps.Test6657026

Philip Race
Fine by me.
I am curious why a compilation failure wasn't found immediately ?

-phil.

On 03/17/2017 01:37 PM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
> This test uses "ToolBarBorder.MetalBumps" which is not accessible because it is not public.
> The code was updated to use ToolBarBorder which contains MetalBumps.
> I have rechecked that the updated version of the test fails/pass before/after the initial bug was fixed.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176544
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8176544/webrev,00