<Swing Dev> [9] Review Request: 8177766 [TEST_BUG] JPopupMenu tests fails intermittently

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] Review Request: 8177766 [TEST_BUG] JPopupMenu tests fails intermittently

Sergey Bylokhov
Hello,
Please review the fix for jdk9.

The problem is that these tests shows popup menu and expects that some specific menuitems will be selected after keyboard navigation. But some other test in the javax/swing/JPopupMenu/** moves the mouse to some specific position, which causes an auto-selection(in Aqua Look&Feel) of the menu item and wrong final test result. Note that if the tests are executed alone it is always passed(if the mouse is not under popup menu).

Bug: https://bugs.openjdk.java.net/browse/JDK-8177766
Webrev can be found at: http://cr.openjdk.java.net/~serb/8177766/webrev.00
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8177766 [TEST_BUG] JPopupMenu tests fails intermittently

Yuri Nesterenko
Looks fine.

-yan

On 03/29/2017 03:46 PM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> The problem is that these tests shows popup menu and expects that some specific menuitems will be selected after keyboard navigation. But some other test in the javax/swing/JPopupMenu/** moves the mouse to some specific position, which causes an auto-selection(in Aqua Look&Feel) of the menu item and wrong final test result. Note that if the tests are executed alone it is always passed(if the mouse is not under popup menu).
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8177766
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8177766/webrev.00
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review Request: 8177766 [TEST_BUG] JPopupMenu tests fails intermittently

Alexandr Scherbatiy
In reply to this post by Sergey Bylokhov
The fix looks good to me.

Thanks,
Alexandr.

On 29/03/17 16:46, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> The problem is that these tests shows popup menu and expects that some specific menuitems will be selected after keyboard navigation. But some other test in the javax/swing/JPopupMenu/** moves the mouse to some specific position, which causes an auto-selection(in Aqua Look&Feel) of the menu item and wrong final test result. Note that if the tests are executed alone it is always passed(if the mouse is not under popup menu).
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8177766
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8177766/webrev.00

Loading...