<Swing Dev> [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

<Swing Dev> [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

Semyon Sadetsky
Hello,

Please review the fix for jdk9.

bug: https://bugs.openjdk.java.net/browse/JDK-8178984

webrev: http://cr.openjdk.java.net/~ssadetsky/8178984/webrev.00/

Angle brackets around "true" are removed.

--Semyon

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

Jayathirth D v
Hi Semyon,

Changes are fine.

Thanks,
Jay

-----Original Message-----
From: Semyon Sadetsky
Sent: Thursday, April 20, 2017 2:27 AM
To: [hidden email]
Subject: [OpenJDK 2D-Dev] <Swing Dev> [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

Hello,

Please review the fix for jdk9.

bug: https://bugs.openjdk.java.net/browse/JDK-8178984

webrev: http://cr.openjdk.java.net/~ssadetsky/8178984/webrev.00/

Angle brackets around "true" are removed.

--Semyon

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

Prahalad kumar Narayanan
In reply to this post by Semyon Sadetsky
Hello Semyon

The fix looks good.

Thanks
Have a good day

Prahalad N.

----------------------------------------------------------------------

Message: 1
Date: Wed, 19 Apr 2017 13:56:30 -0700
From: Semyon Sadetsky <[hidden email]>
To: [hidden email]
Subject: [OpenJDK 2D-Dev] <Swing Dev> [9] Review request for 8178984:
        Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.
Message-ID: <[hidden email]>
Content-Type: text/plain; charset=utf-8; format=flowed

Hello,

Please review the fix for jdk9.

bug: https://bugs.openjdk.java.net/browse/JDK-8178984

webrev: http://cr.openjdk.java.net/~ssadetsky/8178984/webrev.00/

Angle brackets around "true" are removed.

--Semyon
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: <Swing Dev> [9] Review request for 8178984: Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.

Philip Race
Approved. You may push.

-phil.

On 04/20/2017 07:18 AM, Prahalad Kumar Narayanan wrote:

> Hello Semyon
>
> The fix looks good.
>
> Thanks
> Have a good day
>
> Prahalad N.
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 19 Apr 2017 13:56:30 -0700
> From: Semyon Sadetsky <[hidden email]>
> To: [hidden email]
> Subject: [OpenJDK 2D-Dev] <Swing Dev> [9] Review request for 8178984:
> Unnecessary angle brackets in the Line2D::intersectsLine() javadoc.
> Message-ID: <[hidden email]>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> Hello,
>
> Please review the fix for jdk9.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8178984
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8178984/webrev.00/
>
> Angle brackets around "true" are removed.
>
> --Semyon

Loading...