<Swing Dev> RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

Alexandre (Shura) Iline
Hi,

Please take a look on this fix.

Bug: https://bugs.openjdk.java.net/browse/JDK-8157338

I have changed the code to _wait_ for the image change and I have also replaced some of the homemade code with proper Jemmy calls.

Webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.00/

Thank you.

Shura

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

Sergey Bylokhov
Hi, Shura.
This test was added to the open/test/jdk/ProblemList.txt:
# jdk_swing
sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java        8157338
generic-all

If the bug is fixed then this record can be removed.


On 14/11/2017 11:03, Alexandre (Shura) Iline wrote:

> Hi,
>
> Please take a look on this fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8157338
>
> I have changed the code to _wait_ for the image change and I have also replaced some of the homemade code with proper Jemmy calls.
>
> Webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.00/
>
> Thank you.
>
> Shura
>


--
Best regards, Sergey.
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

Alexandre (Shura) Iline


> On Nov 14, 2017, at 2:03 PM, Sergey Bylokhov <[hidden email]> wrote:
>
> Hi, Shura.
> This test was added to the open/test/jdk/ProblemList.txt:
> # jdk_swing
> sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java        8157338 generic-all
>
> If the bug is fixed then this record can be removed.


Ah! Thank you!

New webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.01

Shura

>
>
> On 14/11/2017 11:03, Alexandre (Shura) Iline wrote:
>> Hi,
>> Please take a look on this fix.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157338
>> I have changed the code to _wait_ for the image change and I have also replaced some of the homemade code with proper Jemmy calls.
>> Webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.00/
>> Thank you.
>> Shura
>
>
> --
> Best regards, Sergey.

Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

Sergey Bylokhov
Looks fine.

On 14/11/2017 14:52, Alexandre (Shura) Iline wrote:

>
>
>> On Nov 14, 2017, at 2:03 PM, Sergey Bylokhov <[hidden email]> wrote:
>>
>> Hi, Shura.
>> This test was added to the open/test/jdk/ProblemList.txt:
>> # jdk_swing
>> sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java        8157338 generic-all
>>
>> If the bug is fixed then this record can be removed.
>
>
> Ah! Thank you!
>
> New webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.01
>
> Shura
>
>>
>>
>> On 14/11/2017 11:03, Alexandre (Shura) Iline wrote:
>>> Hi,
>>> Please take a look on this fix.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157338
>>> I have changed the code to _wait_ for the image change and I have also replaced some of the homemade code with proper Jemmy calls.
>>> Webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.00/
>>> Thank you.
>>> Shura
>>
>>
>> --
>> Best regards, Sergey.
>


--
Best regards, Sergey.