<Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode

Pankaj Bansal-2
Please review a trivial test only fix.

This is a manual test and create an instruction panel containing JTextArea. The JTextArea background color is hardcoded as white color, which is causing issues on dark mode in Ubuntu 20.04 and Ubuntu 20.10 as the text color is also white. The fix is to remove the hardcoded white color as the JTextArea background color should be set by L&F and should not be hardcoded in test.

-------------

Commit messages:
 - Add bugID
 - 8260291: The case instruction is not visible in dark mode

Changes: https://git.openjdk.java.net/jdk/pull/2564/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2564&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8260291
  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2564.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2564/head:pull/2564

PR: https://git.openjdk.java.net/jdk/pull/2564
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode

Tejpal Rebari-2
On Sun, 14 Feb 2021 07:49:39 GMT, Pankaj Bansal <[hidden email]> wrote:

> Please review a trivial test only fix.
>
> This is a GTKL&F specific manual test and create an instruction panel containing JTextArea. The JTextArea background color is hardcoded as white color, which is causing issues on dark mode in Ubuntu 20.04 and Ubuntu 20.10 as the text color is also white. The fix is to remove the hardcoded white color as the JTextArea background color should be set by L&F and should not be hardcoded in test.

test/jdk/javax/swing/JSpinner/TestJSpinnerPressUnpress.java line 26:

> 24: /*
> 25:  * @test
> 26:  * @bug 8234733 8260291

There is no need to add bug id 8260291 here.
http://openjdk.java.net/jtreg/faq.html#when-should-i-update-the-bug-entry-in-a-test-description

-------------

PR: https://git.openjdk.java.net/jdk/pull/2564
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode [v2]

Pankaj Bansal-2
In reply to this post by Pankaj Bansal-2
> Please review a trivial test only fix.
>
> This is a GTKL&F specific manual test and create an instruction panel containing JTextArea. The JTextArea background color is hardcoded as white color, which is causing issues on dark mode in Ubuntu 20.04 and Ubuntu 20.10 as the text color is also white. The fix is to remove the hardcoded white color as the JTextArea background color should be set by L&F and should not be hardcoded in test.

Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:

  Revert "Add bugID"
 
  This reverts commit a84b6098bee8122abd159209a1ff857db716f4b4.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2564/files
  - new: https://git.openjdk.java.net/jdk/pull/2564/files/a84b6098..8eec0dd4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2564&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2564&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2564.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2564/head:pull/2564

PR: https://git.openjdk.java.net/jdk/pull/2564
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode [v2]

Pankaj Bansal-2
In reply to this post by Tejpal Rebari-2
On Mon, 15 Feb 2021 06:07:37 GMT, Tejpal Rebari <[hidden email]> wrote:

>> Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Revert "Add bugID"
>>  
>>   This reverts commit a84b6098bee8122abd159209a1ff857db716f4b4.
>
> test/jdk/javax/swing/JSpinner/TestJSpinnerPressUnpress.java line 26:
>
>> 24: /*
>> 25:  * @test
>> 26:  * @bug 8234733 8260291
>
> There is no need to add bug id 8260291 here.
> http://openjdk.java.net/jtreg/faq.html#when-should-i-update-the-bug-entry-in-a-test-description

ok, makes sense. I have removed the bugID.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2564
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode [v2]

Tejpal Rebari-2
In reply to this post by Pankaj Bansal-2
On Mon, 15 Feb 2021 06:36:58 GMT, Pankaj Bansal <[hidden email]> wrote:

>> Please review a trivial test only fix.
>>
>> This is a GTKL&F specific manual test and create an instruction panel containing JTextArea. The JTextArea background color is hardcoded as white color, which is causing issues on dark mode in Ubuntu 20.04 and Ubuntu 20.10 as the text color is also white. The fix is to remove the hardcoded white color as the JTextArea background color should be set by L&F and should not be hardcoded in test.
>
> Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:
>
>   Revert "Add bugID"
>  
>   This reverts commit a84b6098bee8122abd159209a1ff857db716f4b4.

Marked as reviewed by trebari (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2564
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8260291: The case instruction is not visible in dark mode [v2]

Alexey Ivanov-2
In reply to this post by Pankaj Bansal-2
On Mon, 15 Feb 2021 06:36:58 GMT, Pankaj Bansal <[hidden email]> wrote:

>> Please review a trivial test only fix.
>>
>> This is a GTKL&F specific manual test and create an instruction panel containing JTextArea. The JTextArea background color is hardcoded as white color, which is causing issues on dark mode in Ubuntu 20.04 and Ubuntu 20.10 as the text color is also white. The fix is to remove the hardcoded white color as the JTextArea background color should be set by L&F and should not be hardcoded in test.
>
> Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:
>
>   Revert "Add bugID"
>  
>   This reverts commit a84b6098bee8122abd159209a1ff857db716f4b4.

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2564
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: 8260291: The case instruction is not visible in dark mode

Pankaj Bansal-2
In reply to this post by Pankaj Bansal-2
On Sun, 14 Feb 2021 07:49:39 GMT, Pankaj Bansal <[hidden email]> wrote:

> Please review a trivial test only fix.
>
> This is a GTKL&F specific manual test and create an instruction panel containing JTextArea. The JTextArea background color is hardcoded as white color, which is causing issues on dark mode in Ubuntu 20.04 and Ubuntu 20.10 as the text color is also white. The fix is to remove the hardcoded white color as the JTextArea background color should be set by L&F and should not be hardcoded in test.

This pull request has now been integrated.

Changeset: 849f4c0f
Author:    Pankaj Bansal <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/849f4c0f
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8260291: The case instruction is not visible in dark mode

Reviewed-by: trebari, aivanov

-------------

PR: https://git.openjdk.java.net/jdk/pull/2564