<Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Prasanta Sadhukhan-2
javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

-------------

Commit messages:
 - 8263170: ComboBoxModel documentation refers to a nonexistant type

Changes: https://git.openjdk.java.net/jdk/pull/2886/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2886&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263170
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2886.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2886/head:pull/2886

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Alexander Zvegintsev-2
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

Marked as reviewed by azvegint (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Tejpal Rebari-2
In reply to this post by Prasanta Sadhukhan-2
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

Marked as reviewed by trebari (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Pankaj Bansal-2
In reply to this post by Prasanta Sadhukhan-2
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

Marked as reviewed by pbansal (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Alexey Ivanov-2
In reply to this post by Prasanta Sadhukhan-2
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Alexander Zuev-3
In reply to this post by Prasanta Sadhukhan-2
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

Sergey Bylokhov-2
On Tue, 9 Mar 2021 21:32:08 GMT, Alexander Zuev <[hidden email]> wrote:

>> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.
>
> Marked as reviewed by kizune (Reviewer).

I suggest always update the copyright.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistent type [v2]

Prasanta Sadhukhan-2
In reply to this post by Prasanta Sadhukhan-2
> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Copyright change

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2886/files
  - new: https://git.openjdk.java.net/jdk/pull/2886/files/68b4fbe6..87c89395

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2886&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2886&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2886.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2886/head:pull/2886

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: 8263170: ComboBoxModel documentation refers to a nonexistent type

Prasanta Sadhukhan-2
In reply to this post by Prasanta Sadhukhan-2
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

This pull request has now been integrated.

Changeset: 3fe8a466
Author:    Prasanta Sadhukhan <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/3fe8a466
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8263170: ComboBoxModel documentation refers to a nonexistent type

Reviewed-by: azvegint, trebari, pbansal, aivanov, kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistent type [v2]

Andrey Turbanov-2
In reply to this post by Sergey Bylokhov-2
On Wed, 10 Mar 2021 00:58:36 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> Marked as reviewed by kizune (Reviewer).
>
> I suggest always update the copyright.

There is one more occurrence of `ListDataModel` in JDK code - https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/ListModel.java#L34
Perhaps it's worth to fix it too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263170: ComboBoxModel documentation refers to a nonexistent type [v2]

Prasanta Sadhukhan-2
On Wed, 10 Mar 2021 18:09:37 GMT, Andrey Turbanov <[hidden email]> wrote:

>
>
> There is one more occurrence of `ListDataModel` in JDK code - https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/ListModel.java#L34
> Perhaps it's worth to fix it too.

ok. will take a look.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2886