<Swing Dev> RFR: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale

Prasanta Sadhukhan-2
The current state of specification for
https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JComponent.html#setDefaultLocale(java.util.Locale)
doesn't mention anything about passing 'null' as a new default locale.

In fact for OpenJDK implementation passing 'null' restores the default VM's locale.
This is now explicitly stated in javadoc.

-------------

Commit messages:
 - 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale

Changes: https://git.openjdk.java.net/jdk/pull/3003/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3003&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263481
  Stats: 52 lines in 2 files changed: 52 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3003.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3003/head:pull/3003

PR: https://git.openjdk.java.net/jdk/pull/3003
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale [v2]

Prasanta Sadhukhan-2
> The current state of specification for
> https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JComponent.html#setDefaultLocale(java.util.Locale)
> doesn't mention anything about passing 'null' as a new default locale.
>
> In fact for OpenJDK implementation passing 'null' restores the default VM's locale.
> This is now explicitly stated in javadoc.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Test modification

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3003/files
  - new: https://git.openjdk.java.net/jdk/pull/3003/files/acc270ea..d35284f6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3003&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3003&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3003.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3003/head:pull/3003

PR: https://git.openjdk.java.net/jdk/pull/3003
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale [v2]

Alexey Ivanov-2
On Wed, 17 Mar 2021 08:03:39 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

>> The current state of specification for
>> https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JComponent.html#setDefaultLocale(java.util.Locale)
>> doesn't mention anything about passing 'null' as a new default locale.
>>
>> In fact for OpenJDK implementation passing 'null' restores the default VM's locale.
>> This is now explicitly stated in javadoc.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
>   Test modification

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3003
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale

Prasanta Sadhukhan-2
In reply to this post by Prasanta Sadhukhan-2
On Mon, 15 Mar 2021 06:52:15 GMT, Prasanta Sadhukhan <[hidden email]> wrote:

> The current state of specification for
> https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JComponent.html#setDefaultLocale(java.util.Locale)
> doesn't mention anything about passing 'null' as a new default locale.
>
> In fact for OpenJDK implementation passing 'null' restores the default VM's locale.
> This is now explicitly stated in javadoc.

This pull request has now been integrated.

Changeset: d24e4cfe
Author:    Prasanta Sadhukhan <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/d24e4cfe
Stats:     50 lines in 2 files changed: 50 ins; 0 del; 0 mod

8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.java.net/jdk/pull/3003