<Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Aleksey Shipilev-5
SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".

-------------

Commit messages:
 - 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Changes: https://git.openjdk.java.net/jdk/pull/3121/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3121&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263977
  Stats: 3 lines in 2 files changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3121.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3121/head:pull/3121

PR: https://git.openjdk.java.net/jdk/pull/3121
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Sergey Bylokhov-2
On Mon, 22 Mar 2021 15:40:41 GMT, Aleksey Shipilev <[hidden email]> wrote:

> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".

Looks fine, please update the dates.

-------------

Marked as reviewed by serb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3121
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Pankaj Bansal-2
In reply to this post by Aleksey Shipilev-5
On Mon, 22 Mar 2021 15:40:41 GMT, Aleksey Shipilev <[hidden email]> wrote:

> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".

Marked as reviewed by pbansal (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3121
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Alexander Zuev-3
In reply to this post by Aleksey Shipilev-5
On Mon, 22 Mar 2021 15:40:41 GMT, Aleksey Shipilev <[hidden email]> wrote:

> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3121
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel [v2]

Aleksey Shipilev-5
In reply to this post by Aleksey Shipilev-5
> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Update copyrights

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3121/files
  - new: https://git.openjdk.java.net/jdk/pull/3121/files/285cefc5..2c434a57

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3121&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3121&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3121.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3121/head:pull/3121

PR: https://git.openjdk.java.net/jdk/pull/3121
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel [v2]

Pankaj Bansal-2
On Mon, 22 Mar 2021 18:25:57 GMT, Aleksey Shipilev <[hidden email]> wrote:

>> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
>   Update copyrights

Marked as reviewed by pbansal (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3121
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: 8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Aleksey Shipilev-5
In reply to this post by Aleksey Shipilev-5
On Mon, 22 Mar 2021 15:40:41 GMT, Aleksey Shipilev <[hidden email]> wrote:

> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||".

This pull request has now been integrated.

Changeset: df01b15b
Author:    Aleksey Shipilev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/df01b15b
Stats:     5 lines in 2 files changed: 0 ins; 2 del; 3 mod

8263977: GTK L&F: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

Reviewed-by: serb, pbansal, kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/3121