<Swing Dev> RFR: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Jie Fu-2
Hi all,

I'd like to fix the timeout of javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
It seems to take about 6~7 seconds to run on some of our testing platforms.
But the timeout of the test is hard-coded as 5 seconds.

The fix just increases the timeout from 5 seconds to 10 seconds.

Thanks.
Best regards,
Jie

-------------

Commit messages:
 - Update the copyright year
 - 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Changes: https://git.openjdk.java.net/jdk/pull/3287/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3287&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264526
  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3287.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3287/head:pull/3287

PR: https://git.openjdk.java.net/jdk/pull/3287
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Alexander Zvegintsev-2
On Wed, 31 Mar 2021 16:23:23 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> I'd like to fix the timeout of javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
> It seems to take about 6~7 seconds to run on some of our testing platforms.
> But the timeout of the test is hard-coded as 5 seconds.
>
> The fix just increases the timeout from 5 seconds to 10 seconds.
>
> Thanks.
> Best regards,
> Jie

[JDK-8078268](https://bugs.openjdk.java.net/browse/JDK-8078268) description says that it takes minutes to parse to complete before the fix. So 10 seconds is not a big deal comparing to minutes. However it might indicate a slight drop in performance.

> It seems to take about 6~7 seconds to run on some of our testing platforms.

Did it fail on these platforms from the beginning of your testing with `bug8078268`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3287
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Jie Fu-2
On Wed, 31 Mar 2021 18:57:50 GMT, Alexander Zvegintsev <[hidden email]> wrote:

> Did it fail on these platforms from the beginning of your testing with `bug8078268`?

No.

This week I add some testing infrastructure on dockers.
The timeout seems only to be observed on these dockers intermittently.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3287
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Sergey Bylokhov-2
In reply to this post by Jie Fu-2
On Wed, 31 Mar 2021 16:23:23 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> I'd like to fix the timeout of javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
> It seems to take about 6~7 seconds to run on some of our testing platforms.
> But the timeout of the test is hard-coded as 5 seconds.
>
> The fix just increases the timeout from 5 seconds to 10 seconds.
>
> Thanks.
> Best regards,
> Jie

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3287
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Jie Fu-2
On Fri, 2 Apr 2021 06:11:00 GMT, Sergey Bylokhov <[hidden email]> wrote:

>> Hi all,
>>
>> I'd like to fix the timeout of javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
>> It seems to take about 6~7 seconds to run on some of our testing platforms.
>> But the timeout of the test is hard-coded as 5 seconds.
>>
>> The fix just increases the timeout from 5 seconds to 10 seconds.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Marked as reviewed by serb (Reviewer).

Thanks @mrserb for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3287
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Jie Fu-2
In reply to this post by Jie Fu-2
On Wed, 31 Mar 2021 16:23:23 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> I'd like to fix the timeout of javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
> It seems to take about 6~7 seconds to run on some of our testing platforms.
> But the timeout of the test is hard-coded as 5 seconds.
>
> The fix just increases the timeout from 5 seconds to 10 seconds.
>
> Thanks.
> Best regards,
> Jie

This pull request has now been integrated.

Changeset: da643cdb
Author:    Jie Fu <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/da643cdb
Stats:     4 lines in 1 file changed: 1 ins; 0 del; 3 mod

8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3287