<Swing Dev> RFR: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> RFR: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Daniel D.Daugherty
A trivial fix to ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

-------------

Depends on: https://git.openjdk.java.net/jdk/pull/3329

Commit messages:
 - 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Changes: https://git.openjdk.java.net/jdk/pull/3330/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3330&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264658
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3330.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3330/head:pull/3330

PR: https://git.openjdk.java.net/jdk/pull/3330
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64 [v2]

Daniel D.Daugherty
> A trivial fix to ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3330/files
  - new: https://git.openjdk.java.net/jdk/pull/3330/files/08d28602..08d28602

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3330&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3330&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3330.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3330/head:pull/3330

PR: https://git.openjdk.java.net/jdk/pull/3330
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64 [v3]

Daniel D.Daugherty
In reply to this post by Daniel D.Daugherty
> A trivial fix to ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into JDK-8264658
 - 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64
 - 8264657: ProblemList java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java on linux-x64

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3330/files
  - new: https://git.openjdk.java.net/jdk/pull/3330/files/08d28602..36454a93

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3330&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3330&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3330.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3330/head:pull/3330

PR: https://git.openjdk.java.net/jdk/pull/3330
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64 [v3]

Pankaj Bansal-2
On Fri, 2 Apr 2021 19:03:43 GMT, Daniel D. Daugherty <[hidden email]> wrote:

>> A trivial fix to ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64
>
> Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
>  - Merge branch 'master' into JDK-8264658
>  - 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64
>  - 8264657: ProblemList java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java on linux-x64

Marked as reviewed by pbansal (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3330
Reply | Threaded
Open this post in threaded view
|

Re: <Swing Dev> RFR: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64 [v3]

Daniel D.Daugherty
On Fri, 2 Apr 2021 19:07:57 GMT, Pankaj Bansal <[hidden email]> wrote:

>> Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>>  - Merge branch 'master' into JDK-8264658
>>  - 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64
>>  - 8264657: ProblemList java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java on linux-x64
>
> Marked as reviewed by pbansal (Reviewer).

@pankaj-bansal - Thanks for the fast review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3330
Reply | Threaded
Open this post in threaded view
|

<Swing Dev> Integrated: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Daniel D.Daugherty
In reply to this post by Daniel D.Daugherty
On Fri, 2 Apr 2021 18:42:26 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

This pull request has now been integrated.

Changeset: 4133dede
Author:    Daniel D. Daugherty <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/4133dede
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Reviewed-by: pbansal

-------------

PR: https://git.openjdk.java.net/jdk/pull/3330